September 2010 - Wine-devel

Re: dnsapi: Remove the critical section around res_query on Linux.
by Alexandre Julliard 08 Sep '10

08 Sep '10

Hans Leidekker <hans(a)codeweavers.com> writes: > glibc's resolver supports threads since 2.3.2, released in 2003. > Fixes http://bugs.winehq.org/show_bug.cgi?id=24180 It seems to me this would affect all platforms. Why fix it only for Linux? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] msi/test: Test more combinations of platforms and installer properties.
by testbot＠testbot.winehq.org 08 Sep '10

08 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5136 Your paranoid android. === W7PROX64 (64 bit package) === package.c:8393: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8404: Test failed: Expected "C:\winetest\", got "" package.c:8415: Test failed: Expected "C:\winetest\", got "" package.c:8465: Test failed: Expected "C:\winetest\FileName3.dll", got "" package.c:8476: Test failed: Expected "C:\winetest\FileName5.dll", got "" package.c:8485: Test failed: Expected "C:\", got "" package.c:8491: Test failed: Expected "C:\winetest\", got "" package.c:8512: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8521: Test failed: Expected "C:\winetest\FileName1", got ""

1 0

Re: [PATCH 2/5] d3d8.h: undefine INTERFACE before defining it
by Alexandre Julliard 08 Sep '10

08 Sep '10

Roderick Colenbrander <thunderbird2k(a)gmail.com> writes: > @@ -129,6 +129,7 @@ typedef struct IDirect3DVolumeTexture8 *LPDIRECT3DVOLUMETEXTURE8, *PDIRECT3DVOLU > /***************************************************************************** > * IDirect3D8 interface > */ > +#undef INTERFACE > #define INTERFACE IDirect3D8 > DECLARE_INTERFACE_(IDirect3D8,IUnknown) > { The standard pattern is that it's undefined right after being used. Places that don't do that should be fixed. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Ongoing Debian package maintenance.
by Ben Klein 08 Sep '10

08 Sep '10

Sorry, Octavian, for sending this only to you. On 8 September 2010 06:00, Octavian Voicu <octavian.voicu(a)gmail.com> wrote: > On Tue, Sep 7, 2010 at 9:42 PM, Lei Zhang <thestig(a)google.com> wrote: >> >> It would be helpful if you provide the content of your debian/ >> directory. Mainly you want my control and rules files. I'll get these to you soon :) >> I wrote my own debian/control file and what not and built a >> wine-gecko-1.1.0 .deb over the weekend. I haven't finished working on >> the main Wine packages, but I'll take a look at your suggestions and >> reconsider how to structure the packages. As much as the final structure for the new packages is up to the official maintainer, I'm very interested in that decision and the reasoning behind it. Keep me posted! > It would be cool to also have wine1.3-64, wine1.3-gecko64 for amd64 builds, > besides the standard wine1.3, wine1.3-gecko :) 1) I do not like those package names at all. It should be the Debian-style names, wine-unstable/wine64-unstable. 2) Wine Gecko has its own versions. I had previously built a package called wine-gecko-1.0, IIRC. This naming convention should be continued, IMO, as different Gecko versions could be required at different points for wine (stable) and wine-unstable versions. Package names should be uniform and I suggest they should look like this: wine[64][-unstable][-<module>] where <module> is one of: * dbg * dev * gecko etc. > Octavian >

1 0

Re: [PATCH 2/9] CMD : Correct support for cmd.exe /C string [try 2]
by Alexandre Julliard 08 Sep '10

08 Sep '10

Jason Edmeades <jason.edmeades(a)googlemail.com> writes: > Note1: Tested manually on windows with procmon, windows does indeed do > the same as this patch, ie a double path/pathext search. You can't look at the internal behavior of the tool you are implementing, it needs to be treated as a black box. I'm afraid I can't accept that code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Importing strchrnul() from gnulib?
by Wolfram Sang 08 Sep '10

08 Sep '10

Hi, taking another approach at Bug 19070, I noticed that dlls/hhctrl.ocx/hhctrl.c has even more problems with commandline-handling. All three invocations of strchr() should better be strchrnul(). (Compare calling hh.exe with '-mapid' and '-mapid ' to see one difference). strchrnul ist protected by _GNU_SOURCE, though. Because I could imagine there are more places throughout the source needing a fix like this, I think about importing strchrnul() directly from gnulib into libs/wine/string.c (most appropriate place I could find). The function is LGPLv2+, of course. Objections? Regards, Wolfram

2 1

Re: [PATCH 2/2] d3dx9: Implement D3DXCreateMesh and initial ID3DXMesh methods.
by Henri Verbeet 08 Sep '10

08 Sep '10

You have leaks in your error paths. On 8 September 2010 02:33, Misha Koshelev <misha680(a)gmail.com> wrote: > + /* Create vertex buffer */ > + hr = IDirect3DDevice9_CreateVertexBuffer(device, > + numvertices * sizeof(D3DXVECTOR3) * 2, > + 0, /* Usage */ > + fvf, > + D3DPOOL_MANAGED, > + &vertex_buffer, > + NULL); Tests for that would be nice. E.g., I don't believe for a second the buffer length is really calculated that way, and does it really create an FVF vertex buffer?

1 0

Re: [3/3] msi/tests: Fix some test failures on 64-bit.
by testbot＠testbot.winehq.org 08 Sep '10

08 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5126 Your paranoid android. === W7PROX64 (64 bit package) === package.c:8361: Test failed: Expected "C:\Program Files\VMware\VMware Tools\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\", got "C:\Program Files (x86)\VMware\VMware Tools\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\"

1 0

Re: [PATCH 4/5] ddraw: Remove some stray tabs.
by testbot＠testbot.winehq.org 08 Sep '10

08 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5122 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

2 1

mshtml: Correct test for unknown dispID
by Alistair Leslie-Hughes 08 Sep '10

08 Sep '10

Changelog: mshtml: Correct test for unknown dispID Best Regards Alistair Leslie-Hughes

1 0