September 2010 - Wine-devel

Re: [PATCH 5/5] Add some more schannel tests
by testbot＠testbot.winehq.org 07 Sep '10

07 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5096 Your paranoid android. === W98SE (32 bit schannel) === Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit schannel) === Timeout === W2KPROSP4 (32 bit schannel) === Timeout

1 0

Re: [PATCH] Add some more schannel tests
by testbot＠testbot.winehq.org 07 Sep '10

07 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5095 Your paranoid android. === WNT4WSSP6 (32 bit schannel) === No test summary line found

1 0

Re: [PATCH] Add some more schannel tests
by testbot＠testbot.winehq.org 07 Sep '10

07 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5092 Your paranoid android. === WNT4WSSP6 (32 bit schannel) === No test summary line found

1 0

Re: kernel32/tests: typo fixes
by Nicolas Le Cam 07 Sep '10

07 Sep '10

2010/9/7 Austin English <austinenglish(a)gmail.com> > I initially noticed the wrong hemisphere label, but then the > capitalization was bugging me :-) > > -- > -Austin Hi Austin, @@ -449,18 +449,18 @@ static void test_TzSpecificLocalTimeToSystemTime(void) > tzW.DaylightBias=-60; > tzW.StandardDate.wMonth=10; > tzW.StandardDate.wDayOfWeek=0; /*sunday */ > > You missed that one! -- Nicolas Le Cam

1 0

Re: [PATCH] Fill a SECBUFFER_MISSING buffer if the message is not complete
by Hans Leidekker 07 Sep '10

07 Sep '10

Hi Mikko, > diff --git a/dlls/secur32/schannel.c b/dlls/secur32/schannel.c > index 78757ac..192f9cb 100644 > --- a/dlls/secur32/schannel.c > +++ b/dlls/secur32/schannel.c > @@ -1244,6 +1244,15 @@ static SECURITY_STATUS SEC_ENTRY schan_DecryptMessage(PCtxtHandle context_handle > if(buffer->cbBuffer < expected_size) > { > TRACE("Expected %u bytes, but buffer only contains %u bytes\n", expected_size, buffer->cbBuffer); > + buffer->BufferType = SECBUFFER_MISSING; > + buffer->cbBuffer = expected_size - buffer->cbBuffer; > + > + // This is a bit weird, but windows does it too > + idx = schan_find_sec_buffer_idx(message, 0, SECBUFFER_EMPTY); > + buffer = &message->pBuffers[idx]; > + buffer->BufferType = SECBUFFER_MISSING; > + buffer->cbBuffer = expected_size - buffer->cbBuffer; > + > TRACE("Returning SEC_E_INCOMPLETE_MESSAGE\n"); > return SEC_E_INCOMPLETE_MESSAGE; > } You should resend this with the patches it depends on and give the patches a sequence number.

2 1

Re: [PATCH] Add some more schannel tests
by Hans Leidekker 07 Sep '10

07 Sep '10

> @@ -116,6 +128,10 @@ static void InitFunctionPtrs(void) > if(!secdll) > secdll = LoadLibraryA("security.dll"); > advapi32dll = GetModuleHandleA("advapi32.dll"); > + wsockdll = LoadLibraryA("ws2_32.dll"); > + > + if(!wsockdll) > + printf("Couldn't open ws2_32.dll\n"); > Why are you loading ws2_32 dynamically? > + desc->pBuffers[0].cbBuffer = size; > + desc->pBuffers[0].pvBuffer = malloc(size); Use HeapAlloc/Free instead of malloc/free. > +static int receive_data(SOCKET sock, SecBuffer *buf) > +{ > + unsigned received = 0; > + > + while(1) > + { > + unsigned char *data = buf->pvBuffer; > + unsigned expected = 0; > + int ret; Please stick to 4 space indentation like the rest of the file. > + addr.sin_family = AF_INET; > + addr.sin_addr.s_addr = htonl(0xD1558712); > + addr.sin_port = htons(443); > + ret = pconnect(sock, (struct sockaddr *)&addr, sizeof(struct sockaddr_in)); > + if(ret==SOCKET_ERROR) > + { > + skip("Can't connect to mail.google.com\n"); > + return; > + } You should properly resolve mail.google.com.

2 1

Re: [PATCH] Fill a SECBUFFER_MISSING buffer if the message is not complete
by Juan Lang 07 Sep '10

07 Sep '10

Hi Mikko, + // This is a bit weird, but windows does it too You can't use C++-style comments in Wine. You do the same in your tests patch, too. --Juan

2 1

specfiles containing 'str' instead of 'wstr' for some W-functions
by Paul Vriens 07 Sep '10

07 Sep '10

Hi, I see some specfiles that contain 'str' instead of the correct 'wstr'. Is it worth sending a patch to fix these? If so, only one? -- Cheers, Paul.

1 0

Re: [PATCH] Fill a SECBUFFER_MISSING buffer if the message is not complete
by Austin English 07 Sep '10

07 Sep '10

On Tue, Sep 7, 2010 at 10:44 AM, Mikko Rasa <tdb(a)tdb.fi> wrote: > --- > dlls/secur32/schannel.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) Howdy Mikko, > diff --git a/dlls/secur32/schannel.c b/dlls/secur32/schannel.c > index 78757ac..192f9cb 100644 > --- a/dlls/secur32/schannel.c > +++ b/dlls/secur32/schannel.c > @@ -1244,6 +1244,15 @@ static SECURITY_STATUS SEC_ENTRY schan_DecryptMessage(PCtxtHandle context_handle > if(buffer->cbBuffer < expected_size) > { > TRACE("Expected %u bytes, but buffer only contains %u bytes\n", expected_size, buffer->cbBuffer); > + buffer->BufferType = SECBUFFER_MISSING; > + buffer->cbBuffer = expected_size - buffer->cbBuffer; > + > + // This is a bit weird, but windows does it too I can't comment on the rest of the patch, but please use C89 /* comments */, not C99 (//). -- -Austin

1 0

Re: ntdll: Don't cancel loading on IMAGE_FILE_RELOCS_STRIPPED
by Greg Geldorp 07 Sep '10

07 Sep '10

> From: Paul Chitescu <paulc(a)voip.null.ro> > > In a typical Win32 environment the executables don't have relocations since > they load at a fixed address. Old (Visual C 4.x and older) executables had > relocations so they could run on Win32s. Not all that relevant to the patch, but... Newer executables do tend to have relocations. This allows ASLR (Address Space Layout Randomization) on Vista and higher to work. Ge.

1 0