November 2011 - Wine-devel - list.winehq.org

Re: dinput: Delete the static critical section when unloading the dll.
by Vitaliy Margolen 17 Nov '11

17 Nov '11

On 11/16/2011 08:31 AM, Francois Gouget wrote: > --- > > I moved DllMain() to the end of the file so it comes after the variable > declaration. It's already forward declared few lines after DllMain(). So you should move that declaration instead. Hm... it seems this patch already committed. Alexadre, would you please give people at least 24 hours to review all patches sent to wine-patches before committing them? Vitaliy.

3 3

re: added remaining functions, data structures, definitions required by http api to include/http.h
by Dan Kegel 16 Nov '11

16 Nov '11

That's a lot of stuff. What needs it? Also, please avoid trivial whitespace changes.

2 1

Re: added remaining functions, data structures, definitions required by http api to include/http.h
by Frédéric Delanoy 16 Nov '11

16 Nov '11

On Wed, Nov 16, 2011 at 14:15, ArasH <arash.cordi(a)gmail.com> wrote: > --- > include/http.h | 1266 +++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 1251 insertions(+), 15 deletions(-) The patch should show your full name. See http://wiki.winehq.org/SubmittingPatches for more information.

1 0

Re: mshtml: Fixed some htmldoc.c tests on IE9
by Marvin 16 Nov '11

16 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15467 Your paranoid android. === TEST64_W7SP1 (32 bit htmldoc) === htmldoc.c:2890: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2709: Test failed: unexpected call Exec_ShellDocView_37 htmldoc.c:2709: Test failed: unexpected call Exec_ShellDocView_37 === TEST64_W7SP1 (64 bit htmldoc) === htmldoc.c:2890: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2709: Test failed: unexpected call Exec_ShellDocView_37

2 1

Re: [PATCH 1/1] user32: Prioritize focus for dialog owner on EndDialog (resend).
by Marvin 15 Nov '11

15 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15456 Your paranoid android. === TEST64_W7SP1 (64 bit msg) === Timeout

1 0

Re: [PATCH 2/5] d3d10: Implement D3D10StateBlockMaskDisableCapture().
by Matteo Bruni 15 Nov '11

15 Nov '11

2011/11/15 Henri Verbeet <hverbeet(a)codeweavers.com>: > --- > + UINT end = start_idx + count; > + start_idx += 7; > + memset(&field[start_idx >> 3], 0, (end >> 3) - (start_idx >> 3)); Isn't that dangerous if count is < 7 (assuming that is a valid value)?

1 0

Re: [2/4] ddraw: Add more tests and fixes for SetSurfaceDesc
by Henri Verbeet 15 Nov '11

15 Nov '11

On 15 November 2011 00:12, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + /* Tests show that only LPSURFACE and PIXELFORMAT can be set, and LPSURFACE is required > + * for PIXELFORMAT to work */ This may be ok, but note that the test doesn't actually test this. (E.g. does calling SetSurfaceDesc() with the original surface desc work? What about bits not in DDSD_ALL? Etc.) Also, as a general principle, I'd be happier about the ddraw tests if they actually tested all the different interface versions.

2 4

RFH: Solaris users with IPv6
by Juan Lang 15 Nov '11

15 Nov '11

Hi all, in the tidy up I've been doing to iphlpapi, I notice that on Solaris it's possible to enumerate IPv6 addresses using SIOCGIFCONF. I've got a patch written that does that, but I have no way to test it myself. If anyone here has some version of Solaris with a machine with IPv6 addresses, even autoconfigured ones, and feels like testing a patch, please let me know. I'll send the patch and a small test program. Thanks, --Juan

2 1

Re: (resend)[5/6]usp10: Devanagari danda and double danda are use for all Indic scripts
by Henri Verbeet 15 Nov '11

15 Nov '11

That's a fair amount of magic constants in there. The ones in is_indic() are probably Script_Devanagari and Script_Malayalam_Numeric, I didn't look at the other two.

2 1

Re: [4/6] msxml3/dom: Properly return node prefix from get_prefix()
by Jacek Caban 15 Nov '11

15 Nov '11

Hi Nikolay, On 11/15/11 07:19, Nikolay Sivov wrote: > - if ((ns = xmlGetNsList(This->node->doc, This->node))) > + switch (This->node->type) > { > - if (ns[0]->prefix) *prefix = bstr_from_xmlChar( ns[0]->prefix ); > - xmlFree(ns); > + case XML_ELEMENT_NODE: > + case XML_ATTRIBUTE_NODE: > + { > + xmlNsPtr ns = This->node->ns; > + if (ns&& ns->prefix) > + *prefix = bstr_from_xmlChar(ns->prefix); > + break; > } > + default: > + FIXME("unsupported type %d\n", This->node->type); > + }; The idea behind node inheritance rewrite was to avoid such switches. If other node types should be handled differently, they simply shouldn't use node_get_prefix or the differences should be moved to child objects. Jacek

2 1