November 2011 - Wine-devel - list.winehq.org

Re: [PATCH 2/5] d3d10: Add a stub ID3D10StateBlock implementation.
by Nikolay Sivov 15 Nov '11

15 Nov '11

On 11/14/2011 23:11, Henri Verbeet wrote: > +static ULONG STDMETHODCALLTYPE d3d10_stateblock_Release(ID3D10StateBlock *iface) > +{ > + struct d3d10_stateblock *stateblock = impl_from_ID3D10StateBlock(iface); > + ULONG refcount = InterlockedIncrement(&stateblock->refcount); > + > + TRACE("%p decreasing refcount to %u.\n", stateblock, refcount); > + > + if (!refcount) > + HeapFree(GetProcessHeap(), 0, stateblock); > + > + return refcount; > +} Decrement maybe?

1 0

Vista/w2k8/w7 users, please test mmdevapi with exclusive mode disabled
by Joerg-Cyril.Hoehle＠t-systems.com 14 Nov '11

14 Nov '11

Hi, Please test mmdevapi again using testbot job #15369 with exclusive mode disabled. Brian, it seems like you had some other app use audio while performing the tests. This would explain the DEVICE_IN_USE error: render.c:427: Test failed: Initialize(exclus., 8000x 8x1) returns 8889000a and the subsequent crash. My new version of the tests should prevent crashes in such a situation. Saulius, you need not perform many tests because of random GetPosition/Padding failures. I've not yet changed that part of the tests. Thank you for repeated testing, Jörg Höhle

2 1

Re: winemaker: Be less picky when detecting the target type
by Francois Gouget 14 Nov '11

14 Nov '11

On Fri, 11 Nov 2011, André Hentschel wrote: > seen some "broken" project files which still worked with msvc but not with winemaker > --- > tools/winemaker | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/winemaker b/tools/winemaker > index 2ee79ea..921f8ef 100755 > --- a/tools/winemaker > +++ b/tools/winemaker > @@ -589,16 +589,16 @@ sub source_scan_project_file($$$) > #print $prj_name; > next; > } elsif (/^# TARGTYPE/) { > - if (/[[:space:]]0x0101$/) { > + if (/0x.*101$/) { The various .* worry me a bit. Would something like [0-9a-fA-F]* be permissive enough? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Broadcast message : fin du monde dans cinq minutes, repentez vous !

2 1

Re: [1/5]usp10: break with a better understanding on the handling of bidi strengths
by Alexandre Julliard 14 Nov '11

14 Nov '11

Aric Stewart <aric(a)codeweavers.com> writes: > + if (strength) > + { > + str = strength[cnt]; > + if (pwcInChars[cnt] == Numeric_space) > + str_space = TRUE; > + else > + str_space = FALSE; > + } str_space is not used for anything. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: taskmgr: Give a name and statically initialize PerfDataCriticalSection.
by Francois Gouget 14 Nov '11

14 Nov '11

On Mon, 14 Nov 2011, Francois Gouget wrote: [...] > static CRITICAL_SECTION PerfDataCriticalSection; > +static CRITICAL_SECTION_DEBUG PerfDataCriticalSection_debug = > +{ > + 0, 0, &PerfDataCriticalSection, > + { &PerfDataCriticalSection_debug.ProcessLocksList, &PerfDataCriticalSection_debug.ProcessLocksList }, > + 0, 0, { (DWORD_PTR)(__FILE__ ": PerfDataCriticalSection") } > +}; [...] > + PerfDataCriticalSection.DebugInfo->Spare[0] = 0; > DeleteCriticalSection(&PerfDataCriticalSection); Actually I think unsetting Spare[0] is wrong for statically initialized critical sections because it causes RtlDeleteCriticalSection() to do an RtlFreeHeap() on DebugInfo which happens to also be statically allocated. So I'll rework this patch and some of my previous patches. -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Re: dlls: Remove unneeded include directives in resource files.
by Marvin 14 Nov '11

14 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15373 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

re: [PATCH] ntdll: Use VALGRIND_RESIZEINPLACE_BLOCK when available
by Dan Kegel 12 Nov '11

12 Nov '11

You might want to compare with Bart's patch for the same thing, http://www.winehq.org/pipermail/wine-patches/2011-April/100570.html Bart asked for comments on it, but didn't get much feedback: http://www.winehq.org/pipermail/wine-devel/2011-May/090029.html My guess is changes like this are really hard to get in unless you can get Alexandre's full attention somehow. Maybe if it was demonstrated to find interesting bugs in wine...

1 0

Re: Include math.h in d3dx9math.inl as it uses sqrt().
by Henri Verbeet 12 Nov '11

12 Nov '11

Does the Microsoft header include math.h?

4 4

Re: d3dx9 [patch 1/2, try 4]: Implement D3DXCreatePolygon
by Rico Schüller 11 Nov '11

11 Nov '11

Am 10.11.2011 10:59, schrieb David Adam: > Hello, > > I tried to fix the remaining issues pointed by Matteo and Rico. > I kept the style of Misha Koshelev who already implemented many shapes in > the mesh.c file. > > Any more suggestions? > > David > > > Hi David, I still have some suggestions. Please review all TRACE and ok messages. I think they should mostly end with '\n' and they should not contain "useless" chars like ':' and spaces where not needed. Also you may save the ref value from the call before you compare it: + IDirect3DDevice9_Release(device); + ok(ref == 0, "Expected refcount = 0, received %d", ref); I think it is pretty useful to check the reference count in general for all release calls. Please review that part, so that it does what it should do! It's not only the line I mentioned as an example here! If you don't understand some parts and don't know exactly what to do, please ask. I'd prefer if the comparison would be within the if, otherwise you could compare to an uninitialized value, which could get bogus results (even if that only happens when other test fail, I think it's better than comparing uninitialized values): + if (polygon) ref = polygon->lpVtbl->Release(polygon); + ok(ref == 0, "Expected refcount = 0, received %d", ref); Please see my points as a suggestion. I think the answers to the patches showed a lot of issues, so please review the whole patch before sending it again, you may find some other not mentioned things. Note: Not the fastest sent patch will get in, but the "best" working solution. Cheers Rico

1 0

Re: Add dxerr.h
by Henri Verbeet 10 Nov '11

10 Nov '11

On 10 November 2011 02:27, Daniel Scharrer <dscharrer(a)gmail.com> wrote: > +#include <dxerr9.h> > + > +#define DXGetErrorStringA DXGetErrorString9A > +#define DXGetErrorStringW DXGetErrorString9W > +#define DXGetErrorString WINELIB_NAME_AW(DXGetErrorString) > + > +#define DXGetErrorDescriptionA DXGetErrorDescription9A > +#define DXGetErrorDescriptionW DXGetErrorDescription9W > +#define DXGetErrorDescription WINELIB_NAME_AW(DXGetErrorDescription) Which SDK version does this match?

2 1