February 2011 - Wine-devel - list.winehq.org

Re: winmm: Simplify MCI_DumpCommandTable a bit. (RETRY)
by Alexandre Julliard 18 Feb '11

18 Feb '11

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > Ping. Any objection to this, given that this has not been used for > quite a while? The variable is here for documentation, you don't want to remove it. You can comment it out if it's not used. -- Alexandre Julliard julliard(a)winehq.org

2 1

Somewhat barebones patch to implement D3DXCreateRenderToSurface for bug 24899, how much more needs to be implemented?
by Misha Koshelev 18 Feb '11

18 Feb '11

Dear All: Looking at d3dx9 bugs, bug 24899 requires D3DXCreateRenderToSurface. This, somewhat barebones, patch, implements core functionality of D3DXCreateRenderToSurface, along with a barebones ID3DXRenderToSurface implementation. I was wondering, in order to get this patch accepted into the wine code base, how much more of ID3DXRenderToSurface needs to be implemented? Thank you Misha

3 3

project help...
by ejaj on resurgence 17 Feb '11

17 Feb '11

m a new comer here...its great.....well i just wanna know if wine is gonna be project in GSOC-11....wud be glad if soo...i wanna get into it....so sum 1 plz help me out here...lotsa thnx...

1 0

A patch trying to fix Bug 25999 - wine builtin IE crash while opening file with zero bytes
by Qian Hong 17 Feb '11

17 Feb '11

Dear All, I'm trying to fix http://bugs.winehq.org/show_bug.cgi?id=25999 Below is my patch. This my first patch, I wonder weather it is ugly, I'm grateful for any advice. >From 0598dc0acf14a18d28e78e7b924384c46040a81e Mon Sep 17 00:00:00 2001 From: Qian Hong <fracting(a)gmail.com> Date: Fri, 18 Feb 2011 04:46:41 +0800 Subject: modified: dlls/mshtml/navigate.c --- dlls/mshtml/navigate.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c index bb71c79..f978e8e 100644 --- a/dlls/mshtml/navigate.c +++ b/dlls/mshtml/navigate.c @@ -1106,7 +1106,8 @@ static HRESULT async_stop_request(nsChannelBSC *This) IBindStatusCallback_AddRef(&This->bsc.IBindStatusCallback_iface); task->bsc = This; - push_task(&task->header, stop_request_proc, This->bsc.doc->basedoc.doc_obj->basedoc.task_magic); + if(This->bsc.doc) + push_task(&task->header, stop_request_proc, This->bsc.doc->basedoc.doc_obj->basedoc.task_magic); return S_OK; } -- Thanks very much! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

1 0

Re: user32: Use the windows created by the SetParent() test to get a more predictable active/focus window state.
by Alexandre Julliard 17 Feb '11

17 Feb '11

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > Hopefully this should fix recently introduced test failures seen on some > test machines. It doesn't work here: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so win.c && touch win.ok win.c:3479: Test failed: GetActiveWindow() = 0x5500c2 win.c:3479: Test failed: GetFocus() = 0x5500c2 make[1]: *** [win.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

winmm/tests: remove dead assignment (LLVM/Clang)
by Joerg-Cyril.Hoehle＠t-systems.com 17 Feb '11

17 Feb '11

Hi, Austin suggests: >--- a/dlls/winmm/tests/wave.c >- first = FALSE; -1 Some times you value consistency more than elimination of superfluous assignments. All parts are written like this: if ((flags & WAVE_FORMAT_DIRECT) == WAVE_FORMAT_DIRECT) { if (!first) strcat(msg, "|"); strcat(msg, "WAVE_FORMAT_DIRECT"); first = FALSE; } and you don't want to eliminate that one line in the last part just because it happens to be the last one TODAY. What if tomorrow another flag is added last and the programmer oversees that s/he needs to reintroduce that first=FALSE statement? Removing regularity is just error-prone and in the way of maintainability. Try to keep the code regular and all parts alike, without exception for the last one. It reminds me of the annoying issue with the trailing comma in structure initialisations, which lead some people to instead use a style like this (well known in functional programming): ... , value_n , value_n+1 }; Isn't there a way to silence several complains from Clang which I consider stupid? Regards, Jörg

1 0

Re: mshtml: Implement IHTMLAnchorElement_put_href
by Jacek Caban 17 Feb '11

17 Feb '11

Hi Alistair, On 2/17/11 10:45 AM, Alistair Leslie-Hughes wrote: > + IHTMLAnchorElement *anchor = _get_anchor_iface(line, unk); > + BSTR str; > + HRESULT hres; > + > + str = a2bstr(exhref); > + hres = IHTMLAnchorElement_put_href(anchor, str); > + ok_(__FILE__,line)(hres == S_OK, "get_href failed: %08x\n", hres); > + > + _test_disp_value(line, unk, exhref); You leak str here. Jacek

1 0

Re: ntdll/signal_arm.c: Implement segv_handler
by Dmitry Timoshkov 17 Feb '11

17 Feb '11

chris.nousco(a)gmail.com wrote: > From: JinSung Kang <chris.nousco(a)gmail.com> > > Improve that segv_handler function check page_fault and setting up exception handler. > It is possbible whether read fault or write fault. It looks like the formatting of your patches is messed up because of using a non-standard tab size (4?). -- Dmitry.

1 0

Re: comctl32/tests: make sure to use return values (LLVM/Clang) (try 2)
by Dmitry Timoshkov 17 Feb '11

17 Feb '11

Austin English <austinenglish(a)gmail.com> wrote: > + r = SendMessage(hwnd, LVM_SETICONSPACING, 0, MAKELONG(100,50)); > + ok(r, "failed\n"); Please use a more informative failure message. > r = SendMessage(hwnd, WM_NOTIFYFORMAT, 0, NF_QUERY); > + todo_wine expect(2, r); 2 is NFR_UNICODE. -- Dmitry.

1 0

Re: comctl32/tests: make sure to use return values (LLVM/Clang) (1/6)
by Marvin 17 Feb '11

17 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9336 Your paranoid android. === WNT4WSSP6 (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 14) listview.c:3764: Test failed: Expected 1, got 2 === W2KPROSP4 (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 14) listview.c:3764: Test failed: Expected 1, got 2 === WXPPROSP3 (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 14) listview.c:3764: Test failed: Expected 1, got 2 === W2K3R2SESP2 (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 14) listview.c:3764: Test failed: Expected 1, got 2 === WVISTAADM (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 16) listview.c:3764: Test failed: Expected 1, got 2 === W2K8SE (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 14) listview.c:3764: Test failed: Expected 1, got 2 === W7PRO (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 16) listview.c:3764: Test failed: Expected 1, got 2 === W7PROX64 (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 16) listview.c:3764: Test failed: Expected 1, got 2 === W7PROX64 (64 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 16) listview.c:3764: Test failed: Expected 1, got 2

2 1