February 2011 - Wine-devel - list.winehq.org

Re: Re: [PATCH] Implement software DXT1 compression
by alberto＠mattea.info 15 Feb '11

15 Feb '11

Hi Stefan. I'm not really into opengl internals, so I think the best solution for now is to implement 1), and give complete support when the blitting code will be in a better shape. Would this be okay? if (!context->valid) { context_release(context); FIXME("No gl context, cannot perform conversion\n"); return; } Thanks

1 0

Re: Re: [PATCH] Implement software DXT1 compression
by alberto＠mattea.info 15 Feb '11

15 Feb '11

> An idea that was proposed before was to delegate the conversion (and the > patents burden) to the OpenGL drivers, something like using > glCompressedTexImage2D() / glGetCompressedTexImage(). Not sure > whether there are hidden issues with that approach (except, well, requiring > an OpenGL driver with compressed textures support), but at a first glance > it doesn't look as something particularly hard to do. Good idea. This new patch implements this approach. It seems to be working perfectly at least with the nvidia blob. It is also much smaller than the previous one, and doesn't require hacks like inverting colors and so on.

2 1

Re: [website] Turn on gzip compression
by Jeremy Newman 15 Feb '11

15 Feb '11

Actually, a better way to accomplish this is to add: php_flag zlib.output_compression On to the .htaccess file. I'm a little surprised it was not there already. -N On 02/15/2011 01:02 PM, André Hentschel wrote: > First make sure that works with your server... > --- > site | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/site b/site > index 5a7bd46..a776199 100644 > --- a/site > +++ b/site > @@ -5,6 +5,8 @@ > by Jeremy Newman<jnewman(a)codeweavers.com> > */ > > +ob_start("ob_gzhandler"); > + > // load modules and defines > $file_root = realpath(dirname(__FILE__)); > require("{$file_root}/include/incl.php"); > @@ -114,4 +116,5 @@ $html->page = $html->template("local", PAGE); > $html->showpage(); > > // done > +ob_end_flush(); > ?>

1 0

Re: [PATCH 3/4] urlmon: Properly handle BINDSTATUS_BEGINDOWNLOADDATA.
by Marvin 15 Feb '11

15 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9273 Your paranoid android. === W7PROX64 (64 bit protocol) === protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045

3 2

Re: [1/2] winex11.drv: Add PS_USERSTYLE support to pens (take 2)
by Alexandre Julliard 15 Feb '11

15 Feb '11

Daniel <danielfsantos(a)att.net> writes: > @@ -54,11 +56,13 @@ HPEN CDECL X11DRV_SelectPen( X11DRV_PDEVICE *physDev, HPEN hpen ) > elp = HeapAlloc( GetProcessHeap(), 0, size ); > > GetObjectW( hpen, size, elp ); > - /* FIXME: add support for user style pens */ > + > logpen.lopnStyle = elp->elpPenStyle; > logpen.lopnWidth.x = elp->elpWidth; > logpen.lopnWidth.y = 0; > logpen.lopnColor = elp->elpColor; > + user_style_size = elp->elpNumEntries; > + user_style = elp->elpStyleEntry; This can't work, the data will be freed before you use it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/4] urlmon: Read remaining protocol data if report_data was called after binding finished.
by Marvin 15 Feb '11

15 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9272 Your paranoid android. === WVISTAADM (32 bit url) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] Fixed several links in the documentation...
by Alexandre Julliard 15 Feb '11

15 Feb '11

max(a)mtew.isa-geek.net writes: > @@ -204,7 +204,7 @@ int CDECL MSVCRT__chdir(const char * newdir) > /********************************************************************* > * _wchdir (MSVCRT.@) > * > - * Unicode version of _chdir. > + * Unicode version of MSVCRT__chdir. You don't want to use the internal name here, it's not useful for users. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: Fixed GetDIBits for top-down bitmaps (try 2).
by Alexandre Julliard 15 Feb '11

15 Feb '11

Jack Edmonds <pocketcookies2(a)gmail.com> writes: > gdi32/dib.c: Reversed source bitmap pointer instead of destination bitmap pointer. > Removed check for destination bitmap height when determining whether to copy the source bitmap upside down. > gdi32/tests/bitmap.c: Added a test for copying between top-down bitmaps. The rest of the code won't cope so well with a negative source width. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/5] msxml3/xsl: Basic put_input() method for IXSLProcessor
by Jacek Caban 15 Feb '11

15 Feb '11

Hi Nikolay, On 2/14/11 9:04 PM, Nikolay Sivov wrote: > Basic put_input() method for IXSLProcessor > + IXMLDOMNode *old_input = This->input; + HRESULT hr; - FIXME("(%p): stub\n", This); - return E_NOTIMPL; + TRACE("(%p)->(type=%d)\n", This, V_VT(&input)); + + /* try IXMLDOMNode directly first */ + if (V_VT(&input) == VT_UNKNOWN) + hr = IUnknown_QueryInterface(V_UNKNOWN(&input),&IID_IXMLDOMNode, (void**)&This->input); + else if (V_VT(&input) == VT_DISPATCH) + hr = IDispatch_QueryInterface(V_DISPATCH(&input),&IID_IXMLDOMNode, (void**)&This->input); + + if (hr != S_OK) + { + IXMLDOMDocument *doc; + + hr = DOMDocument_create(&CLSID_DOMDocument, NULL, (void**)&doc); + if (hr == S_OK) + { + hr = IXMLDOMDocument_QueryInterface(doc,&IID_IXMLDOMNode, (void**)&This->input); + IXMLDOMDocument_Release(doc); + } + } + + if (hr == S_OK&& old_input) IXMLDOMNode_Release(old_input); Failure of QueryInterface call will set This->input to NULL (you probably want it not changed and even if not, that's a leak). It's probably better idea to have local pointer to the new input instead of old one and change it once you know the function will succeed. Jacek

2 2

Re: [4/5] msxml3/xsl: Store output stream for processor
by Jacek Caban 15 Feb '11

15 Feb '11

Hi Nikolay, On 2/14/11 9:04 PM, Nikolay Sivov wrote: > + case VT_UNKNOWN: > + hr = IUnknown_QueryInterface(V_UNKNOWN(&output),&IID_IStream, (void**)&This->output); > + break; You leak This->output here. Jacek

1 0