February 2011 - Wine-devel - list.winehq.org

Re: [1/2] winex11.drv: Add PS_USERSTYLE support to pens (take 2)
by Daniel 15 Feb '11

15 Feb '11

grr, please disregard previous patches. I've discovered a problem that can lead to use of un-initialized values. Daniel On 02/15/2011 01:09 AM, Daniel wrote: > Clean up per Vitaliy's direction. Also found a FIXME comment that needed > to be removed. > > Daniel > > >

1 1

Re: gdi32: correct substitutions (take 2)
by Dmitry Timoshkov 15 Feb '11

15 Feb '11

Rafał Mużyło <galtgendo(a)gmail.com> wrote: > Corrected version of the previous patch. > This time I'm not adding a new helper function, just putting it in one > place. > Corrections: > - as oppossed to get_font_subst, reverse check can have more than one > result, so changed to adjust all of them > - just in case a->a substitution would result, explicitly prevent that > (perhaps gdi32 handles it gracefully, but it's still redundant) Did you test that Windows handles font substitutions this way? -- Dmitry.

1 0

Re: Re: [PATCH] Implement software DXT1 compression
by alberto＠mattea.info 14 Feb '11

14 Feb '11

Hi Stefan, thanks for your answer. I've checked the nvidia texture tools but, sadly, I think it's impossible to use them in wine: while they have c bindings, those bindings lack the essential function nvttSetOutputOptionsOutputHandler(NvttOutputOptions * outputOptions, nvttOutputHandler outputHandler, nvttImageHandler imageHandler) (commented out in the headers), so the output can only be written to a file. What about going the mesa way, where the drivers aren't linked with any s3tc library, but load it at runtime if it is present? Any idea is welcome.

2 1

Re: wine is passing make test again :-)
by Greg Geldorp 14 Feb '11

14 Feb '11

> From: Andre Hentschel > and now without the 9x stuff the result page looks better again, someone > just need to fix his user32 test :) Frankly, I'm a bit surprised and disappointed to see that people are not taking responsibility for fixing failures they introduced in tests. I don't expect to have time to clean up after them for the next month or so. Greg.

3 2

kernel32/process: Add stderr redirection for native linux programs started from windows program
by Igor Egorov 14 Feb '11

14 Feb '11

A week ago I submitted a patch for stderr redirection (http://www.winehq.org/pipermail/wine-patches/2011-February/098578.html) is there still something wrong with it? Will it be accepted?

2 1

Re: Austin English : shell32/tests: Don't check return values inside of if(0) ( LLVM/Clang).
by Charles Davis 14 Feb '11

14 Feb '11

Austin, Static analyzer checks for unreachable assignments (like the ones that were removed in this patch) were turned off in Clang trunk recently (as of r125415). Looks like Clang was wrong ;). Chip

2 1

Re: winex11.drv: Add PS_USERSTYLE support to pens
by Vitaliy Margolen 14 Feb '11

14 Feb '11

On 02/14/2011 03:55 AM, Daniel wrote: > Hello all. This only covers the screen. Support still needs to be added > to printers. > + case PS_USERSTYLE: { > + for(i = 0; i < physDev->pen.dash_len ; i++) { Please follow file style - curly braces on separate line. No braces for single line blocks. > + /* Should be limited to 16 or less */ > + char x11_user_style[16]; > + physDev->pen.dash_len = user_style_size > 16 ? 16 : user_style_size; Should use MAX_DASHLEN instead of magic numbers. Could use "min()" for simplicity. > + x11_user_style[i] = (char)(user_style[i] > 255 ? 255 : user_style[i]); Why not copy directly into physDev->pen.dashes? No need for typecast - it's done automatically. Vitaliy.

1 0

Re: kernel32: Implement and test GetVolumePathNamesForVolumeName.
by Alexandre Julliard 14 Feb '11

14 Feb '11

Hans Leidekker <hans(a)codeweavers.com> writes: > BOOL WINAPI GetVolumePathNamesForVolumeNameW(LPCWSTR volumename, LPWSTR volumepathname, DWORD buflen, PDWORD returnlen) > { > - FIXME("(%s, %p, %d, %p), stub!\n", debugstr_w(volumename), volumepathname, buflen, returnlen); > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return FALSE; > + static const WCHAR prefixW[] = > + {'\\','\\','?','\\','V','o','l','u','m','e','{','0','0','0','0','0','0','0','0','-','0','0','0','0','-', > + '0','0','0','0','-','0','0','0','0','-','0','0','0','0','0','0','0','0','0','0'}; > + static const WCHAR fmtW[] = {'%','c',':','\\',0}; > + > + TRACE("%s, %p, %u, %p\n", debugstr_w(volumename), volumepathname, buflen, returnlen); > + > + if (!volumename || strlenW( volumename ) != 49 || > + volumename[47] != '}' || memcmp( volumename, prefixW, sizeof(prefixW) )) > + { > + SetLastError( ERROR_INVALID_NAME ); > + return FALSE; > + } > + if (returnlen) > + { > + *returnlen = 5; > + } > + if (buflen < 5 || !volumepathname) > + { > + SetLastError( ERROR_MORE_DATA ); > + return FALSE; > + } > + sprintfW( volumepathname, fmtW, strtolW( volumename + 45, NULL, 16 ) ); > + volumepathname[4] = 0; > + return TRUE; Please don't make assumption about volume guids. This should be implemented by retrieving the correct data from mountmgr. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/4] mshtml: Add IDispatchEx support to IXMLHTTPRequest
by Marvin 14 Feb '11

14 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9250 Your paranoid android. === W2KPROSP4 (32 bit domdoc) === domdoc.c:3449: Test failed: ret 80004002 === WXPPROSP3 (32 bit domdoc) === domdoc.c:3449: Test failed: ret 80004002 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:3449: Test failed: ret 80004002 === WVISTAADM (32 bit domdoc) === domdoc.c:3449: Test failed: ret 80004002 === W2K8SE (32 bit domdoc) === domdoc.c:3449: Test failed: ret 80004002 === W7PRO (32 bit domdoc) === domdoc.c:3449: Test failed: ret 80004002 === W7PROX64 (32 bit domdoc) === domdoc.c:3449: Test failed: ret 80004002 === W7PROX64 (64 bit domdoc) === domdoc.c:3449: Test failed: ret 80004002

1 0

wine is passing make test again :-)
by Austin English 13 Feb '11

13 Feb '11

Looks like Jacek and Gentoo have the magic combination. It's passed 4 days in a row: http://test.winehq.org/data/ae3e768a2e1f9c21b355798c8fbf473db3d83434/wine_j… http://test.winehq.org/data/bf640445c748b0588616da201e8ff8f3b1c778e9/wine_j… http://test.winehq.org/data/780f9b3b4fe8ff17784860a2a65b4ecab268436a/wine_j… http://test.winehq.org/data/745a50c9dbb03d37db58ff53136e93f00943bc0d/wine_j… now let's see if we can spread the love to someone else :-). -- -Austin

2 2