February 2011 - Wine-devel - list.winehq.org

test_TCS_OWNERDRAWFIXED in dlls/comctl32/tests/tab ?
by Gerald Pfeifer 12 Feb '11

12 Feb '11

test_TCS_OWNERDRAWFIXED in dlls/comctl32/tests/tab has the following code: LPARAM lparam, lparam2; : lparam = 0; memset(&lparam, 0xde, 4); memset(&lparam2, 0xde, sizeof(LPARAM)-1); ok(g_drawitem.itemData == lparam || broken(g_drawitem.itemData == lparam2) /* win98 */, "got 0x%lx, expected 0x%lx\n", g_drawitem.itemData, lparam); I have two questions on this. First, why does the memset use the constant 4 and not sizeof(LPARAM)? Second, why initialize lparam with 0 when this is immediately followed by a memset covering it's fully size? Third, lparam2 is partially uninitialized and will have a couple of random bits from all I can tell since lparam2 is never initialized and the memset only covers a portion of it. I'm wondering, should lparam = 0 just read lparam2 = 0? Whatever may be the case, the current code does not look right. Gerald

1 0

.chm files for builtin programs?
by Dan Kegel 12 Feb '11

12 Feb '11

Hi all, The native dxdiag uses a .chm file for its help system, so ours might as well, too. I see there's a .chm file checked in to git (in dlls/itss/tests). Any objection to checking a .chm file into programs/dxdiag, along with its source files and script to build it? I think there's an open source .chm compiler at http://sourceforge.net/projects/chmc/ Haven't tried it yet. If that doesn't work, we can use Microsoft's hhc. - Dan

3 2

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.
by Marvin 12 Feb '11

12 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8981 Your paranoid android. === WXPPROSP3 (32 bit math) === math.c:2238: Test failed: Got 7fff, expected 7c00 for index 7. === WVISTAADM (32 bit math) === math.c:2238: Test failed: Got 7fff, expected 7c00 for index 7. === W7PRO (32 bit math) === math.c:2238: Test failed: Got 7fff, expected 7c00 for index 7.

6 25

Please reject patch 71094 it is wrong.
by Alexander Kochetkov 12 Feb '11

12 Feb '11

71094 New Alexander Kochetkov [resend] gdi32: Text output of records EMR_EXTTEXTOUTA/W depend on field iGraphicsMode

1 0

Re: [PATCH 2/2] msvcrt: Implement _strnicoll.
by Dmitry Timoshkov 12 Feb '11

12 Feb '11

Eryk Wieliczko <ewdevel(a)gmail.com> wrote: > /********************************************************************* > + * _strnicoll (MSVCRT.@) > + */ > +int CDECL MSVCRT__strnicoll(const char* str1, const char* str2, int digits) > +{ > + int res; > + > + res = strncmp(str1, str2, digits); > + if (res > 0) > + res = 1; > + else if (res < 0) > + res = -1; > + > + return res; > +} The API name implies case insensitive comparison, please add the tests for that. -- Dmitry.

2 1

d3dx9_36 [resend]: Add a few tests for D3DXCreateBox
by David Adam 12 Feb '11

12 Feb '11

Hello, no feedback available for this patch? It was rejected silently. A+ David ---------- Forwarded message ---------- From: David Adam <david.adam.cnrs(a)gmail.com> Date: 2011/2/9 Subject: d3dx9_36 [resend]: Add a few tests for D3DXCreateBox To: wine-patches <wine-patches(a)winehq.org> Fixed following Stefan's advices. A+ David

1 0

[rfc] dsound: decrease sound latency
by Maarten Lankhorst 11 Feb '11

11 Feb '11

Hi all, Please test this and let me know if it's causing any problems in sound playback, preferably with media applications and games, any feedback would be appreciated. The patch won't fix existing problems, it should just decrease the audio lag. As such I would prefer only to receive feedback on issues INTRODUCED or FIXED by this patch. If it's causing issues, I want to know: 1. Whether pulseaudio is running, and pulseaudio --version 2. What distribution you're using 3. (If you know it) the version of alsa's libraries, packages libasound2 and libasound2-plugins in debian/ubuntu Cheers, Maarten

2 1

Re: iphlpapi: Hint what to do when icmp does not work
by Charles Davis 11 Feb '11

11 Feb '11

On 2/11/11 11:12 AM, André Hentschel wrote: > Otherwise the user might try running wine as root or doesn't know that this error can be easily fixed when needed. > --- > dlls/iphlpapi/icmp.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/dlls/iphlpapi/icmp.c b/dlls/iphlpapi/icmp.c > index d8ee101..41d1940 100644 > --- a/dlls/iphlpapi/icmp.c > +++ b/dlls/iphlpapi/icmp.c > @@ -155,6 +155,7 @@ HANDLE WINAPI IcmpCreateFile(VOID) > int sid=socket(AF_INET,SOCK_RAW,IPPROTO_ICMP); > if (sid < 0) { > ERR_(winediag)("Failed to use ICMP (network ping), this requires special permissions.\n"); > + ERR_(winediag)("Try running \"sudo setcap cap_net_raw+epi /usr/bin/wine-preloader\".\n"); That only works on systems that support POSIX capabilities (Linux, and maybe OpenBSD). Chip

2 2

[PATCH 01/13] dsound: New sample rate converter core functions.
by Joerg-Cyril.Hoehle＠t-systems.com 11 Feb '11

11 Feb '11

Hi, The question how to split is interesting. I haven't found the answer about how to split my future MIDI player rewrite either. Like yours, it will replace old functions with something new. Some guidelines are: - Each patch should be self contained and a logical unit, e.g. + a bug fix, possibly with test e.g. ZeroMemory => FillMemory wBitsPerSample == 8 ? 128 : 0 + a change in configuration (e.g. sampling rate 48000) => split change of default & introduction new of registry key + some refactoring in preparation for future work + changes to logic & functionality e.g. DSDDESC_DONTNEEDWRITELEAD, leadin - It must compile. - It should pass tests (a rule, not a dogma). In this light, [PATCH 08/13] (remove 2x HeapFree) looks wrong, unless it fixed a bug in the old code. It should be part of something else. Try and explain design changes. Your code is not only a resampler, it also changes the way DSound performs mixing, such that DSOUND_MixToTemporary becomes superfluous. What's not so nice -- yet that has happened several times already -- is to have a patch like "Now use the new functions added in the last 12 patches instead of the old ones", because regression testing will irremediably identify that patch as culprit and not help identify which of the 12 introducing patches caused the "actual" regression via a subtle change in behaviour or side effects. Conversely, if you think about how regression testing can work well, you'll find recommendations for patches yourself. About ordering: Move the patch introducing the new registry key towards the end, and work with a constant prior to that. Doing so, this patch becomes working code instead of being ground work not testable until the resampler is in place. I suggest isolating - the FIR generator + Makefile change. - keeping patch 11 -- remove unused files & code last -- so as to minimize size of patches that introduce code. As a side note, I'm wondering whether I'd insert resample.c into mixer.c. + TRACE("resample quality: %d\n", dsb->quality); + TRACE("resample firstep %d\n", dsb->firstep); Logging is expensive (when on) and known to cause race conditions. Hence I'd combine all these into one line. Also keep in mind that your reactions here will influence acceptance of your code -- "Does this person sound like s/he's going to support and fix regressions in her/his code or is it 'take or leave, bye'?" Regards, Jörg Höhle

3 2

Resend: Who does c2man?
by Max TenEyck Woodbury 11 Feb '11

11 Feb '11

I have just been going over tools/c2man and have a fair number of questions about it. I can probably dig some of the answers out myself, but it would probably go faster and raise less fuss if I can talk to the person (people) who have worked on it previously. Please send me email with contact information, or indicate that you want this done on some forum. Max

3 3