June 2011 - Wine-devel - list.winehq.org

Re: [3/3] msxml3: Added IStream support to IMXWriter
by Adam Martinson 20 Jun '11

20 Jun '11

On 06/19/2011 09:32 PM, Thomas Mullaly wrote: > +static inline void reset_output_buffer(mxwriter *This, LPCSTR encoding) > +{ > + xmlOutputBufferClose(This->buffer); > + > + if (encoding) > + This->buffer = xmlAllocOutputBuffer(xmlFindCharEncodingHandler(encoding)); > + else if (!This->dest) > + This->buffer = xmlAllocOutputBuffer(xmlFindCharEncodingHandler("UTF-16")); > + else { > + LPSTR enc = heap_strdupWtoA(This->encoding); > + This->buffer = xmlAllocOutputBuffer(xmlFindCharEncodingHandler(enc)); > + heap_free(enc); > + } > + > + This->dest_written = 0; > +} > Libxml2 has the various encodings enum'd out as xmlCharEncoding; better to pass the enum around and avoid the string comparison. Then you can use xmlGetCharEncodingHandler() instead of xmlFindCharEncodingHandler().

1 0

Re: [1/3] msxml3/tests: Added IStream tests for IMXWriter
by Adam Martinson 20 Jun '11

20 Jun '11

On 06/19/2011 09:31 PM, Thomas Mullaly wrote: > +#define DEFINE_EXPECT(func) \ > + static BOOL expect_ ## func = FALSE, called_ ## func = FALSE > + > +#define SET_EXPECT(func) \ > + expect_ ## func = TRUE This seems like macro-overkill. I think a struct/table here may be a bit cleaner. > +static const CHAR szUtf16BOM[] = {'\xff','\xfe'}; Normal hex here would be more readable.

1 0

Re: ddraw: Add tests for SetCooperativeLevels
by Marvin 20 Jun '11

20 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11839 Your paranoid android. === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

CopyFileExW Support
by Arthur Dene Ice 20 Jun '11

20 Jun '11

Thank you Jerome, this is my first patch and I pretty much bunged it all up. I appreciate the help. So to recap, subscribe to list first so that I can respond to messages. check. Fix my tab/spacing issue. check. and fix my patch submission subject line so it is more in line with the standard. check.

1 0

Re: [PATCH 1/6] quartz/tests: COM cleanup for the IPin iface.
by Marvin 19 Jun '11

19 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11823 Your paranoid android. === WNT4WSSP6 (32 bit filtergraph) === filtergraph: unhandled exception c0000005 at 00405B3C

2 1

Re: [PATCH 6/6] quartz/tests: Simplify the file handling in filtergraph.c.
by Marvin 19 Jun '11

19 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11828 Your paranoid android. === WNT4WSSP6 (32 bit filtergraph) === filtergraph: unhandled exception c0000005 at 00405AEC

1 0

Re: [PATCH 5/6] quartz/tests: Store the TestFilterImpl instead of its iface in IEnumPinsImpl.
by Marvin 19 Jun '11

19 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11827 Your paranoid android. === WNT4WSSP6 (32 bit filtergraph) === filtergraph: unhandled exception c0000005 at 00405B2C

1 0

Re: [PATCH 4/6] quatz/tests: Pass back the object instead of the iface in createtestfilter()
by Marvin 19 Jun '11

19 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11826 Your paranoid android. === WNT4WSSP6 (32 bit filtergraph) === filtergraph: unhandled exception c0000005 at 00405B2C

1 0

Re: [PATCH 3/6] quartz/tests: Finish the COM cleanup in filtergraph.c.
by Marvin 19 Jun '11

19 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11825 Your paranoid android. === WNT4WSSP6 (32 bit filtergraph) === filtergraph: unhandled exception c0000005 at 00405B3C

1 0

Re: [PATCH 2/6] quartz/tests: COM cleanup for the IClassFactory iface.
by Marvin 19 Jun '11

19 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11824 Your paranoid android. === WNT4WSSP6 (32 bit filtergraph) === filtergraph: unhandled exception c0000005 at 00405B3C

1 0