June 2011 - Wine-devel - list.winehq.org

Disablin xinput2 for now?
by Marcus Meissner 23 Jun '11

23 Jun '11

Hi, There seem to be regressions in xinput2 support, http://bugs.winehq.org/show_bug.cgi?id=27028 As this might be a X.org issue, should we packagers turn off xinput2 support for the time being? Ciao, Marcus

4 6

Re: [PATCH 3/4] shell32: Add IKnownFolder::SetPath() implementation
by Mariusz Pluciński 23 Jun '11

23 Jun '11

Please, ignore this single patch. This function should be implemented in other way (using redirection feature, the thing I am working on but did not submit yet). W dniu 23.06.2011 18:50, Mariusz Pluciński pisze: > --- > dlls/shell32/shellpath.c | 32 ++++++++++++++++++++++++++++++-- > dlls/shell32/tests/shellpath.c | 3 +-- > 2 files changed, 31 insertions(+), 4 deletions(-) > > -- Best regards Mariusz Pluciński

1 0

Re: [2/6] Make ComboBoxEx send CBEN_ENDEDIT when selecting from the dropdown list
by Nikolay Sivov 23 Jun '11

23 Jun '11

On Thu, Jun 23, 2011 at 6:57 PM, Jay Yang <jkelleyy(a)gmail.com> wrote: > >> Could you please add a test for that? It's possible to explicitly send >> WM_COMMAND I guess. This could be done as a next patch if you're sure >> it works right. But in general it should come with a fix. > Hi Nikolay, > > Do you have a suggestion on how to simulate selecting an element from the dropdown list? Should I just send a CBN_DROPDOWN message followed by a CBN_CLOSEUP to the ComboBoxEx? > Yes, this could work I think. Sometimes it's a pain to get a reliable test for controls that are made from another ones, because interaction between them differs or creation order differs between native a wine's. If it's not worth it, it's ok to add simple separate test application to reproduce that, link it with a patch or as another message to wine-devel. Just to have more information about what this patch fixes.

1 0

Re: [4/5] user32: Test that QS_HOTKEY is properly set and cleared.
by Marvin 23 Jun '11

23 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11926 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [2/6] Make ComboBoxEx send CBEN_ENDEDIT when selecting from the dropdown list
by Nikolay Sivov 23 Jun '11

23 Jun '11

On Thu, Jun 23, 2011 at 6:31 PM, Jay Yang <jkelleyy(a)gmail.com> wrote: > Windows send a CBEN_ENDEDIT when selecting from the dropdown menu, and for wine to send that message, the WCBE_ACTEDIT flag needs to be set when the dropdown is created. > --- > dlls/comctl32/comboex.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > Hey, Jay. Could you please add a test for that? It's possible to explicitly send WM_COMMAND I guess. This could be done as a next patch if you're sure it works right. But in general it should come with a fix.

1 0

GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9
by Michael Mc Donnell 23 Jun '11

23 Jun '11

Sorry I made a mistake. On Thu, Jun 23, 2011 at 11:07 AM, Michael Mc Donnell <michael(a)mcdonnell.dk> wrote: > Yes that's the basics of it. It does some other funny things too. For > example it re-orders the indices, so if you have > > 0--1 6 3 > | / / | | \ > | / / | | \ > 2 8--7 5--4 > > That corresponds to: > > index buffer = [ 0,1, 2, 6, 7,8, 3, 4,5] > adjacency = [-1,1,-1, 2,-1,0, -1,-1,1] > point rep = [ 0,1, 2, 1, 4,7, 1, 7,2] Index 5 is not replaced by 7 because the lowest index is always used. So it should have been the other way around: point rep = [ 0,1, 2, 1, 4,5, 1, 5,2] > If the indices had not been re-ordered then the point representation > would have been > [0,1,2, 1,7,2, 1,4,7]. And similarly [0,1,2, 1,5,2, 1,4,5]. I'll put this example into the test.

1 0

Re: [PATCH 03/10] urlmon: Reimplement CreateURLMonikerEx on top of IUri APIs
by Alexandre Julliard 23 Jun '11

23 Jun '11

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/umon.c | 115 > ++++++++++++++++++++++++++++------------------------ > 1 files changed, 62 insertions(+), 53 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M qmgr.dll -T ../../.. -p qmgr_test.exe.so job.c && touch job.ok job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:386: Test failed: BITS jobs timed out job.c:388: Test failed: IBackgroundCopyJob_Complete job.c:329: Test failed: CreateFile job.c:333: Test failed: ReadFile job.c:338: Test failed: Files differ in length job.c:339: Test failed: Files differ in contents job.c:329: Test failed: CreateFile job.c:333: Test failed: ReadFile job.c:338: Test failed: Files differ in length job.c:339: Test failed: Files differ in contents make: *** [job.ok] Error 39 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] d3dx9_36/tests: Added tests for constant table samplers (Try 2)
by Marvin 22 Jun '11

22 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11904 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/6] msvcp90: Added locale class stub
by Alexandre Julliard 22 Jun '11

22 Jun '11

Piotr Caban <piotr(a)codeweavers.com> writes: > +/* ?name(a)locale@std@@QBE?AV?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@2(a)XZ */ > +/* ?name(a)locale@std@@QEBA?AV?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@2(a)XZ */ > +DEFINE_THISCALL_WRAPPER(locale_name, 8) > +void __thiscall locale_name(THIS_AND_RET(const locale *this, basic_string_char *ret)) > +{ > + FIXME("(%p %p) stub\n", this, ret); > +} You should declare it correctly for the non-i386 case, the return pointer is a calling convention detail that the compiler should take care of. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] shell32: Add IKnownFolderManager::RegisterFolder implementation (resend)
by Marvin 22 Jun '11

22 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11886 Your paranoid android. === WVISTAADM (32 bit shellpath) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0