June 2011 - Wine-devel - list.winehq.org

[1/2] d3dx9/test: Add UpdateSemantics test. (try 3)
by Michael Mc Donnell 22 Jun '11

22 Jun '11

Hi Alexandre My UpdateSemantics patches haven't been applied yet. Stefan Dösinger and Dylan Smith think they look ok. Is there something that looks wrong with them to you, or have you just not have the time to look at them yet? Thanks, Michael Mc Donnell

1 0

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)
by Marvin 22 Jun '11

22 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11882 Your paranoid android. === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [2/3] wined3d: Fix context_apply_draw_buffers() with backbuffer ORM.
by Henri Verbeet 21 Jun '11

21 Jun '11

On 21 June 2011 23:49, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > Here I modified surface_get_gl_buffer() to fix backbuffer ORM, an > alternative approach would be to modify > context_apply_[blit|clear|draw]_state() in a similar fashion instead. > Yeah, I think I'd prefer the alternative. We handle onscreen and offscreen surfaces separately for the FBO cases as well, and conceptually I'd prefer ORM checks to be in the context code if anywhere.

1 0

bug policy for "app X needs msvcp90.dll" type bugs
by Dan Kegel 21 Jun '11

21 Jun '11

(From the "keeping AF happy" and "metabugs are evil" departments.) Anyone watching wine-bugs already knows this, but just in case: As AF suggested in http://bugs.winehq.org/show_bug.cgi?id=24745#c11 bugs about apps needing msvcr90 or the like should identify the particular function in the bug subject line, if possible. There are still some bugs that simply say "app X needs native msvcr90". When the particular function that bothered them is fixed, and the app is verified to get further, that bug's subject line should be updated to identify the function that was fixed, and the bug should be marked as fixed. If the game still doesn't run because of some other function, a new bug should be filed.

1 0

Re: [PATCH 2/2] jscript: Correctly throw an exception if instanceof expression is not used on function
by Marvin 21 Jun '11

21 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11874 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/5] shell32: Add IKnownFolderManager::RegisterFolder implementation
by Mariusz Pluciński 21 Jun '11

21 Jun '11

Hello Would you explain me, what is wrong with this patches series? I've submitted it last week and for some reason it's status is untouched. (the "failed" status seems to be temporal testbot's problem rather than my patch's, so this is not the reason). I have no idea how to fix them. Best regards Mariusz Pluciński W dniu 15.06.2011 18:05, Mariusz Pluciński pisze: > To not break currently working applications/tests, I decided to > implement known folders using following schema: > 1. implement infrastructure of known folders without breaking > currently working CSIDL-based way. New code is used only for folders > registered using RegisterFolder(). For all others, the older code > using CSIDL_Data array is used. > 2. move all folders from CSIDL_Data array to registry and remove old > way of accessing them. > --- > dlls/shell32/shellpath.c | 70 > ++++++++++++++++++++++++++++++++++++++- > dlls/shell32/tests/shellpath.c | 1 - > 2 files changed, 68 insertions(+), 3 deletions(-) > >

2 1

Re: Regression today?
by Susan Cragin 21 Jun '11

21 Jun '11

2 1

Regression today?
by Susan Cragin 21 Jun '11

21 Jun '11

I think a regression was introduced today. I got the following trying to run NatSpeak 11.0 with today's git. wine-1.3.22-255-g4c0c0d3 Should I do a regression test and file a bug, or is it obvious from this? Or is it me -- something to do with my new Oneiric Ocelot? Or the new 3.0 kernel? susan(a)ubuntu:~/.wine/drive_c/Program Files/Nuance/NaturallySpeaking11/Program$ wine natspeak err:service:service_send_start_message service L"DragonSvc" failed to start fixme:iphlpapi:NotifyAddrChange (Handle 0xc2e91c, overlapped 0xc2e900): stub wine: configuration in '/home/susan/.wine' has been updated. fixme:ole:CoInitializeSecurity ((nil),-1,(nil),(nil),0,3,(nil),0,(nil)) - stub! fixme:wbemprox:wbem_locator_ConnectServer 0x134288, L"ROOT\\CIMV2", (null), (null), (null), 0x00000000, (null), (nil), 0xfcea54) fixme:mountmgr:harddisk_ioctl returning zero-filled buffer for IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS fixme:mountmgr:harddisk_ioctl unsupported ioctl 74080 fixme:wbemprox:wbem_locator_ConnectServer 0x135fd0, L"ROOT\\CIMv2", (null), (null), (null), 0x00000000, (null), (nil), 0x10cea5c) fixme:mountmgr:harddisk_ioctl returning zero-filled buffer for IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS fixme:mountmgr:harddisk_ioctl unsupported ioctl 74080 fixme:wbemprox:wbem_locator_ConnectServer 0x135fd0, L"ROOT\\CIMv2", (null), (null), (null), 0x00000000, (null), (nil), 0xfcea5c) fixme:mountmgr:harddisk_ioctl returning zero-filled buffer for IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS fixme:mountmgr:harddisk_ioctl unsupported ioctl 74080 fixme:wbemprox:wbem_locator_ConnectServer 0x136020, L"ROOT\\CIMv2", (null), (null), (null), 0x00000000, (null), (nil), 0x10cea5c) fixme:wbemprox:wbem_locator_ConnectServer 0x136020, L"ROOT\\WMI", (null), (null), (null), 0x00000000, (null), (nil), 0xfcea54) fixme:reg:RegSetKeySecurity :(0x60,4,0xd9ba9c): stub fixme:mountmgr:harddisk_ioctl returning zero-filled buffer for IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS fixme:mountmgr:harddisk_ioctl unsupported ioctl 74080 fixme:wbemprox:wbem_locator_ConnectServer 0x136020, L"ROOT\\CIMv2", (null), (null), (null), 0x00000000, (null), (nil), 0x10cea5c) susan(a)ubuntu:~/.wine/drive_c/Program Files/Nuance/NaturallySpeaking11/Program$

3 2

Re: [PATCH 1/4] dlls/ntdll: Add handle count to NtQuerySystemInformation
by Vitaliy Margolen 21 Jun '11

21 Jun '11

On 06/19/2011 08:15 PM, Austin Lund wrote: > + ret = wine_server_call( req ); > + shi->Count += reply->handles; > + len = sizeof(SYSTEM_HANDLE_ENTRY)*shi->Count + sizeof(ULONG); > + shi = RtlReAllocateHeap(GetProcessHeap(), HEAP_ZERO_MEMORY, shi, len); Please do allocations outside of server call block. And add handling of failed realloc. Also please double the allocated size, don't reallocate after each server call. > + for (i = shi->Count - reply->handles; i< shi->Count; i++) { > + shi->Handle[i].OwnerPid = reply->pid; > + } Please follow file's curly braces style - none for single line blocks, or on separate line for multi-line blocks. Vitaliy.

2 4

Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer.
by Vitaliy Margolen 21 Jun '11

21 Jun '11

On 06/20/2011 04:06 PM, Lucas Fialho Zawacki wrote: > @@ -1391,9 +1391,24 @@ HRESULT WINAPI IDirectInputDevice8AImpl_SetActionMap(LPDIRECTINPUTDEVICE8A iface > LPCSTR lpszUserName, > DWORD dwFlags) > { ... > + hr = IDirectInputDevice8_SetActionMap(&This->IDirectInputDevice8W_iface, > +&diafW, NULL, dwFlags); You need to call IDirectInputDevice8WImpl_SetActionMap directly here. Also please don't wrap lines at 80 characters, you can put all that into one line. And please be consistent with spacing around parentheses - either put spaces on both sides, or don't put at all. > + memset(&dp,0,sizeof(dp)); Please don't needlessly zero structures. You setting most values of it anyway. And please don't forget spaces after comas. Otherwise looks really good! Vitaliy.

1 0