June 2011 - Wine-devel - list.winehq.org

Re: setupapi: Make sure machine name is non-empty before failing (try 2)
by Marvin 09 Jun '11

09 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11589 Your paranoid android. === WNT4WSSP6 (32 bit devinst) === No test summary line found

1 0

Re: setupapi: Make sure machine name is non-empty before failing
by Dmitry Timoshkov 09 Jun '11

09 Jun '11

Juan Lang <juan.lang(a)gmail.com> wrote: > +static const WCHAR emptyW[] = { 0 }; ... > - if (MachineName != NULL) > + if (MachineName != NULL && strcmpW(MachineName, emptyW)) What's wrong with 'if (MachineName && *MachineName)' ? -- Dmitry.

2 1

re: TaskDialog implementation
by Dan Kegel 09 Jun '11

09 Jun '11

Patrick wrote: > I'd like to port my re-implementation of task dialogs > (http://www.korosoft.net/projects/tdemu/) to WINE Awesome! > I would like to have some guidance ... [Why was my patch from > yesterday not accepted?] An iota of guidance was provided at http://source.winehq.org/patches/ Scroll down to your patch, you can see it's in "Pending" state. Scroll down further, you'll see that "Pending" means "The patch is not obviously correct at first glance. Making a more convincing argument, preferably in the form of a test case, may help." See also http://wiki.winehq.org/SubmittingPatches for a generic checklist. Your patch seemed to do three things: - moving old stub into new file - adding a TaskDialog function - adding ordinals Those three things could all be separate patches, and some of them could have tests. I'd suggest sending just one of the three first (probably not the one that moves code to a new file), and including a test with the first patch. - Dan

1 0

Re: [1/2] d3dx9/test: Add UpdateSemantics test.
by Stefan Dösinger 09 Jun '11

09 Jun '11

On Wednesday 08 June 2011 18:51:41 Michael Mc Donnell wrote: > unsigned int faces[] = {0, 1, 2}; > unsigned int num_faces = sizeof(faces) / 3; Does this do what you want? As far as I can see you want ARRAY_SIZE(faces) / 3. > + struct { > + D3DXVECTOR3 position0; > + D3DXVECTOR3 position1; > + D3DXVECTOR3 normal; > + DWORD color; > + } vertices[] = { > ... Another style nitpick: Bracket placing. > + /* Two null pointers. Setting only the mesh to null will result in an > + * exception on Windows. > + */ > + hr = mesh->lpVtbl->UpdateSemantics(NULL, NULL); I think setting the instance pointer to NULL when invoking a method doesn't need a test, it will give you odd results. What you show here is that native checks the only method parameter before it accesses the object instance. Remember, usually apps will invoke this via C++: mesh->UpdateSemantics(declaration); Similarly it isn't necessary to check iface or This against NULL in the implementations. Otherwise this looks OK

4 6

Re: [PATCH 2/2] urlmon: Added empty file binding test
by Marvin 09 Jun '11

09 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11581 Your paranoid android. === WVISTAADM (32 bit protocol) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 1/4] shell32/tests: basic tests of IKnownFolderManager
by Vincent Povirk 09 Jun '11

09 Jun '11

+ OleInitialize(NULL); Any particular reason you're using this instead of CoInitialize? I don't think there's anything wrong with it, but CoInitialize is more common. + todo_wine + ok(cat==KF_CATEGORY_FIXED, "invalid folder category: %d\n", cat); You'd be using cat uninitialized when the function is not implemented in Wine. I suggest initializing it to 0 or something. Same with redirectionCapabilities later. + ok(lstrcmpW(sWinDir, folderPath)==0, "invalid path returned: %s\n", wine_dbgstr_w(folderPath)); It might be useful to print sWinDir as well. If there's some situation where it's the right path but not quite the same string, that'd be good to know. + /* try to set new path */ + hr = IKnownFolder_SetPath(folder, 0, sTempDir); + todo_wine + ok(hr == S_OK, "setting path failed: 0x%08x\n", hr); I'd suggest making up + registering your own known folder to test this feature, rather than using a standard one. I worry someone could end up with a broken Windows install if we fail to put it back somehow.

2 1

Re: [2/2] d3dx9: Implement UpdateSemantics mesh method.
by Marvin 08 Jun '11

08 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11567 Your paranoid android. === WXPPROSP3 (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EA43 === W2K3R2SESP2 (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EA43 === WVISTAADM (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EA43 === W2K8SE (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EA43 === W7PRO (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EA43 === W7PROX64 (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EA43 === W7PROX64 (64 bit mesh) === Timeout

1 0

Simple Windows Diaglogue App
by Lewis McLean 08 Jun '11

08 Jun '11

Hi, I'm trying to compile a simple windows dialogue app over to run on *nix with winelib. I'm looking at it as proof of concept for porting a larger application over. I've been getting errors from gcc to do with vc++ casting, where it loses precision. LinuxPort.cpp: In function 'int WinMain(HINSTANCE__*, HINSTANCE__*, CHAR*, int)': LinuxPort.cpp:34: error: cast from 'CHAR*' to 'WORD' loses precision LinuxPort.cpp:39: error: cast from 'CHAR*' to 'WORD' loses precision winegcc: i486-linux-gnu-g++ failed Ive tried to use static_cast<> and also c-style casting using () but can't seem to get it working. Any ideas? Thanks, Lewis

2 1

Re: [1/2] d3dx9/test: Add UpdateSemantics test.
by Marvin 08 Jun '11

08 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11566 Your paranoid android. === WXPPROSP3 (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EB8D === W2K3R2SESP2 (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EB8D === WVISTAADM (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EB8D === W2K8SE (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EB8D === W7PRO (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EB8D === W7PROX64 (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EB8D === W7PROX64 (64 bit mesh) === Timeout

1 0

re: Simple Windows Diaglogue App
by Dan Kegel 08 Jun '11

08 Jun '11

Lewis wrote: > I'm trying to compile a simple windows dialogue app over to run on *nix > with winelib. I'm looking at it as proof of concept for porting a larger > application over. First off, why winelib rather than plain wine? Are you planning on targeting non-x86 computers? > LinuxPort.cpp:34: error: cast from 'CHAR*' to 'WORD' loses precision It might help to see your source code. - Dan

1 0