June 2011 - Wine-devel - list.winehq.org

Re:o
by Nick Burns 03 Jun '11

03 Jun '11

http://www.sisco.ch/indexz35X.php

1 0

Re: [1/3] kernel32/heap: Emulate Win9x if appropriate in GlobalMemoryStatusEx(). (resend)
by Dmitry Timoshkov 03 Jun '11

03 Jun '11

Adam Martinson <amartinson(a)codeweavers.com> wrote: > + osver.dwOSVersionInfoSize = sizeof(osver); > + GetVersionExW(&osver); > + ... > + if (osver.dwMajorVersion >= 5) Once again, that's wrong way of detecting win9x, or please try to explain better how the patch does what the subject describes, and for which app it's needed. -- Dmitry.

3 5

Re: [PATCH 3/3] msvcrt: Improved tolower_l and toupper_l implementation
by Marvin 03 Jun '11

03 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11457 Your paranoid android. === WNT4WSSP6 (32 bit string) === string.c:1987: Test failed: ret = fffffff4 string.c:1992: Test failed: ret = ffffffd0 === W2KPROSP4 (32 bit string) === string.c:1987: Test failed: ret = fffffff4 string.c:1992: Test failed: ret = ffffffd0 === WXPPROSP3 (32 bit string) === string.c:1987: Test failed: ret = fffffff4 string.c:1992: Test failed: ret = ffffffd0 === W2K3R2SESP2 (32 bit string) === string.c:1987: Test failed: ret = fffffff4 string.c:1992: Test failed: ret = ffffffd0

1 0

Re: [4/4] ws2_32: Avoid a crash with an optional pointer in WSAAsyncGetServByName.
by Marvin 03 Jun '11

03 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11362 Your paranoid android. === WXPPROSP3 (32 bit sock) === sock.c:501: Test failed: oob_server (218): unexpectedly at the OOB mark: 0 sock.c:511: Test failed: oob_server (218): unexpectedly at the OOB mark: 0

3 3

mmdevapi buffering
by Joerg-Cyril.Hoehle＠t-systems.com 03 Jun '11

03 Jun '11

Hi, I have one big concern about MSDN's "Rendering a stream" (shared mode) example w.r.t wrap-around of buffer pointers and how Wine implements it. The example is at http://msdn.microsoft.com/en-us/library/dd316756(v=vs.85).aspx Suppose the write pointer is near the end of the buffer and the app is a little late, so the HW read pointer is not far away. |---------------------------------------------------^read------^write-----| What is GetCurrentPadding going to return? - the tiny write-read portion, says MSDN AFAICT - 0, because there's a new fresh buffer waiting to be filled? MSDN's example then computes avail = GetBufferSize() - GetCurrentPadding(); What is GetBuffer(avail) going to return?!? - If it's a pointer to the above buffer, it can only succeed if avail is tiny, otherwise there's a buffer overflow. However avail, as defined above and in MSDN's example, will be large. Wine tricks around that by returning a dynamic local tmp buffer larger than GetBufferSize (I wonder why a fixed one instead, twice GetBufferSize would not suffice?) Does native behave like that? - E_BUFFER_TOO_LARGE ? The MSDN example would exit. - Could it be a pointer to the beginning of the buffer? - Or it's a pointer to another buffer! That's not compatible with Wine's current local_buffer implementation... Isn't Wine's mmdevapi going to produces glitches? The problematic situation is when avail is small, as the following sleep for half a buffer size in MSDN's example will inevitably produce an xrun. So what actually is the buffer size and how does GetCurrentPadding behave? I don't expect MSDN's example to be fundamentally flawed. IMHO, they designed their API such that it is the typical use case. I believe that multiple buffers (of size GetBufferSize) are involved (much like ALSA's periods) and that GetBuffer switches among them -- exactly like they say about the exclusive mode ping pong. I suppose native's mixer (in shared mode) would mix these possibly incompletely filled buffers and everything is fine there. No need to deal with wrap-around! Why should Wine do something entirely different? Regards, Jörg Höhle

2 2

Re: [1/5] wined3d: Add support for GL_ARB_timer_query.
by Stefan Dösinger 03 Jun '11

03 Jun '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I'd recommend to wait for Henri to return from vacation before applying these Am 02.06.2011 um 19:25 schrieb Adam Martinson: > --- > dlls/wined3d/directx.c | 1 + > dlls/wined3d/wined3d_gl.h | 19 +++++++++++++++++++ > 2 files changed, 20 insertions(+), 0 deletions(-) > > > <0002-wined3d-Add-support-for-GL_ARB_timer_query.patch> -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJN6KyMAAoJEN0/YqbEcdMw+doP/jwoZxrZSkkgguKyN0MKlpNl BaYc2Yc3uGdNrOLCk78X/Zu1otVVlNZJHR5xIID3ZaK0egjhHRXF7Ljhj36paduN u25lslD4iN1IRHocDm0C0IqmmX5Q8YMrGSf1Xxn19KFaWV7tTHqs5KE4Dz707lct 0R/doxjYyZ4uBiE9FIglnPm2DZsyZoi5RPlYZA2XSD5uC57hD8hdqQPmLGXw+O42 WpjvNsN+hDwghJOEBCyG93rsttU7Zb9CBAQJS/CqYegG0L6cbRAZHebj/kHgWT7M 4TBNlo0rElgcD3/2CXNK1jjDSvAKS1soicnv7ZtlKbbmEHPE4EaQ82giIkqJB2Vv NddGTh9JvINLVq8FBJwRs9CwAMhVjUeGvrI13tnSUSu4QdcMZ9fxlg2SIeslWNrB x34siT+Eo8hOY6ZP6nTbdScSoxkHvOm4T8xeGKgC0l+sdAdAP18sHV1SgwoSLth/ fk68H6j6unL2S5yaQmIwaC+EKLRQkG+/wlsoFltR0iOplsxYKtm7KvYet6UAQNol Pq7Z1d7KLlg7GnsKgcFVVtXXNgEcKaEchuxUzRKkQy46MbQsghJhDW4mr+8vGwNS bFWf2qxHP0D8b/VnK43tsIAoXb5iA92yAlrC0e3ssy2yMdjS3SiFvwOBQsMtqBrD V0X2LrLXsqM1n00U6mPN =1nqX -----END PGP SIGNATURE-----

1 0

winealsa.drv:mmdevapi input validation
by Joerg-Cyril.Hoehle＠t-systems.com 03 Jun '11

03 Jun '11

Hi, because of bug #27087, I had a look at the emerging mmdevapi code. Actually, it's the first time I read its documentation on MSDN. Here are a few comments of mine while reading the code. The handling of duration (-> buffer size) in winealsa.drv/mmdevdrv.c:AudioClient_Initialize does not perform enough validation. MSDN explicitly acknowledges that it could be 0. I believe it should be related to ALSA's buffer, or a minimum of something like 2*period_size. Or perhaps even 3*period size. IIRC MSDN also documents a maximum of 2s for renderer and 0.5 for capture. AudioRenderClient_ReleaseBuffer does not check that written_frames is what GetBuffer returned. Use with AUDCLNT_BUFFERFLAGS_SILENT and you'll have memcpy overwrite arbitrary amounts of memory. MSDN says: AUDCLNT_E_INVALID_SIZE I believe Wine should currently include if (AUDCLNT_STREAMFLAGS_EVENTCALLBACK && SHAREMODE_EXCLUSIVE) { FIXME("unsupported") & return E_ } because none of the buffer allocation and parameter checking specific to that mode that MSDN mentions in Initialize is implemented. When it (the ping pong buffer logic) will be implemented, some better logic to trigger SetEvent() will probably be needed, because I'm unsure whether CreateTimerQueueTimer() provides the required stability over time and possibly ignores a laptop's suspend/resume cycle or xruns. In exclusive mode, reception of an event is a guarantee that GetBuffer(GetBufferSize frames) will succeed. I suggest the values returned by AudioClient_GetDevicePeriod be adjusted to match what test.winehq shows. 10ms/3ms makes some sense, 10ms is mentioned a lot in MSDN and blogs. 3ms is small yet has a chance to work without glitch with MSDN's exclusive mode example. I can't remember seeing input validation of broken avgbytes and blockalign in the WAVEFORMAT parameter. I showed some tests some month ago that prove that unlike Wine, winmm is not disturbed by bad values. How does mmdevapi react to them? Regards, Jörg Höhle

2 2

Re: [13/18]usp10/tests: add Gurmukhi shaping test
by Marvin 02 Jun '11

02 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11438 Your paranoid android. === WXPPROSP3 (32 bit usp10) === TestLauncher.c:89: Test failed: Can't open test executable C:\winetest\usp10_test.exe, error 32

1 0

Re: [2/19](resend)usp10: improve Sinhala shaping using Indic rules
by Alexandre Julliard 02 Jun '11

02 Jun '11

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -0,0 +1,236 @@ > + > +#include "config.h" > +#include <stdarg.h> > +#include <stdio.h> > +#include <stdlib.h> Please add a license header on new files. > +#define IS_VALID_INDEX (next < cChar) Don't reference local variables directly, pass them to the macro. > +#define OPTIONAL_CHAR(a) if (IS_VALID_INDEX && lex(input[next])==a) {next++;} > +#define OPTIONAL_CHAR_JOINER() if (IS_VALID_INDEX && IS_JOINER(next)) {next++;} > +#define ZERO_OR_MORE(a) while(IS_VALID_INDEX && lex(input[next])==a){next++;} > +#define ZERO_OR_MORE_MANTRA() while (IS_VALID_INDEX && IS_MANTRA(next)){next++;} Same here, and these should be wrapped in do/while(0). -- Alexandre Julliard julliard(a)winehq.org

1 0

ddraw: Add tests for Setcooperativelevel
by paulo lesgaz 02 Jun '11

02 Jun '11

Hi, any problem with the patch http://source.winehq.org/patches/data/74702 A+ David

2 3