June 2011 - Wine-devel - list.winehq.org

Re: [PATCH 2/5] wined3d: Just enable ARB_shader_texture_lod if it's available.
by Stefan Dösinger 07 Jun '11

07 Jun '11

On Tuesday 07 June 2011 11:06:25 Henri Verbeet wrote: > - if (gl_info->supported[ARB_SHADER_TEXTURE_LOD] && > reg_maps->usestexldd) Why is reg_maps->usestexldd not true in pixel shaders?

3 5

GSoC: dinput8 Action Mapping
by Lucas Zawacki 06 Jun '11

06 Jun '11

Hey guys. So last week I finally got a good understanding of dinput as a whole and nailed some trivial cases of action mapping, the ones with the keyboard. I'm sending a series of patches so everyone can take a look before I try commiting them. Please note that these contain a partial implementation of EnumDevicesBySemantics, BuildActionMap and SetActionMap, and also they're only the A versions. There are some tests for EnumDevicesBySemantics. I'm not too sure of how to code the tests that require user input... I hope it's not a nuisance to read the code split in 7 files, if you guys want I can merge it in one big diff. On a bright note, this patchset results in the input working for these two games: * http://appdb.winehq.org/objectManager.php?sClass=application&iId=3678 * http://appdb.winehq.org/objectManager.php?sClass=application&iId=7919 Cheers :)

3 3

Re: wined3d: Enable blit stretching for 64 bpp
by Stefan Dösinger 06 Jun '11

06 Jun '11

On Saturday 04 June 2011 18:24:39 André Hentschel wrote: > + case 8: > + STRETCH_ROW(DWORD64); > + break; 64 bit formats can be floating point formats too, like ARGB16F, or RG32F. But Roderick's comment catches the more important issue: This code shouldn't be called for 64 bit formats at all since they are only supported with FBOs which bring hardware blitting support.

2 1

Re: [3/3] kernel32/heap: Add registry caps for reported memory. (resend)
by Andrew Nguyen 06 Jun '11

06 Jun '11

On 06/06/2011 11:03 AM, Adam Martinson wrote: > + /* Only check this once */ > + if (!cache_lastchecked) > + { > + HMODULE hadvapi32 = LoadLibraryA("advapi32.dll"); > +#define ADVAPI32_GET_PROC(func) typeof(func) * p ## func = (void*)GetProcAddress(hadvapi32, #func) > + ADVAPI32_GET_PROC(RegOpenKeyExA); > + ADVAPI32_GET_PROC(RegCloseKey); > + ADVAPI32_GET_PROC(RegGetValueA); I think you want to use NtCreateKey and NtQueryValueKey instead of dynamically loading advapi32 for registry functionality.

2 1

Re: ole32/ole2: Don't call IDropTarget::QueryInterface() in RegisterDragDrop(). (try 4 resend)
by Michael Stefaniuc 06 Jun '11

06 Jun '11

Hello Adam, Adam Martinson wrote: > This is to work around apps which break COM rules by not implementing you need to follow the Wine COM guidelines: http://wiki.winehq.org/COMGuideline > IDropTarget::QueryInterface(). Windows doesn't expose this because it > doesn't call CoMarshallInterface() in RegisterDragDrop(). > > Fixes bug 23861. > --- > dlls/ole32/ole2.c | 122 > +++++++++++++++++++++++++++++++++++++++--- > dlls/ole32/tests/dragdrop.c | 2 +- > 2 files changed, 114 insertions(+), 10 deletions(-) >

2 1

Re: [1/3] kernel32/heap: Emulate Win9x if appropriate in GlobalMemoryStatusEx(). (try 2)
by Juan Lang 06 Jun '11

06 Jun '11

Hi Adam, perhaps I'm just being obtuse, but I don't see how Dmitry's comment has been addressed for this patch. I'm confused by the commit comment ("Emulate Win9x if appropriate") and the change itself: /* Win98 returns only the swapsize in ullTotalPageFile/ullAvailPageFile, WinXP returns the size of physical memory + swapsize; - mimic the behavior of XP. You are removing the part of the comment explaining what the code actually does, which I find confusing. If you're part of the "the code is the documentation" crowd, just remove the entire comment. If not, please add a brief explanation. Note: Project2k refuses to start if it sees less than 1Mb of free swap. */ - lpmemex->ullTotalPageFile += lpmemex->ullTotalPhys; - lpmemex->ullAvailPageFile += lpmemex->ullAvailPhys; - - /* Titan Quest refuses to run if TotalPageFile <= ullTotalPhys */ - if(lpmemex->ullTotalPageFile == lpmemex->ullTotalPhys) + if (osver.dwMajorVersion >= 5 || osver.dwPlatformId != VER_PLATFORM_WIN32_WINDOWS) This change is confusing to me. dwPlatformId == VER_PLATFORM_WIN32_NT for NT4, Win2k, XP, etc. dwMajorVersion is never greater than 4 on Windows 9x. In other words, do you mean to exclude NT4 here, or not? If so, then the first check should suffice. If not, then the second check should. But in either case, what does this have to do with being "appropriate" for Win9x emulation? --Juan

2 8

Re: [2/3] kernel32/heap: Fix some hacks in GlobalMemoryStatus(). (try 2)
by Dmitry Timoshkov 06 Jun '11

06 Jun '11

Adam Martinson <amartinson(a)codeweavers.com> wrote: > +/* Check the current process and all ancestors that share its address space. > + * Some apps run sub-processes that have the IMAGE_FILE_LARGE_ADDRESS_AWARE flag set, but > + * the parent process doesn't (eg, Dragon NaturallySpeaking 7 setup runs Install Shield 6). > + * If any don't have IMAGE_FILE_LARGE_ADDRESS_AWARE, return FALSE. */ My previous question still applies. -- Dmitry.

3 11

Re: [PATCH 9/9] ddraw: Separate IDirectDrawSurface4 vtable.
by Jesse Allen 06 Jun '11

06 Jun '11

2011/6/6 Ričardas Barkauskas <rbarkauskas(a)codeweavers.com>: > This patch is quite big, but unfortunately I again have no idea how I > could split this properly. Suggestions are welcome. > > Ričardas Barkauskas > REalm > > I don't know how to make it any more straight forward than this. We need to split out IDirectDrawSurface4. Are you going to continue to do test work on this version of DDraw surface? Jesse

1 0

Re: [PATCH 1/5] wined3d: Don't clamp vertex depth values.
by Stefan Dösinger 06 Jun '11

06 Jun '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 05.06.2011 um 22:48 schrieb Henri Verbeet: > Since we report D3DPMISCCAPS_CLIPTLVERTS. Do we still need GL_ARB_depth_clamp after this change? -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJN7H3AAAoJEN0/YqbEcdMw5bwP/2Tne/S6K+XYvL+5snYlrA7i 8i+eADNKVT5MmUJ6F6EZNDJ/esFbU2vfmIoFMlbDZ/l5seubIz1bMjvwteEiqOPo FakpButx8UKh08aGGw/utk3uVTu44ryEnTiNrSoEmx9h2ybym7JdBb/iAEf/nb17 qxI5V4dJf2beB+RQJ88ldtghn++VpDiFOo0t+TlOAe/sDcXTrT+25JtEJF23TxkL amfzjAYEV/f8hXuji2yAU1YOoRFZPfsFOjR+0snnlmXSbMUu5jwJAb+kM0nItlKQ JJGhI4QPOoqyNrltfKmbA3OOpTiihQQ8DYnd8y3PDrzFxftbdmjOHecgIFMxAifZ bOWDlVUctocidCxwUZB83kwhXX4MRVy9iFq0vbrl8omMgnoWC/hoQvO84gLG4E/c LBsIuOl/foLUbye6kk2cPT84hyJdQK4de852dk796zKSUxivCiKEI2L84H/Gi5uO 7l7YPIV9zAeqRV5YFyNgmZsF2ROyy0wQcOx0jt6lp0FTRi2mMKv04L7pdSM/dWO5 AXX/0KDQrZgWMHT/zZzC/LUAxvtBNTezBsk8IHhGvp7yXsKaIGmBbXFpkMANTOJM yVMRwF/VJhbCZXNmAIrrL9Gim/LDp6rcFnQPTYGWe4DJJ+b9gwn6hLbSF2PSEw/Z 9Cqfg2hhtJpfqmx7sjna =5kPk -----END PGP SIGNATURE-----

2 3

mmdevapi/tests: Fix wrong buffer unit and memory leaks.
by Joerg-Cyril.Hoehle＠t-systems.com 06 Jun '11

06 Jun '11

Hi, >* nBlockAlign is wrong since data is counted in frames, not bytes. I forgot to comment that I introduced the 10x multiplicator to convince myself that GetData accepts buffer sizes larger than the default 10ms chunk returned by GetDevicePeriod. That is reasonable, but not guaranteed when I read MSDN (the API would work with small buffers too). Regards, Jörg Höhle

1 0