June 2011 - Wine-devel - list.winehq.org

Re: [PATCH 5/9] server+user32: Added GetRawInputDeviceInfoA implementation (try 8)
by Marvin 27 Jun '11

27 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11984 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 4/9] server+user32: Added GetRawInputDeviceInfoW implementation (try 8)
by Marvin 27 Jun '11

27 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11983 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 3/9] server+user32: Added GetRawInputDeviceList implementation (try 8)
by Marvin 27 Jun '11

27 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11982 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 1/9] user32/tests: Added client-side raw input function tests (try 8)
by Marvin 27 Jun '11

27 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11981 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)
by André Hentschel 26 Jun '11

26 Jun '11

Am 22.06.2011 06:26, schrieb Vincas Miliūnas: > + if (pDefRawInputProc && pGetRawInputBuffer && pGetRawInputData && pGetRawInputDeviceList && > + pGetRawInputDeviceInfoA && pGetRawInputDeviceInfoW && pGetRegisteredRawInputDevices && pRegisterRawInputDevices) You should avoid such a construct, move the check to test_functions that actually need these functions. e.g. check for pGetRawInputBuffer only in test_get_raw_input_buffer i didn't looked very close, but if the tests depend on each other there should be a comment. the rest of that patch looks fine to me -- Best Regards, André Hentschel

2 1

[mshtml] Crash in World of Warcrash launcher
by Vincent Pelletier 26 Jun '11

26 Jun '11

Hi. Runing the latest WoW Launcher, I get the following traceback: Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7d399990 ESP:0032e404 EBP:0032e474 EFLAGS:00010213( R- -- I -A- -C) EAX:00000001 EBX:7d3f22bc ECX:ffffffff EDX:00000000 ESI:00000000 EDI:0281f518 Stack dump: 0x0032e404: 0032e474 00000000 038f3338 0032e430 0x0032e414: 6a00410b 038f3338 00000000 0032e450 0x0032e424: 038f3368 038f3338 00000000 0032e470 0x0032e434: 0281f518 cbc0cbd8 0281f518 0032e480 0x0032e444: 6a617b40 0281f518 6ab94f64 0032e490 0x0032e454: 038f3338 0000000f 0000000e 7ef7bee5 Backtrace: =>0 0x7d399990 doc_insert_script+0x30(window=0x2738378, nsscript=(nil)) [/home/vincent/git/wine/dlls/mshtml/script.c:757] in mshtml (0x0032e474) 1 0x7d36ec96 run_insert_script+0xb5(doc=0x7d36e63e, script_iface=0x3849830, parser_iface=0x38f3368) [/home/vincent/git/wine/dlls/mshtml/mutation.c:338] in mshtml (0x03849830) 2 0x0032e550 (0x0384a9e8) 3 0x00000002 (0x7d3f0a28) 4 0x7d36e7d0 in mshtml (+0x6e7cf) (0x7d36fbc0) 5 0x00000010 (0xb94cec83) 0x7d399990 doc_insert_script+0x30 [/home/vincent/git/wine/dlls/mshtml/script.c:757] in mshtml: movl 0x0(%esi), %eax 757 nsres = nsIDOMHTMLScriptElement_GetType(nsscript, &val_str); Bisecting find this commit: dc96c688d397eb4ef1392ee6a98f3eb6b176dc56 is the first bad commit commit dc96c688d397eb4ef1392ee6a98f3eb6b176dc56 Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 15 13:45:46 2011 +0100 mshtml: Notify parser about script evaluation. :040000 040000 56e26373e5d368d9c991936e12bbf6572b51a1c8 b047f9b40a63e482b477254952737e9e9cd4aded M dlls I don't know if it's a regression in wine by itself, or if WoW Launcher just happens to trigger the failure now (I haven't ran it in some months). -- Vincent Pelletier

2 1

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)
by Vincas Miliūnas 26 Jun '11

26 Jun '11

On 06/22/2011 06:26 PM, André Hentschel wrote: > Am 22/06/2011 06:26, schrieb Vincas Miliūnas: >> + if (pDefRawInputProc && pGetRawInputBuffer && pGetRawInputData && pGetRawInputDeviceList && >> + pGetRawInputDeviceInfoA && pGetRawInputDeviceInfoW && pGetRegisteredRawInputDevices && pRegisterRawInputDevices) > > You should avoid such a construct, move the check to test_functions that actually need these functions. > e.g. check for pGetRawInputBuffer only in test_get_raw_input_buffer > i didn't looked very close, but if the tests depend on each other there should be a comment. > the rest of that patch looks fine to me Done - http://source.winehq.org/patches/data/75756

2 1

Re: [PATCH 5/5] jscript/tests: Add tests with values related to INT_MAX
by Marvin 26 Jun '11

26 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11980 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/5] jscript/tests: Fix copy & paste typos
by Marvin 26 Jun '11

26 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11979 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 7)
by Marvin 26 Jun '11

26 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11978 Your paranoid android. === W7PROX64 (64 bit input) === No test summary line found

1 0