August 2011 - Wine-devel - list.winehq.org

Re: cmd: fixing an issue with extra whitespaces after cd parameter (retry)
by Frédéric Delanoy 17 Aug '11

17 Aug '11

On Fri, Aug 12, 2011 at 19:14, Nowres Rafid <nowres.rafed(a)gmail.com> wrote: > fixing cd ..(a)space@ > > please ignore the previous patch. You didn't include any test in your patch. All patches including a fix must have tests confirming the bug is fixed

1 0

Vista/w2k8/w7 users, please test mmdevapi capture
by Joerg-Cyril.Hoehle＠t-systems.com 17 Aug '11

17 Aug '11

Dear users of machines with Vista/w2k8/w7, Unfortunately, testbot has no mmdevapi-capture enabled machine. If you have a capture-enabled sound card, could you please run the attached patch and report results to me? How you can tell if capture/recording works on your machine: Run the regular mmdevapi:capture and render tests as well as winmm:* (mci, wave etc.) and see if and why they skip tests. You'll find a binary mmdevapi_test.exe (and test64.exe) on testbot: https://testbot.winehq.org/JobDetails.pl?Key=13426 Testbot's machines say: capture.c:724: Tests skipped: No sound card available capture: 1 tests executed (0 marked as todo, 0 failures), 1 skipped. 1 test is too little and shows capture was skipped. Background: I wrote a patch to fix the Get/ReleaseBuffer protocol in the renderer. Looking at the capture code, I suppose a similar patch could apply, but I've no machine at all to test it! ("Protocol" means the order in which methods can be invoked and implies testing the error codes and effects). Thank you for testing, Jörg Höhle

3 3

Re: regedit: adding confirmation message before importing from file
by Andrew Eikum 17 Aug '11

17 Aug '11

On Wed, Aug 17, 2011 at 12:24:18PM +0000, Nowres Rafid wrote: > - reg_file = fopen(realname, "r"); > + > + reg_file = fopen(realname, "r"); The file uses spaces for indenting. Please be consistent and don't use tabs. This is true elsewhere, too: > STRINGTABLE > BEGIN > + IDS_IMPORT_BOX_TEXT "Are you sure you want to add file informations to the registry?" > + IDS_IMPORT_SUCCESS_BOX_TEXT "Values successfuly added to the registry" > + IDS_IMPORT_FAIL_BOX_TEXT "Failed to add values to the registry" > +END Andrew

1 0

Listed package maintainers
by Ben Klein 17 Aug '11

17 Aug '11

Hello everyone, For those of you who remember all the trouble I've had with my health, I'm on the mend now. I'm adjusting to some new medication that's doing wonders, and also adjusting to the new lifestyle they allow me to lead. I've just had a look at http://www.winehq.org/download, as I'm well out-of-date with Wine, and I see Maurilio and I are still listed as being the maintainers for the Debian packages, even though Kai Wasserbäch has taken over that duty (and thank you Kai for doing so!) I also notice the pages have been renamed (so instead of deb = ubuntu, ubuntu and debian are named correctly and unambiguously). I would like to voice my approval as former maintainer of the Debian packages, as token as that may seem at this stage. Kind regards, Ben

3 4

Re: dpnet: add missing IDirectPlay8Peer methods
by Michael Stefaniuc 17 Aug '11

17 Aug '11

Luis, Louis Lenders wrote: > This is part of bug http://bugs.winehq.org/show_bug.cgi?id=28008 a line length of 400+ chars kinda stretches what is acceptable. Please try to stick to a length of 100 in dpnet; that's the Wine preferred line length and also what I used during the COM cleanup in dpnet. Please also stick with one form of placing the spaces, either "TYPE * const var" or "TYPE *const var" but not both in the same patch. I don't remember which form I have used. And please try to avoid PVOID and LPVOID, even if MSDN documents the methods that way. Those are just gratuitous types that add no value. thanks bye michael

1 0

Re: d3dx9: Implemented D3DXWeldVertices and test.
by Stefan Dösinger 17 Aug '11

17 Aug '11

On Monday 15 August 2011 12:16:55 Michael Mc Donnell wrote: > Stefan thought a previous version of this looked ok, and I haven't had > any negative feedback on this version either. The 104 kb / 3000 line patch is rather big, you could probably split it up in test+patch like you did with the other patches to make it obvious that the bulk of this code is the tests. That'll not only help Alexandre, but also people who try to debug potential regressions caused by this patch(*) To avoid lots of todo_wine's just send the implementation first and then the tests. That's not how test driven development works, but most people send patches in this order because it's easier. (*) Ok, a patch adding a new function is unlikely to cause a regression, but still.

2 1

OSA-applets on OS X
by Per Johansson 16 Aug '11

16 Aug '11

Hi, my first post to the list, be gentle. :) I'd like some help to fix up the attached patch for submission. It's a change to winemenubuilder such that it will create an OSA applet instead of a .desktop file, when generating a file on the desktop (and only on the desktop). Obviously that's only useful on OS X, which has AppleScript. The main thing left to do is that I'd like to have to hard coded default determined by configure instead, with an option to set it. I didn't find any other code in configure.ac doing such a thing though, so I'm unsure how and if it should be done. I'm also unsure if it's ok to use posix_spawnp. I chose that function because as far as I can tell spawnvp does not allow me to send data to stdin, and popen requires the argument to be escaped, which seems unnecessary. You'll also notice that I include a few environment variables in the applet. That's because by default applications launched on OS X will only have /bin:/usr/bin as path and only look for libraries in /usr/lib. That's not typical locations for wine on OS X and if the paths are not set the applet is unlikely to find the wine binaries. The final point which should be considered is the copying of the icon file from /tmp to the location inside the applet. A more proper way is perhaps to generate the icon file in the correct place in the first place, but doing that requires rather large changes to the code, and this way was much more simple. Any feedback is appreciated, -- Per Johansson Ps. If someone tries to apply it you'll probably get a conflict around line 3065 since the patch currently assumes that my other patch[1] to winemenubuilder is already applied. [1] http://www.winehq.org/pipermail/wine-patches/2011-August/105396.html

1 0

Assining .bat and .com files with the desktop
by Nowres Rafid 15 Aug '11

15 Aug '11

I propose to associate .bat and .com files with wine's cmd in GNOME, KDE and others

7 9

Wine Gecko 1.3-beta1
by Jacek Caban 14 Aug '11

14 Aug '11

Hi all, I've just uploaded a new Wine Gecko beta package. It's a bit earlier than we usually updated the package, but it's part of the plan. The last release was the most successful ever - we've successfully avoided regressions and fixed existing bugs. The fact that we had long (over month) beta period and that the release was made based on stable Firefox release helped a lot IMO. We can improve stability of Gecko package by releasing more often, meaning less changes are included in each single release. We can do this thanks to Mozilla rapid release cycles, that gives us a chance to release Wine Gecko based on the very recent code base, stabilized by Mozilla every six weeks. Six weeks releases are, however, more than we can handle and more than we need, so my current plan is to release every two Firerox version (that is every 12 weeks), with no pressure. Back to current release, it's mostly an update of code base to keep on track with Gecko changes. Builds are available, as usually, on sourceforge [1]. To test it, you also need the attached patch to Wine. Any help with testing is appreciated. Everything that uses MSHTML in any way is worth testing. Informations for packages interested in building the package themselves: My builds are done with GCC 4.5.3, but any GCC newer than 4.5.1 should be good. There was a fix to Mozilla code needed for GCC 4.6.* builds that I've included in the source, so GCC 4.6 32-bit builds should be fine. If you want to use it for 64-bit builds, please test it carefully as I wasn't able to test them (linking GCC 4.6 builds consumes awfully lot of memory, so it failed for me). Cheers, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.3-beta1/

1 1

setting up a wine buildbot
by Dan Kegel 14 Aug '11

14 Aug '11

I've been experimenting with buildbot lately, and confirmed that it can be used to implement a wine patchwatcher. A proof-of-concept script is at http://code.google.com/p/winezeug/source/browse/trunk/buildbot/winebuildbot… It's running on my laptop now; I'll try to put it on a more stable box when I get home from vacation.

1 0