August 2011 - Wine-devel - list.winehq.org

dinput8 GSoC wrapup
by Lucas Zawacki 20 Aug '11

20 Aug '11

Hey everyone, just sending you this email to give a heads up about the status of my GSoC project. I set out to implement the action mapping features of DirectInput8, what I have now is: * EnumDevicesBySemantics: Fully implemented * SetActionMap: Fully implemented * BuildActionMap: Fully implemented with the exception of loading previous saved configurations. * ConfigureDevices: Functional but still needs more functionalities and some polishment The patches that I accumulated this last 2 weeks and will start to commit as of this next monday are here: * https://gist.github.com/1146808 * https://gist.github.com/1154946 * https://gist.github.com/1159426 * https://gist.github.com/1159498 I'll keep working on the stuff that's missing to have the fully functional action mapping, also I have to commit some documentation and make some cleaning of the code. By the way one nice thing I discovered this last weeks is that we may even be able to use what MSDN calls "vendor defined mappings" and, for instance, have a wheel or other exotic joystick perfectly mapped to the application. What I'll need for this is implementing loading of saved configurations, the device "Vendor ID/Product ID" property and access to the mapping files deployed with a DirectX installation (maybe we could download them with winetricks?). All in all, I'd like to thank you all for helping me trough this project, especially Marcus Meissner and Vitaliy Margolen for reading my patches and giving invaluable advice :)

1 0

random flakiness
by Dan Kegel 20 Aug '11

20 Aug '11

When running a test bot, one notices flaky things that otherwise happen too seldom to be noticed. For instance, today, the buildbot crashed once during wineboot: wine: created the configuration directory '/home/dank/wineslave.dir/sandbox/slave/runtests/build/wineprefix' fixme:storage:create_storagefile Storage share mode not implemented. err:mscoree:LoadLibraryShim error reading registry key for installroot ... err:mscoree:LoadLibraryShim error reading registry key for installroot fixme:iphlpapi:NotifyAddrChange (Handle 0x83e8ec, overlapped 0x83e8d0): stub wine: Unhandled page fault on write access to 0x00000000 at address 0x7d8eb051 (thread 0010), starting debugger... err:process:__wine_kernel_init boot event wait timed out When I got home, the crash dialog was still up. ps says the app that crashed was: C:\windows\system32\rundll32.exe setupapi,InstallHinfSection DefaultInstall 128 \\?\unix/home/dank/wineslave.dir/sandbox/slave/runtests/build/tools/wine.inf There have been several other random little failures, e.g. http://bugs.winehq.org/show_bug.cgi?id=28108, http://bugs.winehq.org/show_bug.cgi?id=28133 I guess I'll just grit my teeth and ignore these until they happen more than once, then try to file useful bugs about them. Who knows, maybe it's my system. - Dan

1 0

Re: mshtml: Use wininet to get and parse the proxy
by Dmitry Timoshkov 20 Aug '11

20 Aug '11

André Hentschel <nerv(a)dawncrow.de> wrote: > + if(!InternetCrackUrlA(pi->lpszProxy, 0, 0, &UrlComponents)) return; > + heap_free(pi); If InternetCrackUrlA() fails pi is leaked. -- Dmitry.

1 0

Re: [1/2] cmd: fixing an issue with extra whitespaces after cd parameter (retry2)
by Frédéric Delanoy 20 Aug '11

20 Aug '11

On Fri, Aug 19, 2011 at 02:46, Nowres Rafid <nowres.rafed(a)gmail.com> wrote: > else { + pos = string; /* Remove any double quotes, which may be in the middle, eg. cd "C:\Program Files"\Microsoft is ok */ - pos = string; > That's a gratuitous change while (*command) { if (*command != '"') *pos++ = *command; command++; } *pos = 0x00; + /* Remove any whitespace at the end of command + This was because "cd .. " wasn't working */ + pos--; + while ( *pos == ' ' || *pos == '\t' ) + *pos-- = 0x00; + You don't need to alter the string more than necessary. I would do sthg like while (*command) { if (*command != '"') *pos++ = *command; command++; } + pos--; + while (*pos == ' ' || *pos == '\t') pos--; *pos = 0x00;

1 0

Re: [2/2] cmd/tests: fixing an issue with extra whitespaces after cd parameter (retry)
by Frédéric Delanoy 20 Aug '11

20 Aug '11

You should use @space@ elements to make the tests clearer. Also, you shouldn't use (retry) in your patch mail subject, but rather (try N)

1 0

What gstreamer plugins are actually needed?
by Scott Ritchie 19 Aug '11

19 Aug '11

I'm trying to cleanup a bit of a packaging mess whereby Wine currently pulls in 250 or so gstreamer plugins. Which ones are actually useful for applications? Do we even know? Thanks, Scott Ritchie

2 1

Buildbot status
by Dan Kegel 19 Aug '11

19 Aug '11

http://buildbot.kegel.com/ caught a couple of real problems today. Remember the original patchwatcher? It died because only one person knew how to run it, and it was too hard to set up. I'm trying to not make that mistake this time. To that end, I've made the process easier, and would like as many people as possible to try running buildbot slaves (and, at least temporarily, masters!) so the knowledge is spread around. It's probably ready for other people to try running one. If you're interested, see http://code.google.com/p/winezeug/source/browse/trunk/buildbot/readme-wine.… Changes since last post - made cleaner script and doc for adding a new slave - rewrote patch series recognizer (old one was broken and opaque) to-do list: - make it start automatically after reboot - sandbox it - turn on build result emails - add a bit of parallelism into the test runner, so e.g. tests that don't need the display or network run in parallel with those that do, probably in a separate wineprefix - add valgrind slave - add windows slave (like testbot, but with real graphics and sound) - add x86_64 slave - move master to winehq.org once it seems ready

3 5

re: regedit: adding confirmation message before importing from file
by Dan Kegel 19 Aug '11

19 Aug '11

Hi Nowres, did you run the regedit tests, cd programs/regedit/tests make test after that change? Here it fails with regedit.c:384: Test failed: regedit not available, skipping regedit tests ( log at http://buildbot.kegel.com/builders/runtests/builds/2 ) You might need to fully implement the /S switch for regedit and use it from the tests before you can add the confirmation dialog to regedit. - Dan

2 3

Only use D3DLOCK_DISCARD if dynamic memory (was Re: d3dx9: CloneMesh test and improvements)
by Michael Mc Donnell 19 Aug '11

19 Aug '11

On Fri, Aug 19, 2011 at 2:20 PM, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > Am 19.08.2011 um 14:04 schrieb Michael Mc Donnell: >> Ok I see that in dlls/d3d9/tests/buffers.c. So it will fail to lock on >> Win7 if D3DLOCK_DISCARD is specified and the vertex buffer wasn't >> created with D3DUSAGE_DYNAMIC? > Yes, unless Microsoft changed this again. > >> Am I correct in D3DLOCK_DISCARD makes a copy of the vertex buffer so >> that the video card can keep reading the old one, and the old vertex >> buffer memory is released after the video card releases its lock [1]? > Sort of. It doesn't copy the old data, it just gives you a fresh, uninitialized block of memory. So if you read from the pointer you get from a DISCARD lock you'll get garbage. > >> In that case it does not make sense to use D3DLOCK_DISCARD at all in >> CloneMesh, as the video card has not begun to use the new vertex >> buffer, and it will just add memory overhead. The easiest fix would be >> to just pass 0 instead of D3DLOCK_DISCARD. I've done that in the >> updated patch. > Right, the buffer is newly created in CloneMesh. Just not using DISCARD is the best fix then. > >>> I noticed a few more D3DLOCK_DISCARD locks in the mesh.c code. >> >> I guess the other methods should check the mesh options for >> D3DXMESH_DYNAMIC, D3DXMESH_VB_DYNAMIC, and D3DXMESH_IB_DYNAMIC [2] >> before using D3DLOCK_DISCARD? I'll write patches for those. > Most likely yes. I haven't looked at the details. If the buffer is new in those situations as well just don't pass any flags, otherwise pass DISCARD if you lock a dynamic buffer and are going to rewrite the entire buffer contents. All of the places with D3DLOCK_DISCARD in mesh.c were working on newly created meshes or vertex buffers, so they should all pass 0. I've attached patches for it.

1 0

re: shlwapi: Put correct return values in SetFromTimeInterval
by Dan Kegel 19 Aug '11

19 Aug '11

(The buildbot worked its way back to the day after Alexandre went on vacation. Even though the patches are old, git hasn't changed, so they ought to apply still.) It didn't apply here: patching file dlls/shlwapi/string.c patching file dlls/shlwapi/tests/string.c Hunk #1 FAILED at 622. Hunk #2 FAILED at 639. Hunk #3 FAILED at 649. 3 out of 3 hunks FAILED -- saving rejects to file dlls/shlwapi/tests/string.c.rej Log at http://buildbot.kegel.com/builders/runtests/builds/80 for the next day or so.

1 0