August 2011 - Wine-devel - list.winehq.org

Re: [5/5] shlwapi/tests: Test return value of StrFromTimeInterval with cchMax set to 0 (try2)
by Marvin 06 Aug '11

06 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13371 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [4/5] shlwapi/tests: Test for an unchanged buffer when cchMax=0 in StrFromTimeInterval
by Marcus Meissner 06 Aug '11

06 Aug '11

On Sat, Aug 06, 2011 at 06:54:48AM -0700, Scott Ritchie wrote: > --- > dlls/shlwapi/tests/string.c | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > > diff --git a/dlls/shlwapi/tests/string.c b/dlls/shlwapi/tests/string.c > index 68028d7..ecc58cc 100644 > --- a/dlls/shlwapi/tests/string.c > +++ b/dlls/shlwapi/tests/string.c > @@ -615,6 +615,14 @@ static void test_StrFromTimeIntervalW(void) > result->return_value, ret); > ok(!strcmp(result->time_interval, szBuff), "Formatted %d %d wrong\n", > result->ms, result->digits); > + > + /* Test with 0 parameter, this should not change the buffer */ > + MultiByteToWideChar(0,0,"dontchange",-1,szBuffW,sizeof(szBuffW)); /sizeof(szBuffW[0]) missing. Ciao, Marcus

2 1

Re: configure: Disable gstreamer support if headers are not compatible with build environment. (try 2)
by Alex Villacís Lasso 06 Aug '11

06 Aug '11

El 02/08/11 17:38, Octavian Voicu escribió: > When building a 32-bit wine in a 64-bit build environment with > default glib headers (gstreamer uses glib.h), glib 64-bit types > (such as gint64 and guint64) are not properly defined, causing > many compiler warnings and most likely a broken winegstreamer.dll. > > Although both gstreamer and glib are included in the ia32-libs > package (on Ubuntu, and possibly others), the lack of a proper > glibconfig.h makes the gstreamer headers unusable for 32-bit > builds. My build system is a Fedora 14 x86_64, and I am affected by this. What is really happening is that, on my 64-bit system, both glib2-devel.i686 and glib2-devel.x86_64 are installed: [alex(a)srv64 wine-build]$ rpm -qf /usr/lib64/glib-2.0/include/glibconfig.h glib2-devel-2.26.0-2.fc14.x86_64 [alex(a)srv64 wine-build]$ rpm -qf /usr/lib/glib-2.0/include/glibconfig.h glib2-devel-2.26.0-2.fc14.i686 [alex(a)srv64 wine-build]$ Instead of shipping a single header file that uses compiler or preprocessor defines, like /usr/include/stdint.h, glib2 ships two include files, one for each architecture. The pkg-config --cflags option does not handle the concept of an architecture-dependent include file correctly (or at all), so it ends up reporting the 64-bit header even for the 32-bit build. The 32-bit header defined gint64 as signed long long, but it is defined as signed long in the 64 bit header. Therefore the bug. A workaround I am testing is to force PKG_CONFIG_PATH to the 32-bit directory for the configure and make steps: [alex(a)srv64 wine-build]$ pkg-config --cflags gstreamer-app-0.10 -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libxml2 [alex(a)srv64 wine-build]$ PKG_CONFIG_PATH=/usr/lib/pkgconfig pkg-config --cflags gstreamer-app-0.10 -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 [alex(a)srv64 wine-build]$ Is there any standard/known way of automating this?

2 2

Re: [PATCH] gdi32: Avoid uninitialized fields in dst and src (Coverity)
by Octavian Voicu 06 Aug '11

06 Aug '11

On Sat, Aug 6, 2011 at 1:06 PM, Marcus Meissner <marcus(a)jet.franken.de>wrote: > src.visrect.left = src.x = 0; > src.visrect.top = src.y = 0; > These two lines become redundant after your patch. Octavian

1 0

Re: [2/2] user32: When destroying a window, preserve the first WM_QUIT message that was posted to it.
by Marvin 05 Aug '11

05 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13345 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Vacation
by Alexandre Julliard 05 Aug '11

05 Aug '11

Folks, There won't be any commits for a while, since I'll be on vacation for the next two weeks. Also release 1.3.27 will be 3 weeks from now instead of 2. I hope you can all survive the commit withdrawal... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: Implement K32GetProcessImageFileNameA().
by Marvin 05 Aug '11

05 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13315 Your paranoid android. === WVISTAADM (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=100 === W2K8SE (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=100 === W7PRO (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=96 === W7PROX64 (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=108

3 2

Re: [PATCH 1/3] ntdll: NtCancelIoFile(Ex) enters a nonaleratable wait state instead of an alertable one, this allows system apcs to run but blocks user apcs
by Alexandre Julliard 05 Aug '11

05 Aug '11

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > --- > dlls/ntdll/file.c | 4 ++-- > dlls/ntdll/tests/file.c | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) The whole point of the wait is to run user APCs... -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] kernel32: Create(Named)Pipe uses an nonalertable io mode
by Alexandre Julliard 05 Aug '11

05 Aug '11

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > @@ -37,7 +37,11 @@ > static HANDLE alarm_event; > static BOOL (WINAPI *pDuplicateTokenEx)(HANDLE,DWORD,LPSECURITY_ATTRIBUTES, > SECURITY_IMPERSONATION_LEVEL,TOKEN_TYPE,PHANDLE); > +static DWORD WINAPI (*pQueueUserAPC)(PAPCFUNC pfnAPC, HANDLE hThread, ULONG_PTR dwData); > > +static void CALLBACK user_apc(ULONG_PTR param) > +{ > +} That doesn't really test anything. You should check if it's being called in various places. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/2] wscript: skip some tests on wow64 (resend)
by Michał Ziętek 05 Aug '11

05 Aug '11

I skipped them because of filesystem redirection on wow64 which makes GetSystemDirectory and SearchPath return the wrong values. How can I solve this problem?

2 1