August 2011 - Wine-devel - list.winehq.org

Re: Assorted spelling fixes.
by Frédéric Delanoy 04 Aug '11

04 Aug '11

On Wed, Aug 3, 2011 at 11:36, Francois Gouget <fgouget(a)free.fr> wrote: > diff --git a/programs/cmd/tests/test_builtins.cmd b/programs/cmd/tests/test_builtins.cmd > index eb79fb2..be1eead 100644 > --- a/programs/cmd/tests/test_builtins.cmd > +++ b/programs/cmd/tests/test_builtins.cmd > @@ -530,7 +530,7 @@ mkdir foobar > rd foobar > echo %ErrorLevel% > if not exist foobar echo dir removed > -rem Removing non-existent directory > +rem Removing nonexistent directory > rmdir foobar > echo %ErrorLevel% > rem Removing single-level directories There is apparently no hard rule on the usage of hypens between 'non' and a subsequent adjective, but I've seen lots of "non-" (sometimes even "non ") so I wouldn't call that a spelling error. Furthermore, the "non-" form is more readable IMHO Frédéric

4 3

Re: dlls/tests: Assorted spelling fixes
by Frédéric Delanoy 04 Aug '11

04 Aug '11

The errors reported by testbot are not related to this patch. Should I resent a version without the "failing" hunks? Frédéric

1 0

Re: [PATCH 1/2] comctl32: Fix to ComboBoxEx processing of WM_ENABLE message (try 2)
by Marvin 04 Aug '11

04 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13267 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: dlls/tests: Assorted spelling fixes
by Marvin 04 Aug '11

04 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13256 Your paranoid android. === WNT4WSSP6 (32 bit shlfileop) === shlfileop.c:2210: Test failed: SHGetNewLinkInfoA succeeded

1 0

Re: dlls/tests: Assorted spelling fixes
by Marvin 04 Aug '11

04 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13249 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3046: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3046: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3046: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3046: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3122: Test failed: Creating WebBrowser object failed: 80040154

1 0

Re: dlls/tests: Assorted spelling fixes
by Marvin 03 Aug '11

03 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13236 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout === WVISTAADM (32 bit win) === win.c:1157: Test failed: first call to SetShellWindow(hwnd1) win.c:1159: Test failed: wrong shell window: 0002010E win.c:1196: Test failed: SetShellWindow(hwnd4) win.c:1198: Test failed: wrong shell window: 0002010E - expected hwnd4 win.c:1201: Test failed: wrong next window for hwnd4: 000200EE - expected 0 win.c:1212: Test failed: wrong shell window: 0002010E - expected hwnd4 win.c:1222: Test failed: wrong next window for hwnd4 after SetWindowPos(): 000200EE - expected 0

1 0

Re: cmd: mkdir: complain properly if no arg given (resending)
by Frédéric Delanoy 03 Aug '11

03 Aug '11

On Thu, Aug 4, 2011 at 00:21, Dan Kegel <dank(a)kegel.com> wrote: > Also output the error to stderr, as native does. > > Resending to make testbot happy (first time the odd numbering confused it). You should probably send the WCMD_output_stderr implementation as a separate patch, since it's not mkdir-specific Frédéric

1 0

Re: oleaut32/tests: Skip tests if typelib can't be registered
by Octavian Voicu 03 Aug '11

03 Aug '11

2011/8/3 André Hentschel <nerv(a)dawncrow.de> > a80a90fcb7f917ef4ec999007f5a49eb63d1b0a6 > Doesn't look like a valid commit... which one is that? Octavian

2 1

Re: net: Convert to Unicode. (take 2)
by Francois Gouget 03 Aug '11

03 Aug '11

On Wed, 3 Aug 2011, Francois Gouget wrote: [...] > I sort of modeled this after ipconfig's ipconfig_vprintfW() function. > However that function has a WriteFile() fallback in case WriteConsole() > fails. But I don't see what's the point of this or when using > WriteFile() instead of WriteConsole() would work. So I'm hoping someone > can enlighten me as I see no reason for these two tools to handle things > so differently. But in any case I see this as being the subject of a > separate patch so I think this one can go in. So I think I figured that part out. If I write a simple test application that just does a WriteConsoleW() call and run it on Windows XP SP3, I get the following: * foo.exe -> Works. * foo.exe >foo.txt -> WriteConsoleW() fails, foo.txt is empty. * foo.exe | more -> WriteConsoleW() fails, the message is lost. So ipconfig must have been written so that it works on Windows even if its output is redirected. In Wine applications don't need to fall back to WriteFile() because that's already done by WriteConsoleW(). So the question is: Do we care if these applications don't work right on Windows if their output is redirected? Or from a different point of view: Should these applications take advantage of this Wine-specific behavior or stick to the letter of the API? (Similarly Wine's WriteConsole() will accept a NULL lpNumberOfCharsWritten parameter, not Windows (up to XP SP3 at least). So if we decide our apps are Wine-only, then we could get rid of these annoying 'count' variables.) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95

2 2

NtQuerySystemInformation and exposing unix_pid
by Paul Vriens 03 Aug '11

03 Aug '11

Hi, I would like to add some per-process information in NtQuerySystemInformation with respect to cpu-usage. The wine server doesn't currently expose the unix_pid so I can't use /proc/<pid>/* information. Would it be ok to expose the unix_pid in some of the server calls (like next_process)? Or should all this information (and the /proc handling) go into the server? -- Cheers, Paul.

2 2