May 2012 - Wine-devel - list.winehq.org

Installing 64 bit visual c++ 2010 runtime?
by Dan Kegel 17 May '12

17 May '12

I'd like to try a real 64 bit app, so on a 64 bit Ubuntu 12.04, I tried sudo apt-get install wine rm -rf ~/.wine export WINEARCH=win64 wget http://download.microsoft.com/download/3/2/2/3224B87F-CFA0-4E70-BDA3-3DE650… wine vcredist_x64 and that installs fine... but only puts anything in c:\windows\syswow64, and the 64 bit app I'm trying is rather upset that it can't find mfc100.dll. The log it writes into c:\users\$LOGNAME\*.html says (if you look at the source, or click 'verbose' in a web browser) "platform not supported". This happens even if I use winecfg to set win7 mode. Happily, it looks like one can just grab the file from the .cab with something like this: mkdir foo cd foo cabextract ../vcredist_x64.exe cabextract vc_red.cab cp F_CENTRAL_mfc100_x86 ~/.wine/windows/system32 cd .. rm -rf foo That gets the app I'm trying to the point where it needs a newer builtin vcrun100, http://source.winehq.org/git/wine.git/?a=commit;h=6cb3713e26aa4d89d4dc67601… which is great. (Now I just have to get around to following up on previous posts about how to build biarch wine on ubuntu 12.04.) But I still wonder why the installer doesn't want to install the 64 bit files.

1 1

Re: comctl32: When created with TCS_VERTICAL, TCS_MULTILINE is set automatically
by Stefan Leichter 17 May '12

17 May '12

Thursday 17 May 2012 Nikolay Sivov <nsivov(a)codeweavers.com> > - DWORD dwStyle; > + DWORD style; Any reason for changing the name?

2 1

Re: kernel32: check the last parameter of K32EnumProcessModules for NULL before use (with test)
by Nikolay Sivov 17 May '12

17 May '12

On 5/17/2012 11:46, Stefan Leichter wrote: > SetLastError(0xdeadbeef); > + pEnumProcessModules(hpQI,&hMod, sizeof(HMODULE), NULL); > + ok(GetLastError() == ERROR_ACCESS_DENIED, "expected error=ERROR_ACCESS_DENIED but got %d\n", GetLastError()); > + > + SetLastError(0xdeadbeef); > + ret = pEnumProcessModules(hpQV,&hMod, sizeof(HMODULE), NULL); > + ok(!ret, "succeeded\n"); > + ok(GetLastError() == ERROR_NOACCESS, "expected error=ERROR_NOACCESS but got %d\n", GetLastError()); > + Why don't you check return value from the first call?

2 1

Re: [appdb] Applications working flawlessly using patched wine should be rated Gold
by K.King 17 May '12

17 May '12

<< A "runs well with patched wine" checkbox might be useful, but would be very confusing. Maybe if it forced the rating to be garbage that would be ok. >> If it was possible my preference would be to be able to see separate rating per vanilla and per non vanilla. The per vanilla should be first and more obvious. If I see a rating of Garbage infers even with patching it would not run? problem with "runs well with patched wine" is it's an on or off, whereas you could start wishing for an indication of how well it can be made to run? Keeping the steps, results, capabilities, not tested, etc for patched wine could/should maybe be kept quite separate to the quick and obvious vanilla out of box results section? K.

1 0

kernel32: Correct WideCharToMultiByte and MultiByteToWideChar error codes and conditions
by Alex Henrie 16 May '12

16 May '12

Hello, This patch was marked committed yesterday--thank you for accepting it!--but it still isn't showing up in Git. Maybe it was accidentally skipped? It needs to be committed before I can submit the UTF-7 implementation I wrote that builds on it. -Alex

2 1

AppDB, ratings and native vs. builtin trouble
by Alexey Loukianov 16 May '12

16 May '12

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Good day to all subscribers of this list, I've got a small decision trouble I have to deal with as an AppDB maintainer. I know that years ago there had been discussion on this topic, but I want to bring this once on a surface once again so we would get a fresh modern look an thus minor problem. As we all know, Wine isn't perfect, thus applications often require native DLLs to behave properly. AppDb treats such cases as being "Gold" rating. It's easy to distinguish between "Platinum" and "Gold" case most of the time, but sometimes there are cases where native dll overrides happen automagically as a result of app installed installing third-party lib redists himself. Good example is idSoftware's Rage game which require XAudio2 to functions - which is not implemented in Wine. User would have to install and use native lib for game to function, but most of the times it would be done automatically by Steam (its "auto-install required libs" feature would try to install DirectX redist at the first time user would try to launch the game). How should we treat situations like that? From user PoV it's "Platinum" - app is working out of the box. From real side of things - it is "Gold", as native dll override is required for app to function - Wine's stubbed xaudio2 implementation is obviously not enough for game to work. With the recent release of Diablo III we're are at the same spot: game installer auto-installs vcrun2008 redist as a part of installation process, so end-user experience is like this game "works out of a box". Problem is that D3 installed isn't working unless user patches Wine's AcceptEx implementation with Erichs patchset, so for vast majority of Wine's userbase installing D3 would be something like "copy already installed D3 from other PC" - and that would bring the problem of the game requiring native VC++ 2008 runtime on the surface. How should we treat/assign ratings for these cases? P.S. Aside from that, I want to once again bring up the discussion on extending AppDB so more detailed test reports would be possible. IMO it might be reasonable to add to AppDB test report form is an ability to specify whether the version used was "vanilla" or "patched with some out-of-tree patches" one. For most reporters sane default would be "vanilla", while at some circumstances most of the test reports would come for "patched" version: good examples are SW:KOTR, WoT, D3 and many other games that require out-of-tree patches to function best under Wine. Thanks for spending your time reading this, and thanks in advance for your answers. - -- Best regards, Alexey Loukianov mailto:mooroon2(a)mail.ru System Engineer, Mob.:+7(926)218-1320 *nix Specialist -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPs34GAAoJEPB9BOdTkBUL5KMH+gOtjQv1ckZ4tZ9X+kysZ/+0 gM1uCSHvuUdHuY+aVlUs688NU76mJcUu+ORPSuMrdltm7BCn5DbAN3ITjMSf2Y7y KHvvDFbGcKkiDupCyQhdNHpEyfC3PFzWjuI7o8nG/2eZGum5zRwGdbgvDvSc2Qo1 md208/6WDAGNjN2943orolG5pqhKapDvjvpoKSavgW1ykHeKDiTvCiNKXvcRU2ox bRZomHY93DNV0RoLnExcp8HnA/DooWQdGfwF4uTp+wgmIbwbWM4iw3Zw5CuXim+6 VzetXUPU9iVr2h3xqBgmVq5a7rMri7mykDXACo7ex30ekWM9XQBqSgT0jxqIi14= =16iP -----END PGP SIGNATURE-----

3 6

Re: [1/2] wmvcore: Add stub for WMCreateSyncReader (try 2) (resend)
by Nikolay Sivov 16 May '12

16 May '12

On 5/16/2012 19:46, André Hentschel wrote: > + wmsdkidl.idl \ > + wmsbuffer.idl \ This is supposed to be sorted. Also I think you need to add .gitignore changes as well.

1 0

RE: localspl: Only store the file part of the filenames in the registry
by Detlef Riekenberg 16 May '12

16 May '12

Hi Huw. We have only filenames in the registry. The current code works fine with the adobe postscript driver and various other driver for PDF printers. Which native driver makes problems? Why do you add spaces before and after the the function args and change idention, bracket style and variable names everywhere in the patch? HP is using a subdirectory for some driver files, but i can't remember the driver name at the moment. -- By by ... Detlef

2 1

re: AppDB, ratings and native vs. builtin trouble
by Dan Kegel 16 May '12

16 May '12

16.05.2012 17:34, Rosanne DiMesio wrote: > If the user didn't have to manually do anything, it should be rated > platinum. Agreed. appdb ratings are from the point of view of someone who simply uses their linux distro to install wine, and then tries to install a game. If no fiddling is required, and the game works perfectly, it's platinum even if under the hood the game has snuck in a native (and Microsoft-copyrighted) DLL. (DLLs not copyrighted by Microsoft are not generally a concern.) In parallel, people who care about making Wine run without any native DLLs should make sure there's a "purist" bug in wine's bugzilla describing what breaks if you force wine to use its own builtin DLL for the game. (And should then try to fix that bug. :-) - Dan

2 1

Re: [2/2] gdiplus: Implement GdipImageGetFrameCount and GdipImageSelectActiveFrame.
by Vincent Povirk 16 May '12

16 May '12

Er, you removed the FIXME, but GdipImageSelectActiveFrame is still a stub? You're not changing the image data.

2 1