May 2012 - Wine-devel - list.winehq.org

Re: [PATCH 2/2] ieframe: Added GetExternal tests
by Marvin 16 May '12

16 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18421 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3280: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3280: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3280: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3280: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3402: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3377: Test failed: Could not get WebBrowserV1 instance: 80040154 webbrowser: unhandled exception c0000005 at 0040AE8E === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2594: Test failed: expected GetOverridesKeyPath webbrowser.c:2599: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2600: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3019: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402FCA

1 0

Re: mstask: Actually run a test and fix the expected behaviour.
by Marvin 16 May '12

16 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18419 Your paranoid android. === WNT4WSSP6 (32 bit task_trigger) === task_trigger.c:165: Test failed: Failed to setup test_task

2 1

Re: [1/2] comctl32/tests: Added tests for treeview right mouse click handling
by Nikolay Sivov 16 May '12

16 May '12

On 5/15/2012 22:53, Daniel Jelinski wrote: > > > + PostMessageA(hTree, WM_RBUTTONUP, 0, (LPARAM)0x10001); > + /* this sequence should NOT send WM_CONTEXTMENU */ > + SendMessageA(hTree, WM_RBUTTONDOWN, 2, (LPARAM)0x10001); Please use defined names for wParam and a MAKELPARAM macro to make a coordinate dword. > + test_mouse(); Also this deserves a more descriptive name, something like test_rbutton().

1 0

Re: mstask: Actually run a test and fix the expected behaviour.
by Marvin 16 May '12

16 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18419 Your paranoid android. === WNT4WSSP6 (32 bit task_trigger) === task_trigger.c:165: Test failed: Failed to setup test_task

1 0

Re: mstask/tests: Add missing call to the tested function.
by Marvin 16 May '12

16 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18417 Your paranoid android. === WNT4WSSP6 (32 bit task_trigger) === task_trigger.c:165: Test failed: Failed to setup test_task === W2KPROSP4 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === WXPPROSP3 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W2K3R2SESP2 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === WVISTAADM (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W2K8SE (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W7PRO (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W7PROX64 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === TEST64_W7SP1 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W7PROX64 (64 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === TEST64_W7SP1 (64 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000

1 0

Re: [PATCH] devenum: Do not fail with a IBindCtx (with tests)
by Dmitry Timoshkov 16 May '12

16 May '12

Detlef Riekenberg <wine.dev(a)web.de> wrote: > static HRESULT WINAPI DEVENUM_IMediaCatMoniker_BindToStorage(IMoniker *iface, IBindCtx *pbc, > IMoniker *pmkToLeft, REFIID riid, void **ppvObj) > { > + static IBindCtx *old_bc; > MediaCatMoniker *This = impl_from_IMoniker(iface); > > TRACE("(%p)->(%p, %p, %s, %p)\n", This, pbc, pmkToLeft, debugstr_guid(riid), ppvObj); > > *ppvObj = NULL; > > - if (pbc || pmkToLeft) > + if (pbc != old_bc) > + { > + FIXME("ignoring IBindCtx %p\n", pbc); > + old_bc = pbc; > + } This doesn't look sane. -- Dmitry.

1 0

wine/clang warnings
by Austin English 15 May '12

15 May '12

Howdy, I tried Wine with LLVM/Clang from svn recently, thought others may like some of the results. I've also ran the static analyzer. For reference, this is with: wine-1.5.4-61-g8327e6f, plus the following patch: diff --git a/include/windef.h b/include/windef.h index 9cf98e7..e95388a 100644 --- a/include/windef.h +++ b/include/windef.h @@ -53,7 +53,7 @@ extern "C" { #ifndef __stdcall # ifdef __i386__ # ifdef __GNUC__ -# ifdef __APPLE__ /* Mac OS X uses a 16-byte aligned stack and not a 4-byte one */ +# if defined (__APPLE__) || defined (__clang__) /* Mac OS X uses a 16-byte aligned stack and not a 4-byte one */ # define __stdcall __attribute__((__stdcall__)) __attribute__((__force_align_arg_pointer__)) # else # define __stdcall __attribute__((__stdcall__)) see http://wiki.winehq.org/Clang for more info. Wine was compiled using: #!/bin/bash export CC="clang" export CXX="$CC" export CFLAGS="-g -O0 -std=gnu89 -Wno-conversion -Wno-invalid-source-encoding" ./configure -Wno-invalid-source-encoding, because clang does not like our encoding of strings in winex11/keyboard.c. There are 851 warnings of: clang -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -I/usr/include/freetype2 -g -O0 -std=gnu89 -Wno-conversion -o keyboard.o keyboard.c keyboard.c:267:17: warning: illegal character encoding in string literal [-Winvalid-source-encoding] "`","1!","2\"","3<A3>","4$","5%","6^","7&","8*","9(","0)","-_","=+", The static analyzer found 2231 bugs (--disable-tests was used). http://www.sendspace.com/file/qsbv3k austin(a)aw21 ~ $ du -h scan-build-2012-05-15-2.tar.bz2 42M scan-build-2012-05-15-2.tar.bz2 austin(a)aw21 ~ $ sha1sum scan-build-2012-05-15-2.tar.bz2 442cf6faddb45515792d116717c992282496dfbe scan-build-2012-05-15-2.tar.bz2 Cheers, Austin

1 0

Re: comctl32: Fix message sequence when right-clicking a treeview
by Nikolay Sivov 15 May '12

15 May '12

On 5/15/2012 21:30, Daniel Jelinski wrote: > Patch dropped out of the pending list, resending. Please add a test for this fix.

2 2

Re: [PATCH 1/3] user32: Added GetMenuBarInfo implementation (try2)
by Alexandre Julliard 15 May '12

15 May '12

Piotr Caban <piotr(a)codeweavers.com> writes: > This patch serie is based on Andrew Eikum's and Rein Klazes's work. > --- > dlls/user32/menu.c | 94 > ++++++++++++++++++++++++++++++++++++++++++++++++---- > 1 files changed, 87 insertions(+), 7 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok msg.c:11511: Tests skipped: Skipping DBCS WM_CHAR test in SBCS codepage 'ANSI Latin 1' msg.c:12297: Test failed: popup menu command: 17: the msg 0x011f was expected, but got msg 0x0004 instead msg.c:12297: Test failed: popup menu command: 18: the msg 0x0212 was expected, but got msg 0x011f instead msg.c:12297: Test failed: popup menu command: 19: the msg 0x0126 was expected, but got msg 0x0212 instead msg.c:12297: Test failed: popup menu command: 21: the msg 0x0101 was expected, but got msg 0x0126 instead msg.c:12297: Test failed: popup menu command: 22: the msg sequence is not complete: expected 0000 - actual 0101 msg.c:12315: Test failed: submenu of a popup menu command: 22: the msg 0x0004 was expected, but got msg 0x0125 instead msg.c:12315: Test failed: submenu of a popup menu command: 23: the msg 0x0125 was expected, but got msg 0x0004 instead msg.c:12315: Test failed: submenu of a popup menu command: 26: the msg 0x011f was expected, but got msg 0x0004 instead msg.c:12315: Test failed: submenu of a popup menu command: 27: the msg 0x0212 was expected, but got msg 0x011f instead msg.c:12315: Test failed: submenu of a popup menu command: 28: the msg 0x0126 was expected, but got msg 0x0212 instead msg.c:12315: Test failed: submenu of a popup menu command: 30: the msg 0x0101 was expected, but got msg 0x0126 instead msg.c:12315: Test failed: submenu of a popup menu command: 31: the msg sequence is not complete: expected 0000 - actual 0101 msg.c:12363: Test failed: submenu of a popup menu command: 22: the msg 0x0004 was expected, but got msg 0x0125 instead msg.c:12363: Test failed: submenu of a popup menu command: 23: the msg 0x0125 was expected, but got msg 0x0004 instead msg.c:12363: Test failed: submenu of a popup menu command: 26: the msg 0x011f was expected, but got msg 0x0004 instead msg.c:12363: Test failed: submenu of a popup menu command: 27: the msg 0x0212 was expected, but got msg 0x011f instead msg.c:12363: Test failed: submenu of a popup menu command: 28: the msg 0x0111 was expected, but got msg 0x0212 instead msg.c:12363: Test failed: submenu of a popup menu command: 30: the msg 0x0101 was expected, but got msg 0x0111 instead msg.c:12363: Test failed: submenu of a popup menu command: 31: the msg sequence is not complete: expected 0000 - actual 0101 make[1]: *** [msg.ok] Error 19 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ddraw: Forward AddAttachedSurface to the correct equivalent
by Stefan Dösinger 15 May '12

15 May '12

Am Sonntag, 13. Mai 2012, 20:39:27 schrieb David Adam: > + hr = ddraw_surface3_AddAttachedSurface(&This- >IDirectDrawSurface3_iface, > + attachment_impl ? &attachment_impl->IDirectDrawSurface3_iface : NULL); It isn't immediately clear to me why Surface3 is correct instead of Surface7. Do you have tests or bug reports to back this up?

3 3