May 2012 - Wine-devel - list.winehq.org

Re: [PATCH 1/4] dsound: Remove minlen, since we always mix full chunks anyway
by Alexander E. Patrakov 15 May '12

15 May '12

Andrew Eikum wrote: > - > - TRACE("Mixed at least %d from all buffers\n", minlen); > - return minlen; Hi. You have removed the message that could say "Mixed at least 0 from all buffers" (as seen, e.g., for Armored Fist 3 and sometimes even for foobar2000). What was the reason for that "0" (or, rather, 1024, 1024, 1024, 0, 2048, 1024, ... sequence) seen in some games? Was it also fixed by your patch? (this mail is a question, not an objection) -- Alexander E. Patrakov

2 1

Re: [PATCH 1/4] dsound: Change mix_buffer to float instead of INT
by Alexander E. Patrakov 15 May '12

15 May '12

Andrew Eikum wrote: > +static LONG f_to_24(float value) > +{ > if(value <= -1.f) > + return 0x80000000; > + if(value >= 1.f * 0x7FFFFF / 0x800000) > + return 0x7FFFFF00; > + return lrintf(value * 0x80000000U); > } ... > +static inline LONG f_to_32(float value) > +{ > + if(value <= -1.f) > + return 0x80000000; > + if(value >= 1.f * 0x7FFFFFFF / 0x80000000U) /* this rounds to 1.f */ > + return 0x7FFFFFFF; > + return le32(lrintf(value * 0x80000000U)); > +} [sorry for a possible duplicate, the previous mail contained a typo] Minor nitpick: I'd say these functions are identical on little-endian systems if the least significant bits are discarded. Are you sure that we indeed want two functions here, and not, say, use f_to_32() in put24()? -- Alexander E. Patrakov

1 0

Wine Mono 0.0.4 Release - I'm serious now!
by Vincent Povirk 14 May '12

14 May '12

I have published version 0.0.4 of Wine Mono on Sourceforge. I fully intend to make this release a part of Wine. The source tarball is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.4/wine-mono-0.0.… The binary is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.4/wine-mono-0.0.… For developers, the source repository is at https://github.com/madewokherd/wine-mono Changes since 0.0.2: * With Wine 1.5.4 and Wine Mono 0.0.4, it's now possible to run mixed-mode assemblies. * The random hang that was introduced in Mono 2.11 is now fixed (0.0.2 contained a hacky work-around). * A replacement for XNA 4.0 based on MonoGame is now included, to be used if MS XNA 4.0 is not installed. * Updated Mono from 2.11.0 to 2.11.1, bringing in the changes listed here: http://mono.1490590.n4.nabble.com/Mono-2-11-1-is-out-td4575466.html * Changes from Hans Leidekker to make upgrading and removing the msi work better. * Added more registry keys to prevent native .NET from trying to install while Wine Mono is installed. * Various improvements to the build script. Some programs that worked with the official Mono for Windows package will fail with this one because gluezilla (Mono's web browser component) is missing. In all other respects I expect this to work as well as or better than the official Mono for Windows package, and if not I'd like to hear about it. If nothing new seems to be horribly wrong with this build other than the lack of gluezilla, I will try to make it an official part of Wine. It's not really clear where the bugs should be reported at the moment, but I think Wine bugzilla is appropriate.

1 0

XINPUT JOYSTICK PATCH
by Giovanni Ongaro 14 May '12

14 May '12

I have written a modification of the xinput1_3 dll that simulates xbox joystick with a logitech rumblepad 2 joystick,also provided is a way to disable dinput joysticks through an environment variable, it seems to work well,may it be of interest to the wine project?

2 1

Re: wmvcore: Add stub for WMCreateSyncReader
by Nikolay Sivov 14 May '12

14 May '12

On 5/14/2012 19:34, André Hentschel wrote: > Otherwise GTA San Andreas runs into it and crashes. This stub let's it work again. > a workaround is to disable wmvcore in winecfg... > --- > dlls/wmvcore/wmvcore.spec | 2 +- > dlls/wmvcore/wmvcore_main.c | 8 ++++++++ > 2 files changed, 9 insertions(+), 1 deletions(-) > > diff --git a/dlls/wmvcore/wmvcore.spec b/dlls/wmvcore/wmvcore.spec > index 1c6cb1f..e0fa2e9 100644 > --- a/dlls/wmvcore/wmvcore.spec > +++ b/dlls/wmvcore/wmvcore.spec > @@ -11,7 +11,7 @@ > @ stub WMCreateProfileManager > @ stub WMCreateReader > @ stub WMCreateReaderPriv > -@ stub WMCreateSyncReader > +@ stdcall WMCreateSyncReader(ptr long ptr) > @ stub WMCreateWriter > @ stub WMCreateWriterFileSink > @ stub WMCreateWriterNetworkSink > diff --git a/dlls/wmvcore/wmvcore_main.c b/dlls/wmvcore/wmvcore_main.c > index 096328b..5fce972 100644 > --- a/dlls/wmvcore/wmvcore_main.c > +++ b/dlls/wmvcore/wmvcore_main.c > @@ -22,6 +22,7 @@ > > #include "windef.h" > #include "winbase.h" > +#include "objbase.h" > #include "wine/debug.h" > > WINE_DEFAULT_DEBUG_CHANNEL(wmvcore); > @@ -43,3 +44,10 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > > return TRUE; > } > + > +HRESULT WINAPI WMCreateSyncReader(IUnknown *pcert, DWORD rights, > + IUnknown /* FIXME: IWMSyncReader */ **syncreader) > +{ > + FIXME("(%p, %x, %p): stub\n", pcert, rights, syncreader); > + return E_NOTIMPL; > +} You'll be probably requested to add a proper .idl for that with interface definition. Also it makes sense to init out parameter to 0, as a common practice for such creation methods/calls. >

1 0

Re: [1/2] gdiplus: Measure the passed in string without height clipping in order to compute correct Y offset. Take 3.
by Vincent Povirk 14 May '12

14 May '12

Looks good to me.

1 0

Re: Using an IDE on Wine?
by Michael Ost 14 May '12

14 May '12

On 5/13/12 10:00 AM, wine-devel-request(a)winehq.org wrote: > How many of you use an Integrated Development Environment (IDE) when > working on Wine? > > If you do, which one do you use and how, how useful is it and how hard > was it to set up? I use Qt Creator for Linux for our winelib application. Our app is a hybrid winelib + Qt/X11 app, so we get the extra Qt "goodies" with Qt Creator. But it does work for other project types too. Getting the integrated gdb debugger to work was a trick. The main thing is to set WINELOADERNOEXEC=1 in the environment and run /usr/bin/wine as the debuggee. We also built and copied in a debug version of /usr/bin/wine to keep Qt Creator from complaining when a debug session got underway. The last "gotcha" was that we had to hack out alpha channel support for cursors when running under GDB. (IIRC) the DIB engine uses segfaults in normal operation which confuses GDB. I can send along that patch if you are interested. Of course, if you are trying to debug a straight windows application then all of this is irrelevant! But if you are doing winelib, then these tricks can help. -- Michael Ost

1 0

Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset. Take 2.
by Vincent Povirk 14 May '12

14 May '12

If the string wraps, and you don't give the width to GdipMeasureString, won't it return a too small height? On Mon, May 14, 2012 at 9:11 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > GdipMeasureString() clips the string extents to passed rectangle width and > height, but that leads to wrong offsety calculation if the string doesn't > fit into that rectangle. > --- > dlls/gdiplus/graphics.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c > index 38335a8..1c9780d 100644 > --- a/dlls/gdiplus/graphics.c > +++ b/dlls/gdiplus/graphics.c > @@ -5162,14 +5162,18 @@ GpStatus WINGDIPAPI GdipDrawString(GpGraphics *graphics, GDIPCONST WCHAR *string > /* Should be no need to explicitly test for StringAlignmentNear as > * that is default behavior if no alignment is passed. */ > if(format->vertalign != StringAlignmentNear){ > + static const RectF empty_rect = { 0.0, 0.0, 0.0, 0.0 }; > RectF bounds; > - GdipMeasureString(graphics, string, length, font, rect, format, &bounds, 0, 0); > + GdipMeasureString(graphics, string, length, font, &empty_rect, format, &bounds, 0, 0); > + > + TRACE("bounds %s\n", debugstr_rectf(&bounds)); > > if(format->vertalign == StringAlignmentCenter) > offsety = (rect->Height - bounds.Height) / 2; > else if(format->vertalign == StringAlignmentFar) > offsety = (rect->Height - bounds.Height); > } > + TRACE("vertical align %d, offsety %f\n", format->vertalign, offsety); > } > > save_state = SaveDC(hdc); > -- > 1.7.10.1 > > >

2 3

Re: [PATCH 1/5] d3dcompiler: Make SlWriteBytecode return the shader size.
by Stefan Dösinger 14 May '12

14 May '12

Am Montag, 14. Mai 2012, 17:24:01 schrieb Matteo Bruni: > - CopyMemory(pos, messages, strlen(messages) + 1); > + memcpy(pos, messages, strlen(messages) + 1); > ... > - if (shader == NULL) > + if (!shader) This looks unrelated. The changes are OK, but should be in another patch.

1 0

Re: [1/3] user32/tests: Add GetUserObjectInformation tests
by Alexandre Julliard 14 May '12

14 May '12

Owen Rudge <orudge(a)codeweavers.com> writes: > There appears to be a bug in the GetUserObjectInformationA function on > Windows that results in an incorrect buffer length being returned when > the buffer size provided by the caller is insufficient. The 'A' > function returns the Unicode length instead of the ANSI length. These > patches modify Wine's behaviour to provide that incorrect > behaviour. They also fix an issue whereby the wrong error code is set > when the buffer is too short. Using the number of Unicode chars multiplied by 2 is a reasonable upper bound on the A string size, and it's used in a number of places. This can't really be considered a Windows bug. -- Alexandre Julliard julliard(a)winehq.org

2 2