June 2012 - Wine-devel - list.winehq.org

Re: msvcp90: Fix __cdecl functions definitions that returns structures
by Alexandre Julliard 02 Jul '12

02 Jul '12

Piotr Caban <piotr(a)codeweavers.com> writes: > In code produced by gcc callee removes hidden return argument. In code > produced by MS Visual Studio caller is responsible for removing the > hidden argument. That's only for structures larger than 8 bytes, which isn't the case at least for _Getcoll. Some tests would probably be a good idea. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/2] qedit/tests: Add COM aggregation test for MediaDet.
by Marvin 30 Jun '12

30 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19677 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401587 === W2KPROSP4 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401587

2 1

Release schedule
by Alexandre Julliard 30 Jun '12

30 Jun '12

Folks, Because of various travels and vacations (and just to keep you on your toes ;-), during the month of July I'm planning to make releases on Tuesdays instead of Fridays. So 1.5.8 will be on July 3rd, and then I'll be out for the rest of that week. Subsequent releases should happen on July 17th and 31st, and I'll also be out the first 10 days of August. And if you find this confusing, just take some vacations too ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include/basetsd.h: Fix int64 to int truncation warnings when compiling with a 64-bit PSDK compiler.
by Michael Stefaniuc 30 Jun '12

30 Jun '12

Dmitry, afair the fix is to disable the int truncation warnings in MSVC. For whatever reason they seem to enable those bogus warnings. bye michael On 06/28/2012 12:12 PM, Dmitry Timoshkov wrote: > --- > include/basetsd.h | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/include/basetsd.h b/include/basetsd.h > index 698dd5c..4a59897 100644 > --- a/include/basetsd.h > +++ b/include/basetsd.h > @@ -153,12 +153,12 @@ typedef unsigned int UHALF_PTR, *PUHALF_PTR; > > static inline ULONG32 HandleToULong(const void *h) > { > - return (ULONG_PTR)h; > + return (ULONG32)(ULONG_PTR)h; > } > > static inline LONG32 HandleToLong(const void *h) > { > - return (LONG_PTR)h; > + return (LONG32)(LONG_PTR)h; > } > > static inline void *ULongToHandle(ULONG32 ul) > @@ -173,32 +173,32 @@ static inline void *LongToHandle(LONG32 l) > > static inline ULONG32 PtrToUlong(const void *p) > { > - return (ULONG_PTR)p; > + return (ULONG32)(ULONG_PTR)p; > } > > static inline LONG32 PtrToLong(const void *p) > { > - return (LONG_PTR)p; > + return (LONG32)(LONG_PTR)p; > } > > static inline UINT32 PtrToUint(const void *p) > { > - return (UINT_PTR)p; > + return (UINT32)(UINT_PTR)p; > } > > static inline INT32 PtrToInt(const void *p) > { > - return (INT_PTR)p; > + return (INT32)(INT_PTR)p; > } > > static inline UINT16 PtrToUshort(const void *p) > { > - return (ULONG_PTR)p; > + return (UINT16)(ULONG_PTR)p; > } > > static inline INT16 PtrToShort(const void *p) > { > - return (LONG_PTR)p; > + return (INT16)(LONG_PTR)p; > } > > static inline void *IntToPtr(INT32 i)

3 5

Re: windowscodecs: test for TIFFSetWarningHandlerExt
by Alexandre Julliard 29 Jun '12

29 Jun '12

Daniel Lehman <dlehman(a)esri.com> writes: > Fails to build on RHEL4 with libtiff 3.6.1 > > Alternative to this is a configure test for libtiff 3.8.0, which is when the function first appears I don't think this needs a configure test. Just define the prototype explicitly instead of using typeof. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] d3dx9: Implement D3DXLoadVolumeFromMemory.
by Matteo Bruni 29 Jun '12

29 Jun '12

2012/6/27 Józef Kucia <joseph.kucia(a)gmail.com>: > --- Hi Józef, > +void copy_simple_data(const BYTE *src, UINT srcpitch, SIZE src_size, const PixelFormatDesc *srcformat, > + BYTE *dest, UINT destpitch, SIZE dst_size, const PixelFormatDesc *destformat, D3DCOLOR colorkey) DECLSPEC_HIDDEN; > + You are not actually using this function in the patch. > + if (dst_box->Left > dst_box->Right || dst_box->Right > desc.Width) > + return D3DERR_INVALIDCALL; > + if (dst_box->Top > dst_box->Bottom || dst_box->Bottom > desc.Height) > + return D3DERR_INVALIDCALL; > + if (dst_box->Front > dst_box->Back || dst_box->Back > desc.Depth) > + return D3DERR_INVALIDCALL; > + > + dst_width = dst_box->Right - dst_box->Left; > + dst_height = dst_box->Bottom - dst_box->Top; > + dst_depth = dst_box->Back - dst_box->Front; > + if (!dst_width || !dst_height || !dst_depth) > + return D3DERR_INVALIDCALL; You can avoid the last check by comparing e.g. (dst_box->Left >= dst_box->Right) above, instead of using ">". > + if (src_box->Left & (src_format_desc->block_width - 1) > + || src_box->Top & (src_format_desc->block_height - 1) > + || (src_box->Right & (src_format_desc->block_width - 1) > + && src_width != desc.Width) > + || (src_box->Bottom & (src_format_desc->block_height - 1) > + && src_height != desc.Height)) > + { > + WARN("Source box (%u, %u, %u, %u) is misaligned\n", > + src_box->Left, src_box->Top, src_box->Right, src_box->Bottom); > + return D3DXERR_INVALIDDATA; > + } I'm not quite sure of the right and bottom misalignment checks. If the tests confirm that, of course that's okay. > + for (slice = 0; slice < src_depth; slice++) > + { > + src_addr = src_memory; > + src_addr += slice * src_slice_pitch; Shouldn't you take into account src_box->Front?

2 1

Re: user32: Add test for ComboBox repositioning behavior (try 2).
by Marvin 29 Jun '12

29 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19658 Your paranoid android. === W7PRO (32 bit msg) === msg.c:8219: Test failed: did not get zero count as expected (1).

2 1

Re: gdiplus: Add a test to show that GdipCloneImage is not supposed to increase refcount of the source image stream, but clone it instead.
by Vincent Povirk 29 Jun '12

29 Jun '12

I think it's most likely not keeping the input stream in the new image at all. It's probably also worth testing SelectActiveFrame, GetPropertyItem, and GetImageRawFormat with clones of images. Maybe they don't work.

2 1

Re: wbemprox: Add a Win32_LogicalDisk class stub.
by Hans Leidekker 28 Jun '12

28 Jun '12

On Thu, 2012-06-28 at 21:53 +0300, John Yani wrote: > +static void fill_logicaldisk( struct table *table ) > +{ > + static const WCHAR caption[] = > + {'C',':',0}; > + static const WCHAR description[] = > + {'L','o','c','a','l',' ','F','i','x','e','d',' ','D','i','s','k',0}; > + static const WCHAR device_id[] = > + {'C',':',0}; > + struct record_logicaldisk *rec; > + FIXME("returns a fake logical disks table\n"); > + if (!(table->data = heap_alloc( sizeof(*rec) ))) > + { > + return; > + } > + rec = (struct record_logicaldisk *)(table->data); > + rec->caption = caption; > + rec->description = description; > + rec->device_id = device_id; > + table->num_rows = 1; > + TRACE("created %u row(s)\n", table->num_rows); That's better. Does NFS actually query the Caption and Description properties?

2 4

Re: user32: Add a test for ComboBox WM_WINDOWPOSCHANGED handling.
by Alexandre Julliard 28 Jun '12

28 Jun '12

Sergey Guralnik <serhio(a)etersoft.ru> writes: > @@ -5807,6 +5830,25 @@ static void test_combobox_messages(void) > log_all_parent_messages--; > ok_sequence(WmKeyDownComboSeq, "WM_KEYDOWN/VK_DOWN on a ComboBox", FALSE); > > + wp.hwnd = combo; > + wp.hwndInsertAfter = HWND_TOP; > + wp.cx = wp.cy = wp.x = wp.y = 50; > + wp.flags = 0; > + flush_sequence(); > + SendMessage(combo, WM_WINDOWPOSCHANGED, 0, (LPARAM)&wp); It doesn't make much sense to send this message directly. What are you trying to test? -- Alexandre Julliard julliard(a)winehq.org

1 0