June 2012 - Wine-devel - list.winehq.org

Re: [2/2] gdiplus: Increase refcount of the source stream when loading a bitmap instead of cloning it.
by Vincent Povirk 28 Jun '12

28 Jun '12

This looks good to me. (I didn't think it was necessary to comment, but this is an important fix and I was surprised it was still New.)

1 0

Unused msvcp60 functions
by Francois Gouget 28 Jun '12

28 Jun '12

I get the following warnings when compiling msvcp60: main.c:108:51: warning: ‘std_BADOFF_func’ defined but not used [-Wunused-function] misc.c:66:40: warning: ‘mutex_mutex_lock’ defined but not used [-Wunused-function] misc.c:73:40: warning: ‘mutex_mutex_unlock’ defined but not used [-Wunused-function] misc.c:80:40: warning: ‘mutex_mutex_ctor’ defined but not used [-Wunused-function] misc.c:87:40: warning: ‘mutex_mutex_dtor’ defined but not used [-Wunused-function] misc.c:175:58: warning: ‘set_new_handler_reset’ defined but not used [-Wunused-function] Indeed msvcp60.spec contains no _BADOFF, _Mutex or set_new_handler function. I don't see them in my 'database' of exported Windows APIs for msvcp60 but maybe the Windows dlls I built it from where not entirely up to date. Still it looks like these were added in later revisions and thus can be removed from the above files. misc.c:127:50: warning: ‘wctype’ defined but not used [-Wunused-function] This one is actually forwarded to msvcp90 according to msvcp60.spec, thus making this implementation redundant. So it should either be removed or msvcp60.spec should be modified. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Only wimps use tape backup: _real_ men just upload their important stuff on ftp, and let the rest of the world mirror it ;)" -- Linus Torvalds

2 3

Re: windowscodecs: Make sure that stream is not reused once the decoder is initialized.
by Vincent Povirk 28 Jun '12

28 Jun '12

Looks good to me.

1 0

Re: kernel32/tests: Remove an unused variable in the sync tests.
by Marvin 28 Jun '12

28 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19638 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] d3dx9: Implement D3DXCreateVolumeTextureFromFileInMemoryEx.
by Matteo Bruni 28 Jun '12

28 Jun '12

2012/6/27 Józef Kucia <joseph.kucia(a)gmail.com>: > --- > + for (mip_level = 0; mip_level < mip_levels; mip_level++) > + { > + hr = calculate_dds_surface_size(src_info, width, height, &src_pitch, &mip_level_size); > + if (FAILED(hr)) return hr; ... > + hr = D3DXLoadVolumeFromMemory(volume, palette, NULL, pixels, src_info->Format, > + src_pitch, mip_level_size, NULL, &box, filter, color_key); mip_level_size would be the source slice pitch, right? I'd just call it like that.

1 0

Re: [2/2] msvcp90: Sync spec files
by Owen Rudge 28 Jun '12

28 Jun '12

On 28/06/2012 11:33, Owen Rudge wrote: > --- > dlls/msvcp60/msvcp60.spec | 638 > ++++++++++++++++++++++---------------------- Sorry, I ran the make_specfiles script without realising that msvcp60.spec shouldn't have been updated. I've resent the patch without these changes. -- Owen Rudge http://www.owenrudge.net/

1 0

Re: [2/2] msvcp90: Sync spec files
by Piotr Caban 28 Jun '12

28 Jun '12

First patch looks correct. On 06/28/12 12:33, Owen Rudge wrote: > dlls/msvcp60/msvcp60.spec | 638 > ++++++++++++++++++++++---------------------- You can't update msvcp60.spec file this way (most of functions there should not be forwarded to msvcp90).

1 0

Re: po: add missing url tag to nl.po
by Francois Gouget 28 Jun '12

28 Jun '12

On Wed, 27 Jun 2012, Austin English wrote: > http://bugs.winehq.org/show_bug.cgi?id=31038 "Noot: Het wordt aanbevolen om distributiepakketten te gebruiken. Zie <a " -"href=http://wiki.winehq.org/Gecko voor details." +"href=http://wiki.winehq.org/Gecko</a> voor details." Note that this is missing a lot more than just </a>. This should be: "Noot: Het wordt aanbevolen om distributiepakketten te gebruiken. Zie <a " "href=\"http://wiki.winehq.org/Gecko\">http://wiki.winehq.org/Gecko</a> voor details." Fortunately it looks like nl is the only such case. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A polar bear is a cartesian bear after a coordinate transform.

1 0

Re: [1/5] windowscodecs: Implement MetadataHandler_GetValue. Take 2. Resend.
by Marvin 27 Jun '12

27 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19631 Your paranoid android. === WVISTAADM (32 bit metadata) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [4/5] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem. Take 2.
by Marvin 27 Jun '12

27 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19625 Your paranoid android. === W7PROX64 (64 bit image) === image.c:2817: Test failed: 0: expected property size 17 or 36, got 44 image.c:2817: Test failed: 2: expected property size 144 or 0, got 152 image.c:2817: Test failed: 3: expected property size 20 or 0, got 28 === TEST64_W7SP1 (64 bit image) === image.c:2817: Test failed: 0: expected property size 17 or 36, got 44 image.c:2817: Test failed: 2: expected property size 144 or 0, got 152 image.c:2817: Test failed: 3: expected property size 20 or 0, got 28

2 1