June 2012 - Wine-devel - list.winehq.org

Re: [PATCH 4/4] qedit: Support COM aggregation for SampleGrabber.
by Marvin 26 Jun '12

26 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19578 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 mediadet.c:356: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401639 === W2KPROSP4 (32 bit mediadet) === mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 mediadet.c:356: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401639

2 1

Re: [PATCH 3/4] qedit/tests: Add COM aggregation test for MediaDet.
by Michael Stefaniuc 26 Jun '12

26 Jun '12

Argh! Please skip this patch, it is incomplete and just skips the rest of the tests on Wine. I'll resubmit it when I implement COM aggregation for MediaDet. Patch 4/4 can be still applied as it doesn't depends on this. bye michael On 06/26/2012 11:53 PM, Michael Stefaniuc wrote: > --- > dlls/qedit/tests/mediadet.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/dlls/qedit/tests/mediadet.c b/dlls/qedit/tests/mediadet.c > index 1d9a2f1..1d75680 100644 > --- a/dlls/qedit/tests/mediadet.c > +++ b/dlls/qedit/tests/mediadet.c > @@ -132,6 +132,7 @@ static BOOL init_tests(void) > static void test_mediadet(void) > { > HRESULT hr; > + struct unk_impl unk_obj = {{&unk_vtbl}, 19, NULL}; > IMediaDet *pM = NULL; > BSTR filename = NULL; > LONG nstrms = 0; > @@ -141,6 +142,12 @@ static void test_mediadet(void) > int flags; > int i; > > + /* COM aggregation */ > + hr = CoCreateInstance(&CLSID_MediaDet, &unk_obj.IUnknown_iface, CLSCTX_INPROC_SERVER, > + &IID_IUnknown, (void**)&unk_obj.inner_unk); > + todo_wine ok(hr == S_OK, "CoCreateInstance failed: %08x\n", hr); > + if (hr != S_OK) return; > + > /* test.avi has one video stream. */ > hr = CoCreateInstance(&CLSID_MediaDet, NULL, CLSCTX_INPROC_SERVER, > &IID_IMediaDet, (LPVOID*)&pM);

1 0

Re: [PATCH 3/4] qedit/tests: Add COM aggregation test for MediaDet.
by Marvin 26 Jun '12

26 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19577 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 mediadet.c:356: Test failed: CoCreateInstance failed: 80040154 === W2KPROSP4 (32 bit mediadet) === mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 mediadet.c:356: Test failed: CoCreateInstance failed: 80040154

1 0

Re: kernel32: Change LCMapStringW to LCMapStringEx and call it from LCMapStringW (try 2)
by Alexandre Julliard 26 Jun '12

26 Jun '12

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -2625,6 +2641,28 @@ INT WINAPI LCMapStringW(LCID lcid, DWORD flags, LPCWSTR src, INT srclen, > } > > /************************************************************************* > + * LCMapStringW (KERNEL32.@) > + * > + * See LCMapStringA. > + */ > +INT WINAPI LCMapStringW(LCID lcid, DWORD flags, LPCWSTR src, INT srclen, > + LPWSTR dst, INT dstlen) > +{ > + WCHAR locale[LOCALE_NAME_MAX_LENGTH]; > + > + TRACE("(0x%04x,0x%08x,%s,%d,%p,%d)\n", > + lcid, flags, debugstr_wn(src, srclen), srclen, dst, dstlen); > + > + if (!LCIDToLocaleName(lcid, locale, LOCALE_NAME_MAX_LENGTH, 0)) > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return 0; > + } I don't think it makes sense to do name conversion for a parameter that isn't used. If we use it someday it will most likely be to look up a conversion table directly from the lcid. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: windowscodecs: Implement MetadataHandler_GetValue.
by Vincent Povirk 26 Jun '12

26 Jun '12

> + case VT_I8: > + case VT_UI8: > + case VT_R8: > + return v1->u.uhVal.QuadPart - v2->u.uhVal.QuadPart; Won't this only compare the low part on x86?

2 1

Re: [PATCH 3/5] secur32: Handle incomplete messages in schan_InitializeSecurityContextW().
by Marvin 26 Jun '12

26 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19560 Your paranoid android. === WNT4WSSP6 (32 bit schannel) === schannel.c:702: Test failed: Got unexpected status 0x80090308.

1 0

Re: urlmon: Do not stop binding when OnDataAvailable() returns E_PENDING
by Jacek Caban 26 Jun '12

26 Jun '12

On 06/26/12 00:02, Andrew Talbot wrote: > Changelog: > urlmon: Do not stop binding when OnDataAvailable() returns E_PENDING. > > diff --git a/dlls/urlmon/binding.c b/dlls/urlmon/binding.c > index 58aed20..42eca4b 100644 > --- a/dlls/urlmon/binding.c > +++ b/dlls/urlmon/binding.c > @@ -1097,7 +1097,7 @@ static void report_data(Binding *This, DWORD bscf, ULONG progress, ULONG progres > > hres = IBindStatusCallback_OnDataAvailable(This->callback, bscf, progress, > &formatetc, &stgmed); > - if(hres != S_OK) { > + if(FAILED(hres) && hres != E_PENDING) { > if(This->download_state != END_DOWNLOAD) { > This->download_state = END_DOWNLOAD; > IBindStatusCallback_OnProgress(This->callback, progress, progress_max, Please add a test case. You may modify one of existing binding tests to use E_PENDING. Jacek

1 0

Is it safe yet for developers to upgrade to Ubuntu 12.04?
by Erich E. Hoover 26 Jun '12

26 Jun '12

I know that for a while there were some packaging problems that meant that upgrading to 12.04 made compiling 32-bit Wine on a 64-bit PC extremely difficult. Is this still the case? I'd like to upgrade to the new OS version, but I'm not willing to sacrifice the ability to build Wine in order to do so. Thanks in advance! Erich Hoover ehoover(a)mines.edu

6 5

Re: [PATCH] opengl32: Disable wglGetProcAddress for core GL 1.0/1.1 functions
by Marvin 26 Jun '12

26 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19550 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

change wording of ok()-messages in winspool-tests?
by Julian Rüger 26 Jun '12

26 Jun '12

Hi Francois and list, [/nitpick-mode on] I'm preparing a patch to fix typos/spelling/grammar in dlls/winspool.drv/tests/info.c, where I stumbled across repeated messages like ok( !retval, "function result wrong! False expected\n"); or ok( size == exact, "Parameter size wrong! %d expected got %d\n", exact, size); Do you think it's worth changing these? (I think "Wrong function result: 'false' expected\n", and "Wrong parameter size: expected %d, got %d\n" would be better) Do we have guidelines for strings like these? For example: start with a captial letter, no punctuation at the end... What tests have "good" style I can use as reference? Best regards, Julian PS: Am I bike shedding here? Does anyone care about stuff like this? Sorry for wasting your time ;)

3 3