August 2012 - Wine-devel - list.winehq.org

Re: comdlg32: Use proper helpers for iface calls
by Marvin 16 Aug '12

16 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20929 Your paranoid android. === TEST64_W7SP1 (32 bit itemdlg) === itemdlg: unhandled exception c0000005 at 75AF1AC3

1 0

Re: [PATCH 1/4] include/wine/test.h: Added wine_dbgstr_a[n] to test framwork.
by Qian Hong 16 Aug '12

16 Aug '12

On Thu, Aug 16, 2012 at 4:55 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > > This shouldn't be necessary, you can use a simple printf. Functions > should only be added to test.h if there's a clear need across a wide > range of tests. Thanks for review! Will provide an updated patch set soon. -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

1 0

Re: [PATCH] kernel32: add support for CAL_ICALINTVALUE
by Alexandre Julliard 16 Aug '12

16 Aug '12

Michael Blumenkrantz <michael.blumenkrantz(a)gmail.com> writes: > @@ -656,8 +656,8 @@ int WINAPI GetCalendarInfoW(LCID Locale, CALID Calendar, CALTYPE CalType, > * for the CALTYPES not requiring GetLocaleInfoA */ > switch (CalType & ~(CAL_NOUSEROVERRIDE|CAL_RETURN_NUMBER|CAL_USE_CP_ACP)) { > case CAL_ICALINTVALUE: > - FIXME("Unimplemented caltype %d\n", CalType & 0xffff); > - return 0; > + return GetLocaleInfoW(Locale, LOCALE_RETURN_NUMBER|LOCALE_ICALENDARTYPE, > + (LPWSTR)lpValue, sizeof(CALID)/sizeof(WCHAR)); I doubt that you want to hardcode LOCALE_RETURN_NUMBER here. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: windowscodecs: Implement Palette_InitializeFromBitmap.
by Vincent Povirk 15 Aug '12

15 Aug '12

This does not agree with MSDN's description of the function. According to MSDN, InitializeFromBitmap should compute a palette based on the contents of the (presumably) non-paletted bitmap data.

2 2

Re: Use WM_PAINT to redraw button instead of directly calling unthemed paint routine
by Dmitry Timoshkov 15 Aug '12

15 Aug '12

Ruslan Kabatsayev <b7.10110111(a)gmail.com> wrote: > This patch makes buttons render correctly themed in various cases when > e.g. they are pressed and released, made active etc. Without this > patch they look win95-like in such cases even if desktop integration > is used. Let me guess, you didn't run 'make test' with these changes? -- Dmitry.

2 1

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin 14 Aug '12

14 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20875 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin 14 Aug '12

14 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20871 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [05/17] gdiplus: GdipMeasureString should apply its internal scaling factors to layout rectangle.
by Alexandre Julliard 14 Aug '12

14 Aug '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/gdiplus/graphics.c | 10 ++++++++-- > dlls/gdiplus/tests/graphics.c | 29 ----------------------------- > 2 files changed, 8 insertions(+), 31 deletions(-) This fails here on 64-bit: ../../../../wine/tools/runtest -q -P wine -M gdiplus.dll -T ../../.. -p gdiplus_test.exe.so ../../../../wine/dlls/gdiplus/tests/graphics.c && touch graphics.ok graphics.c:3609: Test failed: Expected 100.000000, got 98.999786 graphics.c:3609: Test failed: Expected 100.000000, got 98.999786 graphics.c:3609: Test failed: Expected 100.000000, got 98.999786 graphics.c:3609: Test failed: Expected 100.000000, got 98.999786 make: *** [graphics.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 4/4] ole32: Added ISynchronizeHandle tests
by Marvin 14 Aug '12

14 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20841 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: user32: search more aggressively for a window under a tooltip
by Dmitry Timoshkov 14 Aug '12

14 Aug '12

Daniel Jelinski <djelinski1(a)gmail.com> wrote: > Fixes bug 9512 and bug 8914, tested with Delphi and DVD Profiler. > Still not perfect - according to MSDN the function should never return > a window belonging to another thread. This kind of change requires a test case, and I suspect it's plain wrong. -- Dmitry.

3 9