August 2012 - Wine-devel - list.winehq.org

Re: [10/10] gdiplus: Filter tabs out until they are properly supported using stringformat.
by Vincent Povirk 17 Aug '12

17 Aug '12

This should probably be handled somehow by gdip_format_string. DrawDriverString doesn't have access to the StringFormat, and there's a good change that the native implementation really does draw tabs as squares. Also, MeasureCharacterRanges and MeasureString will have to account for tabstops. gdip_format_string already has logic to ignore certain characters, but it needs more thought as to how we can do that and keep the offsets passed to the callback accurate, and how to eventually pass information about tabs to the callback. If this does turn out to be a correct change for DrawDriverString (I predict that it is not), then MeasureDriverString should be updated as well.

2 1

Re: [08/10] gdiplus: GdipMeasureString/GdipDrawString should add extra space around the text.
by Vincent Povirk 17 Aug '12

17 Aug '12

Why can't this logic go in gdip_format_string?

2 6

Re: Re: DSSENH/tests: Added block cipher mode tests for the DSSENH cryptographic service provider (try2)
by Marvin 17 Aug '12

17 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20983 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [02/10] gdiplus: If source and destination rectangles differ it's not a reason to fallback to software blitting.
by Vincent Povirk 17 Aug '12

17 Aug '12

> Both StretchBlt and GdiAlphaBlend handle that case just fine. Only if the graphics interpolation mode happens to be nearest neighbor, which isn't the default.

2 3

Re: DSSENH/tests: Added block cipher mode tests for the DSSENH cryptographic service provider
by Marvin 17 Aug '12

17 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20977 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/3] riched20: Added support for UTF8 BOM stream. (Try 2)
by Alexandre Julliard 16 Aug '12

16 Aug '12

Qian Hong <fracting(a)gmail.com> writes: > @@ -304,8 +307,19 @@ static LRESULT ME_StreamInText(ME_TextEditor *editor, DWORD dwFormat, ME_InStrea > > if (!(dwFormat & SF_UNICODE)) > { > - /* FIXME? this is doomed to fail on true MBCS like UTF-8, luckily they're unlikely to be used as CP_ACP */ > - nWideChars = MultiByteToWideChar(CP_ACP, 0, stream->buffer, stream->dwSize, wszText, STREAMIN_BUFFER_SIZE); > + if (!is_read) > + { > + is_read = TRUE; > + if (stream->dwSize >= 3 && !memcmp(stream->buffer, bom_utf8, 3)) > + { > + cp = CP_UTF8; > + stream->dwSize -= 3; > + memmove(stream->buffer, stream->buffer + 3, stream->dwSize); There's no reason to move the data. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 2/2] comctl32: Correct values passed in MCN_SELECT/MCN_SELCHANGE notifications.
by Nikolay Sivov 16 Aug '12

16 Aug '12

On Thu, Aug 16, 2012 at 5:20 PM, Sergey Guralnik <serhio(a)etersoft.ru> wrote: > > -- > Sergey > > > You can use simple assignment with st_null instead of that: + memset(&nmsc.stSelEnd, 0, sizeof nmsc.stSelEnd);

1 0

Re: [PATCH 2/2] comctl32: Correct values passed in MCN_SELECT/MCN_SELCHANGE notifications.
by Marvin 16 Aug '12

16 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20934 Your paranoid android. === WNT4WSSP6 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2KPROSP4 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WXPPROSP3 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K3R2SESP2 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WVISTAADM (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K8SE (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PRO (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (64 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (64 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead

1 0

Re: [PATCH 2/2] comctl32: Correct values passed in MCN_SELECT/MCN_SELCHANGE notifications.
by Marvin 16 Aug '12

16 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20934 Your paranoid android. === WNT4WSSP6 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2KPROSP4 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WXPPROSP3 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K3R2SESP2 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WVISTAADM (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K8SE (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PRO (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (64 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (64 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead

1 0

Re: [PATCH 1/2] comctl32/tests: Add test for MCN_SELECT/MCN_SELCHANGE notifications.
by Marvin 16 Aug '12

16 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20933 Your paranoid android. === WNT4WSSP6 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2KPROSP4 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WXPPROSP3 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K3R2SESP2 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WVISTAADM (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K8SE (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PRO (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (64 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (64 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead

2 1