August 2012 - Wine-devel - list.winehq.org

Re: [PATCH 4/4] wined3d: Improve post-pixelshader blending test. (Try 2)
by Lucas Zawacki 20 Aug '12

20 Aug '12

Hello, this patch caused a regression with Rayman 2, all the text in the menus is rendered wrong now. Should I open a bug or is this email enough? A demo of the game can be downloaded here ftp://ftp.ubisoft.com/Rayman2/rayman2high.zip Screenshot: http://dl.dropbox.com/u/2701879/images/rayman2.png Regression test: a488e574497d674631b4036d4b179ce349ddb764 is the first bad commit commit a488e574497d674631b4036d4b179ce349ddb764 Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Wed Aug 15 00:38:26 2012 +0200 wined3d: Improve post-pixelshader blending test. :040000 040000 1a61c91a146de3e7a5206ccde1cc239fa0771e40 a9759ba603b3b52f2feccc716daff3d875a90b74 M dlls

2 1

Re: [6/7] d3dx9: Implement ID3DXConstantTable::SetMatrixPointerArray.
by Rico Schüller 20 Aug '12

20 Aug '12

On 20.08.2012 17:10, Józef Kucia wrote: > + if (desc.Class == D3DXPC_MATRIX_ROWS || desc.Class == D3DXPC_MATRIX_COLUMNS) > + { ... > + } > + else if (desc.Class == D3DXPC_SCALAR) Could you also set D3DXPC_VECTOR variables with this call? It should be easy to add a test for a scalar and a vector. But that may also be a separate patch. In general I think it would be fine to try to set all variable class and see which work / fail. That way you would also verify, that the non common way works too, which has no test, yet, but a implementation. This holds true for all the Set(Matrix/Vector/...) functions. That way you'd ensure that the setting is correct for the specific class. ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "c2x3", matrix_pointer, 1); ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "r2x3", matrix_pointer, 1); ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "vec3", matrix_pointer, 1); ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "scalar", matrix_pointer, 1); Cheers Rico

1 0

Re: [3/7] d3dx9: ID3DXConstantTable::SetFloat shouldn't change the value of matrix and vector constants.
by Rico Schüller 20 Aug '12

20 Aug '12

On 20.08.2012 17:10, Józef Kucia wrote: > @@ -665,6 +666,31 @@ static void test_setting_basic_table(IDirect3DDevice9 *device) > out[8], out[9], out[10], out[11], > out[12], out[13], out[14], out[15]); > > + ID3DXConstantTable_SetFloat(ctable, device, "mvp", f); > + ok(res == D3D_OK, "ID3DXConstantTable_SetFloat failed on variable mvp: 0x%08x\n", res); You probably may save res (= ID3DXConstantTable_SetFloat) before checking it. Otherwise you are checking the same res value multiple times. > + ID3DXConstantTable_SetFloat(ctable, device, "f4", f); > + ok(res == D3D_OK, "ID3DXConstantTable_SetFloat failed on variable f4: 0x%08x\n", res); Cheers Rico

1 0

Re: [PATCH 1/2] oleaut32: Ensure that the right interface is passed to the callee in ITypeInfo::Invoke
by Alexandre Julliard 20 Aug '12

20 Aug '12

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -6509,6 +6510,38 @@ static HRESULT WINAPI ITypeInfo_fnInvoke( > { > prgpvarg[i] = src_arg; > } > + > + if((tdesc->vt == VT_USERDEFINED || (tdesc->vt == VT_PTR && tdesc->u.lptdesc->vt == VT_USERDEFINED)) > + && (V_VT(prgpvarg[i]) == VT_DISPATCH || V_VT(prgpvarg[i]) == VT_UNKNOWN)) { > + const TYPEDESC *userdefined_tdesc = tdesc; > + IUnknown *userdefined_iface; > + ITypeInfo *tinfo2; > + TYPEATTR *tattr; > + > + if(tdesc->vt == VT_PTR) > + userdefined_tdesc = tdesc->u.lptdesc; typelib.c: In function ‘ITypeInfo_fnInvoke’: typelib.c:6516:41: error: variable ‘userdefined_tdesc’ set but not used [-Werror=unused-but-set-variable] make[1]: *** [typelib.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Microsecond unit
by Francois Gouget 20 Aug '12

20 Aug '12

The microsecond unit is 'µs' and yet, in dlls/sane.ds/sane.rc, we define it as 'us' and then rely on the British and American English PO files to convert it to 'µs'. Why not put the right unit directly in the RC file? It's UTF-8 anyway... -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The software said it requires Win95 or better, so I installed Linux.

2 1

Re: kernel32: Add UTF-7 support. (try 4)
by Alex Henrie 20 Aug '12

20 Aug '12

Correction: I meant to write that try 4 exits the loop slightly faster when ending a base64 sequence, it has nothing to do with escaped plus signs which are handled a few lines earlier. -Alex

1 0

Re: [6/7] gdiplus: Add a test for extra space added by GdipMeasureString. Resend.
by Marvin 20 Aug '12

20 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21046 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: msctf: Call interface methods properly
by Marvin 20 Aug '12

20 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21043 Your paranoid android. === TEST64_W7SP1 (32 bit inputprocessor) === inputprocessor.c:259: Test failed: Unexpected TextStoreACP_GetStatus sink inputprocessor.c:259: Test failed: Unexpected TextStoreACP_GetStatus sink

1 0

How to convert msvcp names to legible names?
by Bruno Jesus 19 Aug '12

19 Aug '12

Which is the roseta stone used to read all msvcp function names like "msvcp80.dll.??0?$basic_stringstream(a)GU?$char_traits(a)G@std@@V?$allocator(a)G@2@@std@@QAE(a)H@Z, aborting" as the real function name in source code? Thanks in advance, Bruno

3 2

Re: winedbg: Use standard fixed pitch UI font for the crash dialog.
by Dmitry Timoshkov 17 Aug '12

17 Aug '12

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > static void set_fixed_font( HWND dlg, UINT id ) > { > - HFONT hfont = (HFONT)SendDlgItemMessageW( dlg, id, WM_GETFONT, 0, 0); > - LOGFONTW font; > + HFONT hfont; > > - GetObjectW(hfont, sizeof(LOGFONTW), &font); > - font.lfPitchAndFamily = FIXED_PITCH; > - font.lfFaceName[0] = 0; > - hfont = CreateFontIndirectW(&font); > + hfont = GetStockObject( ANSI_FIXED_FONT ); > SendDlgItemMessageW( dlg, id, WM_SETFONT, (WPARAM)hfont, TRUE ); > } To clarify things a bit: current code uses empty font face name, and GDI uses "System" font in that case (regardless of requested FIXED_PITCH), which is absolutely not readable. ANSI_FIXED_FONT should use built-in "Courier", which is actually a FIXED_PITCH font and much more readable. -- Dmitry.

2 3