January 2013 - Wine-devel - list.winehq.org

Re: include: Make sure interlocked_cmpxchg128 is defined on ARM64
by André Hentschel 18 Jan '13

18 Jan '13

Am 18.01.2013 18:05, schrieb André Hentschel: > --- > include/wine/port.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/wine/port.h b/include/wine/port.h > index bd6f513..d6904c0 100644 > --- a/include/wine/port.h > +++ b/include/wine/port.h > @@ -435,7 +435,7 @@ extern __int64 interlocked_cmpxchg64( __int64 *dest, __int64 xchg, __int64 compa > extern int interlocked_xchg( int *dest, int val ); > extern void *interlocked_xchg_ptr( void **dest, void *val ); > extern int interlocked_xchg_add( int *dest, int incr ); > -#ifdef _WIN64 > +#if defined(__x86_64__) || defined(__aarch64__) || defined(_WIN64) > extern unsigned char interlocked_cmpxchg128( __int64 *dest, __int64 xchg_high, > __int64 xchg_low, __int64 *compare ); > #endif > > > > oops that's not fully correct, I'll fix it next week, not a bad warning. -- Best Regards, André Hentschel

1 0

Re: qcap: Fix compilation on older systems.
by Damjan Jovanovic 18 Jan '13

18 Jan '13

What does this patch do? libv4l1.h includes libv4l1-videodev.h which is a copy of linux/videodev.h. You should only need the one or the other. Are you saying there is a system where libv4l1.h is present but incomplete, and you need to include linux/videodev.h together with it? Thank you Damjan On Tue, Jan 15, 2013 at 6:47 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/qcap/v4l.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/qcap/v4l.c b/dlls/qcap/v4l.c > index f5baaeb..2562c48 100644 > --- a/dlls/qcap/v4l.c > +++ b/dlls/qcap/v4l.c > @@ -47,7 +47,8 @@ > #endif > #ifdef HAVE_LIBV4L1_H > #include <libv4l1.h> > -#elif defined(HAVE_LINUX_VIDEODEV_H) > +#endif > +#ifdef HAVE_LINUX_VIDEODEV_H > #include <linux/videodev.h> > #endif > #ifdef HAVE_UNISTD_H > -- > 1.8.0.2 > > >

3 4

Re: configure.ac: check for a recent enough libv4l1.h
by Alexandre Julliard 18 Jan '13

18 Jan '13

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * configure.ac: check for a recent enough libv4l1.h > > libv4l1.h can only be used instead of linux/videodev.h as of version > 0.8.3, so check for the version using pkg-config (the only possible > way) and don't try to compile with older versions. This fixes > compilation on systems like FreeBSD 8.2, where there is no > linux/videodev.h, and libv4l1.h is too old. You should check for the definitions we need, not the version number. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winebuild: Use Clang to assemble if its integrated assembler is being used. (try 2) (resend)
by Alexandre Julliard 18 Jan '13

18 Jan '13

Charles Davis <cdavis5x(a)gmail.com> writes: > Try 2: Clarify that this is a Mac OS-only change. Don't use $CC as the assembler. Use the right flags to select 32/64-bit assembly with Clang. > > The configure script invokes the system compiler to figure out if .cfi > pseudo-ops are supported, on the assumption that it will invoke the > system assembler. Winebuild, on the other hand, invokes the system > assembler directly. This caused a problem on Mac OS hosts when compiling > with Clang: configure would detect that .cfi ops were supported, because > Clang's integrated assembler supports them; however, when winebuild then > emitted assembly with .cfi ops in them, the system assembler would then > choke. This patch makes winebuild invoke Clang's assembler if a) we are > on Mac OS, b) $CC is detected to be Clang, and c) it is using (whether > by request or by default) its built-in assembler. You can't use ifdefs in winebuild. This would have to be a runtime check. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] vbscript: Added VBScript.RegExp version 5.5 typelib
by Jacek Caban 18 Jan '13

18 Jan '13

Hi Piotr, On 01/18/13 11:48, Piotr Caban wrote: > +#define DISPID_SUBMATCHES_ITEM 0 > +#define DISPID_SUBMATCHES_COUNT 1 > +#define DISPID_SUBMATCHES__NEWENUM -4 > + > +#define DISPID_MATCHCOLLECTION_ITEM 0 > +#define DISPID_MATCHCOLLECTION_COUNT 1 > +#define DISPID_MATCHCOLLECTION__NEWENUM -4 > + > +#define DISPID_MATCH_VALUE 0 Please use DISPID_VALUE and DISPID_NEWENUM instead. Jacek

1 0

Re: [PATCH 3/3] msvcrt: Added basic _popen tests (try2)
by Marvin 18 Jan '13

18 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23996 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/3] msvcrt: Added basic _popen tests
by Marvin 18 Jan '13

18 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23995 Your paranoid android. === WNT4WSSP6 (32 bit misc) === misc.c:340: Test failed: errno = -559038737 === W2KPROSP4 (32 bit misc) === misc.c:340: Test failed: errno = -559038737 === W2K3R2SESP2 (32 bit misc) === misc.c:340: Test failed: errno = -559038737

1 0

Re: [PATCH 3/3] d3dx9_36: Make variables static in xfile tests.
by Marvin 18 Jan '13

18 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23990 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: user32/tests: Test standard scrollbar's initialization (try 2).
by Sergey Guralnik 18 Jan '13

18 Jan '13

On 2013-01-15 12:27, Sergey Guralnik wrote: > I have no feedback yet. Is it not clear enough? -- Sergey

1 0

Re: po: Update Russian translation
by Dmitry Timoshkov 18 Jan '13

18 Jan '13

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > #: jscript.rc:40 > msgid "Can't have 'break' outside of loop" > -msgstr "Выражение 'break' не может находится вне цикла" > +msgstr "Оператор 'break' не может находится вне цикла" > > #: jscript.rc:41 > msgid "Can't have 'continue' outside of loop" > -msgstr "Выражение 'continue' не может находится вне цикла" > +msgstr "Оператор 'continue' не может находится вне цикла" It would be also nice to fix obvious spelling errors, it really hurts the eyes :) - "не может находит[ь]ся", and run spell checker for the whole translation. -- Dmitry.

1 0