January 2013 - Wine-devel - list.winehq.org

Re: [PATCH 4/5] ddraw: Only modify the ddraw destination window at the end of ddraw7_SetCooperativeLevel().
by Marvin 15 Jan '13

15 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23930 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] ddraw: Add a small tests for SetCooperativeLevel() calls with different windows.
by Marvin 15 Jan '13

15 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23929 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Wine Wiki needs your help!
by Dimi Paun 15 Jan '13

15 Jan '13

Yes it is done. Ill update the spreadsheet bit later... André Hentschel <nerv(a)dawncrow.de> wrote: >Am 14.01.2013 21:40, schrieb Andrew Eikum: >> On Mon, Jan 14, 2013 at 03:32:40PM -0500, Dimi Paun wrote: >>> OK, we might be onto something. I've wrote a script >>> to determine the deleted pages: 20162. >>> >>> Should I just go ahead and nuke those? >>> >> >> Probably, yes. >> >> One common way for spammers to abuse wikis is to intentionally get the >> pages deleted, so that they live on permanently in the revision >> history. >> >> See this example from today: >> It's rightfully deleted as spam: >> http://wiki.winehq.org/SheriOci >> But the "Get Info" link leads you to the old revision, with the >> linkspam intact: >> http://wiki.winehq.org/SheriOci?action=recall&rev=1 >> >> I don't know if there's a way to keep Moinmoin from preserving >> revision history on deleted pages, but it might be sufficient to >> simply disable that. I doubt there's much useful history on deleted >> pages anyway. > >seems done, and know what? The wiki seems to be more than 10 times faster. (i tried e.g. editing -> preview) >good choice! >Thanks Dimi for working on this!!! > > >-- > >Best Regards, André Hentschel

1 0

Re: [PATCH 5/5] d3d8/tests: Add a software vertexprocessing buffer discard test
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23928 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] d3d9/tests: Add a software vertexprocessing buffer discard test
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23926 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/5] d3d9/tests: Allow the creation of SWVP devices
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23925 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: comctl32/listview: fix icon spacing calculation [try 2]
by Nikolay Sivov 14 Jan '13

14 Jan '13

On 1/15/2013 00:53, Daniel Jelinski wrote: > + if(lParam == -1) > + return LISTVIEW_SetIconSpacing(infoPtr, -1, -1); > + return LISTVIEW_SetIconSpacing(infoPtr, LOWORD(lParam), HIWORD(lParam)); Why do you need to handle this case specially? If it's -1 for 64bit comctl32 it should give you the same values with HIWORD/LOWORD as it does for 32bit.

2 7

Patches for winspool.drv and other locations
by Detlef Riekenberg 14 Jan '13

14 Jan '13

Hi Tatyana Welcome to Wine. Wine has a test suite to make sure, that new code is correct. Example, what you never tested: > - if(!pDeviceName) { > + if(!pDeviceName && !*pDeviceName) { Your code will crash, when pDeviceName is NULL. I expect, you want to use a logical OR, but i did not test such a code change. -- By by ... Detlef

1 0

Re: user32/tests: Add test for SetScrollInfo().
by Alexandre Julliard 14 Jan '13

14 Jan '13

Sergey Guralnik <serhio(a)etersoft.ru> writes: > +static void test_setscrollinfo ( HWND hwnd, INT nBar ) > +{ > + SCROLLINFO cur, expected; > + char ok_format[] = "unexpected state: (bar: %d)\n" > + " expected: min: %d, max: %d, page: %d, pos: %d\n" > + " got: min: %d, max: %d, page: %d, pos: %d\n"; > +#define SCROLL_OK_ARGS nBar, \ > + expected.nMin, expected.nMax, expected.nPage, expected.nPos, \ > + cur.nMin, cur.nMax, cur.nPage, cur.nPos Please avoid that sort of macro abuse. Write an inline function if you don't want to duplicate the ok statement. -- Alexandre Julliard julliard(a)winehq.org

1 0

testbot
by Daniel Jelinski 14 Jan '13

14 Jan '13

Hello, the testbot does not revert patches submitted through testbot.winehq.org after testing. As a result it is almost impossible to test another patch affecting the same area in code as a previous one. Could anyone please fix it? Or at least add git reset to cron... Regards, Daniel

1 0