January 2013 - Wine-devel - list.winehq.org

Re: mshtml: Remove duplicated property entries in preprocess_dispex_data
by Marvin 16 Jan '13

16 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23961 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Reload a DLL and _getptd returns zero
by Michael Ost 16 Jan '13

16 Jan '13

On 01/12/2013 05:21 PM, Dan Kegel wrote: >> The library in question is using static vc runtime linkage, so _getptd() >> is linked in > > That's somewhat worrisome. So you have multiple instances > of the C runtime library active in the same app? > > Maybe you're not unloading that dll gracefully enough. > > Might be heap corruption. I wonder if Valgrind might be helpful. > > I second the suggestion to post a minimal testcase. Here's a link to a zip file that includes the prebuilt .exe and .dll windows binaries that crash in wine. Plus the code. https://dl.dropbox.com/u/97386125/msvcrt-dll-problem.zip So, again, the bug is that MSVCRT calls are failing when called from a DLL that has been reloaded. If the calls come from a thread and if the DLL is built with static MSVCRT runtimes. There is no crash for the program in Windows. I also tried rebuilding the code for winelib, and it doesn't appear to have the same behavior. So the problem doesn't happen if Wine's MSVCRT is used, only if a windows DLL that uses static MSVCRT linkage is reloaded. Thanks -- mo

2 5

Re: [12/15] kernel32/tests: Add ARM64 support
by Marvin 16 Jan '13

16 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23957 Your paranoid android. === WINEBUILD (build) === Making build dependencies failed

2 1

My Wine static analysis tool
by Damjan Jovanovic 15 Jan '13

15 Jan '13

Hi I've hacked together a simple tool for analyzing Wine code. Currently it can do the following: 1. Find BOOL functions returning non-BOOL. 2. Find HRESULT functions returning non-HRESULTs. 3. Generate a TRACE() for each function showing all its parameters. It isn't really a formal C parser, as it ignores all preprocessor directives, but this makes it *much* simpler and shorter than a real C parser, and it sees original Windows types like LPCWSTR etc. It's not 100% accurate, but it's very effective. 3 of my recent patches have been generated with its help - and I've barely gotten started. I'd like to add the following features at some stage: * Populate all functions with a TRACE() of their arguments, if they don't already have it. * Scan all GUIDs in include/ and generate a full list of all GUIDs and their names. Then patch debugstr_guid() to also output the name of the GUID when available, and/or search and replace GUIDs in WINEDEBUG traces after they've been recorded. * Update .spec files from .c file contents, and verify .spec file accuracy. * It could be extended to examine contents of functions and enforce the absence of W->A and 32->16 calls, etc. * etc. Anybody interested in using it or helping develop it? Regards Damjan

3 4

Re: [PATCH 1/5] dsound: rework ugly mixer logic
by Andrew Eikum 15 Jan '13

15 Jan '13

On Tue, Jan 15, 2013 at 06:51:59PM +0100, Maarten Lankhorst wrote: > Op 07-01-13 16:58, Andrew Eikum schreef: > > This patch breaks the sound on Zaxxon[1] on both CoreAudio and ALSA > > without PulseAudio. I didn't test OSS. It skips around on the ship's > > shooting noises. I've attached good and bad logs on ALSA here. > > > > [1] > > http://www.classic-retro-games.com/Zaxxon_70.html > > > I don't see anything suspicious in the log. Did it work after the complete patch series was applied or did you not test? Yeah, I was testing with the whole series when I found the problem, and rolled back patch-by-patch until I found that the first one caused it. Andrew

1 0

Re: gdi32/tests: GetTextExtentPoint should give repeatable results
by Alexandre Julliard 15 Jan '13

15 Jan '13

Daniel Jelinski <djelinski1(a)gmail.com> writes: > These are tests for bug 32529. Since commit ebaf5ea17623268fb1c0f68b1cf9a5984bd4e46e > (Don't load bitmap glyphs when using subpixel rendering in GetGlyphOutline) > GetTextExtentPoint returns different results before and after glyphs are loaded, > at least for wine's Tahoma. I don't see that here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok font.c:4818: Test succeeded inside todo block: extents different: first 76, second 76 -- Alexandre Julliard julliard(a)winehq.org

2 1

Truncate MIDI SysEx messages after termination byte
by Joerg-Cyril.Hoehle＠t-systems.com 15 Jan '13

15 Jan '13

Hi, Christian Costa wrote: >I took a look at the >alsa code and this code simply does not do what it is supposed to. I also looked at it today and noted those bogus lines you quote. Needs a patch (+ fix memory leak). However, Johannes' change is presumably different, as he wants to scan the buffer contents for a F7 terminator and ignore subsequent bytes. If I were to decide, I'd like to see more supporting evidence. I'd appreciate if Johannes would open a bug report and attach some WINEDEBUG=+midi,+mmdevapi,+alsa,+winmm,+driver,+tid,+timestamp logs to bugzilla, much like bug #26928. http://bugs.winehq.org/show_bug.cgi?id=26928 Having some logs with *complete* SysEx contents helps. There's also a "closed as abandoned" bug about microKORG http://bugs.winehq.org/show_bug.cgi?id=17608 which might be of interest to Johannes. Regards, Jörg Höhle

2 7

Re: [PATCH 2/5] d3d9/tests: Allow the creation of SWVP devices
by Henri Verbeet 15 Jan '13

15 Jan '13

On 15 January 2013 00:13, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > -static IDirect3DDevice9 *create_device(IDirect3D9 *d3d9, HWND device_window, HWND focus_window, BOOL windowed) > +static IDirect3DDevice9 *create_device(IDirect3D9 *d3d9, HWND device_window, HWND focus_window, BOOL windowed, > + DWORD flags) > { > D3DPRESENT_PARAMETERS present_parameters = {0}; > IDirect3DDevice9 *device; > @@ -90,7 +91,7 @@ static IDirect3DDevice9 *create_device(IDirect3D9 *d3d9, HWND device_window, HWN > present_parameters.AutoDepthStencilFormat = D3DFMT_D24S8; > > if (SUCCEEDED(IDirect3D9_CreateDevice(d3d9, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, focus_window, > - D3DCREATE_HARDWARE_VERTEXPROCESSING, &present_parameters, &device))) return device; > + flags, &present_parameters, &device))) return device; > If this fails, we're going to try hardware vertex processing again, but I don't think this is something we want to specify for every single test anyway. If this is just for a single test that needs software vertex processing, just write it out. If you already know there are going to be multiple tests like this, you could probably introduce a function like create_swvp_device().

2 1

Re: [PATCH 3/3] d3d8/tests: Add a software vertexprocessing buffer discard test (try 2)
by Marvin 15 Jan '13

15 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23943 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/3] mshtml: Added IHTMLScriptElement::put_text tests
by Marvin 15 Jan '13

15 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23941 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0