November 2013 - Wine-devel - list.winehq.org

Re: [2/3] quartz: Partial implementation of VMR7MonitorConfig
by Alexandre Julliard 11 Nov '13

11 Nov '13

Michael Müller <michael(a)fds-team.de> writes: > + mode.dmSize = sizeof(DEVMODEW); > + mode.dmDriverExtra = 0; > + > + if (!EnumDisplaySettingsExW(device.DeviceName, ENUM_CURRENT_SETTINGS, &mode, EDS_RAWMODE)) > + continue; > + > + memset(info, 0, sizeof(VMRMONITORINFO)); > + > + info->guid.pGUID = NULL; /* default DirectDraw device */ > + > + info->rcMonitor.left = mode.u1.s2.dmPosition.x; > + info->rcMonitor.top = mode.u1.s2.dmPosition.y; > + info->rcMonitor.right = mode.u1.s2.dmPosition.x + mode.dmPelsWidth; > + info->rcMonitor.bottom = mode.u1.s2.dmPosition.y + mode.dmPelsHeight; > + > + info->hMon = 0; /* FIXME: return monitor handle */ > + info->dwFlags = (device.StateFlags & DISPLAY_DEVICE_PRIMARY_DEVICE) ? MONITORINFOF_PRIMARY : 0; > + > + lstrcpynW(info->szDevice, device.DeviceName, sizeof(info->szDevice)/sizeof(WCHAR)); > + lstrcpynW(info->szDescription, device.DeviceString, sizeof(info->szDescription)/sizeof(WCHAR)); > + > + count++; > + info++; EnumDisplayMonitors would probably be more appropriate. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/4] winex11: Send XEMBED_REQUEST_FOCUS request for embedded windows
by Alexandre Julliard 11 Nov '13

11 Nov '13

Sebastian Lackner <sebastian(a)fds-team.de> writes: > @@ -1140,6 +1140,22 @@ void make_window_embedded( struct x11drv_win_data *data ) > set_xembed_flags( data, (data->mapped || data->embedder) ? XEMBED_MAPPED : 0 ); > } > > +/*********************************************************************** > + * get_ancestor_root_embedded > + */ > +HWND get_ancestor_root_embedded( HWND hwnd ) > +{ > + HWND parent; > + if (!hwnd) return NULL; > + for (;;) > + { > + parent = GetAncestor(hwnd, GA_PARENT); > + if (!parent || parent == GetDesktopWindow() || (Window)GetPropA( parent, foreign_window_prop )) > + break; > + hwnd = parent; > + } > + return hwnd; > +} It would be better to check for the embedded flag instead of retrieving a bunch of window properties. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] kernel32: Add tests for creating directories with specific security attributes.
by Dmitry Timoshkov 11 Nov '13

11 Nov '13

"Erich E. Hoover" <erich.e.hoover(a)gmail.com> wrote: > Currently CreateDirectory mostly ignores the security attributes on > directories. This patch adds some tests for what happens when these > attributes are present and part 2 adds support for setting these > attributes. This patch duplicates already existing tests in dlls/advapi32/tests/security.c. -- Dmitry.

2 2

Re: urlmon: Compile tests with -D__WINESRC__.
by Dmitry Timoshkov 11 Nov '13

11 Nov '13

Jacek Caban <jacek(a)codeweavers.com> wrote: > - expectedLen = lstrlen(prop.value); > - brokenLen = lstrlen(prop.broken_value); > + expectedLen = lstrlenA(prop.value); > > /* This won't be necessary once GetPropertyLength is implemented. */ > receivedLen = -1; > @@ -8145,14 +8144,14 @@ static void test_IUri_GetPropertyLength(void) { > hr, prop.expected, i, j); > } > todo_wine { > - ok(receivedLen == expectedLen || broken(receivedLen == brokenLen), > + ok(receivedLen == expectedLen || broken(prop.broken_value && receivedLen == lstrlenA(prop.broken_value)), Please don't use lstrlenA in the tests. -- Dmitry.

3 8

Re: comctl32: Fix handling of NULL text for TTM_ADDTOOLW.
by Alexandre Julliard 11 Nov '13

11 Nov '13

Francois Gouget <fgouget(a)free.fr> writes: > --- > > The __WINESRC__ patch introduced a new failure on all Windows platforms: > http://test.winehq.org/data/tests/comctl32:tooltips.html > > Apparently passing a NULL string is ok with the ANSI version, but not > with the Unicode one. > > dlls/comctl32/tests/tooltips.c | 2 +- > dlls/comctl32/tooltips.c | 47 +++++++++++++++++++++++------------------- > 2 files changed, 27 insertions(+), 22 deletions(-) It breaks other tests: ../../../tools/runtest -q -P wine -T ../../.. -M comctl32.dll -p comctl32_test.exe.so status.c && touch status.ok status.c:421: Test failed: Expected Tooltip Text, got make[1]: *** [status.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] quartz: Partial implementation of VMR7MonitorConfig
by Michael Stefaniuc 11 Nov '13

11 Nov '13

Hello Michael, On 11/11/2013 01:26 AM, Michael Müller wrote: > --- > dlls/quartz/vmr9.c | 70 > +++++++++++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 64 insertions(+), 6 deletions(-) > > > > 0015-quartz-Partial-implementation-of-VMR7MonitorConfig.txt > > > From beed64a33606fd3de77f41708f8a2b590521ea51 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Michael=20M=C3=BCller?= <michael(a)fds-team.de> > Date: Sun, 10 Nov 2013 21:40:10 +0100 > Subject: quartz: Partial implementation of VMR7MonitorConfig > > --- > dlls/quartz/vmr9.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 64 insertions(+), 6 deletions(-) > > diff --git a/dlls/quartz/vmr9.c b/dlls/quartz/vmr9.c > index 0acdd26..6b2970b 100644 > --- a/dlls/quartz/vmr9.c > +++ b/dlls/quartz/vmr9.c > static HRESULT WINAPI VMR7MonitorConfig_GetAvailableMonitors(IVMRMonitorConfig *iface, > @@ -1342,9 +1350,59 @@ static HRESULT WINAPI VMR7MonitorConfig_GetAvailableMonitors(IVMRMonitorConfig * > DWORD *numdev) > { a better approach is to put the implementation into VMR9MonitorConfig_GetAvailableMonitors and just forward VMR7MonitorConfig_GetAvailableMonitors to it. Of course only if there is an easy way to translate between a VMRGUID from VMR7 ro a uDevID from VMR9. > struct quartz_vmr *This = impl_from_IVMRMonitorConfig(iface); > + DISPLAY_DEVICEW device; > + DWORD devnum, count; > + DEVMODEW mode; > > - FIXME("(%p/%p)->(%p, %u, %p) stub\n", iface, This, info, arraysize, numdev); > - return E_NOTIMPL; > + FIXME("(%p/%p)->(%p, %u, %p) semi-stub\n", iface, This, info, arraysize, numdev); > + > + if (!numdev) > + return E_POINTER; > + > + device.cb = sizeof(DISPLAY_DEVICEW); > + > + /* return the number of available monitors if info == NULL */ > + if (info == NULL) > + { > + for (devnum = 0; EnumDisplayDevicesW(NULL, devnum, &device, 0); ++devnum); > + *numdev = devnum; > + return S_OK; > + } > + > + /* at least one entry */ > + if (arraysize == 0) > + return E_INVALIDARG; > + > + for (count = 0, devnum = 0; count < arraysize && EnumDisplayDevicesW(NULL, devnum, &device, 0); ++devnum) > + { > + > + mode.dmSize = sizeof(DEVMODEW); > + mode.dmDriverExtra = 0; > + > + if (!EnumDisplaySettingsExW(device.DeviceName, ENUM_CURRENT_SETTINGS, &mode, EDS_RAWMODE)) > + continue; > + > + memset(info, 0, sizeof(VMRMONITORINFO)); > + > + info->guid.pGUID = NULL; /* default DirectDraw device */ > + > + info->rcMonitor.left = mode.u1.s2.dmPosition.x; > + info->rcMonitor.top = mode.u1.s2.dmPosition.y; > + info->rcMonitor.right = mode.u1.s2.dmPosition.x + mode.dmPelsWidth; > + info->rcMonitor.bottom = mode.u1.s2.dmPosition.y + mode.dmPelsHeight; > + > + info->hMon = 0; /* FIXME: return monitor handle */ > + info->dwFlags = (device.StateFlags & DISPLAY_DEVICE_PRIMARY_DEVICE) ? MONITORINFOF_PRIMARY : 0; > + > + lstrcpynW(info->szDevice, device.DeviceName, sizeof(info->szDevice)/sizeof(WCHAR)); > + lstrcpynW(info->szDescription, device.DeviceString, sizeof(info->szDescription)/sizeof(WCHAR)); > + > + count++; > + info++; > + } > + > + *numdev = count; > + return S_OK; > } > > static const IVMRMonitorConfigVtbl VMR7_MonitorConfig_Vtbl = > -- 1.7.9.5 bye michael

1 0

Re: comctl32: improve GUI error messages
by Nikolay Sivov 10 Nov '13

10 Nov '13

On Wed, Nov 6, 2013 at 11:55 PM, Austin English <austinenglish(a)gmail.com>wrote: > Requested by Focht. Fixes http://bugs.winehq.org/show_bug.cgi?id=34850 > > -- > -Austin > > > > I think it's better to start with real implementation. We'll need it sooner or later.

1 0

using mono dll components on wine(C#)
by Akira Nakagawa 09 Nov '13

09 Nov '13

I do not know how to use COM classes on wine lib,for example , System.dll wine dlls should be written by C,but I found many .Net methods equivalent to Win32 APIs.You can implement methods easily. (for example, ClearEventLog () in advapi32.dll by Eventlog.Clear() in System.Diagnostics) Isn't this good idea?

2 1

Implemention of HANDLE type in OpenEventLog func
by Akira Nakagawa 09 Nov '13

09 Nov '13

I cannot find any reference of implementation of HANDLE type that returned by OpenEventLog(). Is there any records?If so,it's OK to define it by us own.

2 1

Re: [PATCH 2/2] advapi32: HKCR merge: added path management
by George Stephanos 08 Nov '13

08 Nov '13

1 0