November 2013 - Wine-devel - list.winehq.org

Re: riched20: Implement ITextDocument_fnOpen. (try 2)
by Nikolay Sivov 18 Nov '13

18 Nov '13

On 11/18/2013 16:02, Jactry Zeng wrote: > update: > 1. Use 0 in HeapAlloc instead of HEAP_ZERO_MEMORY; > 2. Return an E_OUTOFMEMORY instead of HRESULT_FROM_WIN32(GetLastError()) > when HeapAlloc fail. > + FIXME("Don't support UTF-16.\n"); How is supposed to be handled? > + FIXME("Partial stub! Don't support flag: 0x%x\n", Flags); At least some flags are easy to support mapping them to sharing and creation disposition modes. > + chBuffer = HeapAlloc(GetProcessHeap(), 0, size+1); > + if(!chBuffer) > + { > + CloseHandle(hFile); > + return E_OUTOFMEMORY; > + } > + > + if(!ReadFile(hFile, chBuffer, size, &dwReadSize, NULL)) > + { > + CloseHandle(hFile); > + HeapFree(GetProcessHeap(), 0, chBuffer); > + return HRESULT_FROM_WIN32(GetLastError()); > + } > + chBuffer[size] = 0; How will it work for UTF-16 input? > + SendMessageW(This->editor->hWnd, EM_SETTEXTEX, (int)&settextex, (LPARAM)chBuffer); > + CloseHandle(hFile); > + > + return S_OK; Looks like you leak a buffer.

2 1

Re: gdiplus: Implement GdipCreateRegionRgnData.
by Marvin 18 Nov '13

18 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3433 Your paranoid android. === wxppro (32 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 === wvista (32 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 === w2008s64 (32 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 === w7pro64 (32 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 region.c:623: Test failed: data mismatch region.c:774: Test failed: data mismatch === w8 (32 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 region.c:623: Test failed: data mismatch region.c:774: Test failed: data mismatch === w864 (32 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 region.c:623: Test failed: data mismatch region.c:774: Test failed: data mismatch === w2008s64 (64 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 === w7pro64 (64 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 region.c:774: Test failed: data mismatch === w864 (64 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 region.c:774: Test failed: data mismatch

1 0

Re: [PATCH] ddraw: add dsurface dimension tests
by Marvin 17 Nov '13

17 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3418 Your paranoid android. === wxppro (32 bit dsurface) === dsurface.c:2604: Test failed: Creating an offscreen plain surface with width 0xffff and height 1 returned 80070057 dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 88760233 === wvista (32 bit dsurface) === dsurface.c:2604: Test failed: Creating an offscreen plain surface with width 0xffff and height 1 returned 80070057 dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 88760233 === w2008s64 (32 bit dsurface) === dsurface.c:2604: Test failed: Creating an offscreen plain surface with width 0xffff and height 1 returned 80070057 dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 88760233 === w7pro64 (32 bit dsurface) === dsurface.c:2604: Test failed: Creating an offscreen plain surface with width 0xffff and height 1 returned 80070057 dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 88760233 === w8 (32 bit dsurface) === dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 8876017c === w864 (32 bit dsurface) === dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 8876017c === w2008s64 (64 bit dsurface) === dsurface.c:2604: Test failed: Creating an offscreen plain surface with width 0xffff and height 1 returned 80070057 dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 88760233 === w7pro64 (64 bit dsurface) === dsurface.c:2604: Test failed: Creating an offscreen plain surface with width 0xffff and height 1 returned 80070057 dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 88760233 === w864 (64 bit dsurface) === dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 8876017c

1 0

Re: Use BOOL type where appropriate (Patches 100478 and 100479) are wrong for localspl
by Detlef Riekenberg 17 Nov '13

17 Nov '13

Hi Frederic. BOOL is not correct for localspl.dll. Next to 0 and 1 you can get a 2 on some machines (This depends on additional installed print-monitors) Quote from includes/ddk/winsplp.h: #define ROUTER_UNKNOWN 0 #define ROUTER_SUCCESS 1 #define ROUTER_STOP_ROUTING 2 /* * WARNING: Many Functions are declared as "BOOL", but return ROUTER_* */ -- By by ... Detlef

1 0

Re: [PATCH] wintrust/tests: Accept the CryptCATAdminAcquireContext win8 results
by Marvin 17 Nov '13

17 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3414 Your paranoid android. === w8 (32 bit crypt) === crypt.c:554: Test failed: got 11 expected ERROR_INVALID_PARAMETER

1 0

Re: [PATCH 2/2] msxml3: Compile tests with __WINESRC__ defined.
by Marvin 16 Nov '13

16 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3408 Your paranoid android. === w8 (32 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00462D8C === wxppro (32 bit domdoc) === domdoc.c:9843: Test failed: got 00244F94 === w8 (32 bit domdoc) === domdoc.c:9843: Test failed: got 002F7394

1 0

Re: [PATCH 1/2] msxml3: Return NULL instead of empty string in IXMLElement::get_tagName.
by Marvin 16 Nov '13

16 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3407 Your paranoid android. === w8 (32 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00462DCC

1 0

Re: msxml3: Compile tests with __WINESRC__ defined.
by Marvin 16 Nov '13

16 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3405 Your paranoid android. === wxppro (32 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00463F3D === wvista (32 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00463F3D === w2008s64 (32 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00463F3D === w7pro64 (32 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00463F3D === w8 (32 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00463F3D === w864 (32 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00463F3D === w2008s64 (64 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00000000004584D4 === w7pro64 (64 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00000000004584D4 === w864 (64 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00000000004584D4 === wxppro (32 bit domdoc) === domdoc.c:9843: Test failed: got 00244F94 === w8 (32 bit domdoc) === domdoc.c:9843: Test failed: got 00301F24

1 0

Re: [PATCH] winex11: add virtual desktop mode 320x240
by Henri Verbeet 15 Nov '13

15 Nov '13

On 14 November 2013 10:25, Patrick Rudolph <siro(a)das-labor.org> wrote: > This patch adds support for display mode 320x240. Without this patch > DDraw:SetDisplayMode fails to set the virtual desktop window to 320x240. > Can you actually set 320x240 on Windows through e.g. ChangeDisplaySettingsEx()? I have the impression that this mode may be internal to ddraw.

1 0

win9x mode gone
by Damian Ivanov 15 Nov '13

15 Nov '13

Hi, In my recent installation on openSUSE 13.1 with wine 1.7.6 I can't find wine to set winver=win95 only nt based systems are available but with them my app crashes that it needs win95 Is win9x version gone in recent versions? Is it gone because of 64bit OS?

4 7