December 2013 - Wine-devel - list.winehq.org

Re: [PATCH 1/4] d3d9/tests: Test user memory with D3DPOOL_SCRATCH.
by Henri Verbeet 09 Dec '13

09 Dec '13

On 9 December 2013 13:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > The undocumented d3d9ex managed pool with enum value 6 does not allow > user memory textures either. I'm not including tests for that yet > until our d3d9 can handle this pool. I'm not quite sure I see the point of this test. The way the docs say this works is that in the general case resource sharing only works with default pool resources. Creating system memory textures with user memory backing is an exception to that. So I'd expect this test to fail in the first place because the resource is not in the default pool, and in the second place because the handle you're passing is most likely not a valid resource handle.

1 0

Re: [PATCH 2/4] d3d9: Volume and cube textures do not support user memory (try 2).
by Henri Verbeet 09 Dec '13

09 Dec '13

On 9 December 2013 13:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > if (shared_handle) > + { > + if (pool != D3DPOOL_DEFAULT) > + { > + WARN("User memory is not allowed on volume textures.\n"); Similarly, I don't think this warning really represent what's going on. The issue is that resource sharing is only allowed with default pool resources. (And quite possibly only on d3d9ex devices.)

1 0

Mobile version input methods (on-screen buttons, keyboards, virtual joysticks)
by WineBuG 08 Dec '13

08 Dec '13

How would you deal with lack of the keyboard and mouse in the future ARM (Android) version of Wine? Will one be able to add virtual on-screen buttons and joysticks in some way? Are you going to analyze controls solutions of other mobile apps (for example, games)? Regards, WineBuG

1 0

Build issues with winemac.drv and Mavericks
by C.W. Betts 08 Dec '13

08 Dec '13

I’ve run into issues when building winemac.drv on Mavericks. Attached is the log.

3 3

Mobile version input methods (on-screen buttons, keyboards, virtual joysticks)
by WineBuG 07 Dec '13

07 Dec '13

How would cope with lack of the keyboard and mouse in the future ARM (Android) version of Wine? Will one be able to add virtual on-screen buttons and joysticks in some way? Are you going to analyze other mobile apps (for example, games) controls solutions? Regards, WineBuG

1 0

Re: [PATCH] user32: Don't send message to get window text, avoid a deadlock.
by Dmitry Timoshkov 07 Dec '13

07 Dec '13

Qian Hong <qhong(a)codeweavers.com> wrote: > - Fixed http://bugs.winehq.org/show_bug.cgi?id=27282, affects Arcania: > Gothic 4 and online bank of abchina and > - Makes Anastasius happy :p This patch needs at least some tests. -- Dmitry.

2 1

Re: [PATCH 2/5] ole32: Simplify enumeration cloning using duplicated key
by Alexandre Julliard 06 Dec '13

06 Dec '13

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > - new_this->IEnumCATEGORYINFO_iface = This->IEnumCATEGORYINFO_iface; > - new_this->ref = 1; > - new_this->lcid = This->lcid; > - /* FIXME: could we more efficiently use DuplicateHandle? */ > - open_classes_key(HKEY_CLASSES_ROOT, keyname, KEY_READ, &new_this->key); > - new_this->next_index = This->next_index; > + cloned->IEnumCATEGORYINFO_iface = This->IEnumCATEGORYINFO_iface; > + cloned->ref = 1; > + cloned->lcid = This->lcid; > > - *ppenum = &new_this->IEnumCATEGORYINFO_iface; > + if (!DuplicateHandle(GetCurrentProcess(), This->key, GetCurrentProcess(), (HANDLE*)&cloned->key, 0, FALSE, DUPLICATE_SAME_ACCESS)) > + { > + IEnumCATEGORYINFO_Release(&cloned->IEnumCATEGORYINFO_iface); > + return E_FAIL; > + } Using DuplicateHandle is not a good idea on registry keys, particularly for HKEY_CLASSES_ROOT keys. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shell32/tests: Use GetVersion() to skip Timeout test (try 2)
by Nikolay Sivov 06 Dec '13

06 Dec '13

On 12/6/2013 09:10, Zhenbo Li wrote: > I'm using win_skip() for Vista&Win2008 this time. > > --- > dlls/shell32/tests/shlfileop.c | 36 +++++++++++++++++++----------------- > 1 file changed, 19 insertions(+), 17 deletions(-) > > Hm, it's the same issue. Please don't use GetVersion().

1 0

Re: shell32/tests: Use GetVersion() to skip Timeout test (try 2)
by Marvin 06 Dec '13

06 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3671 Your paranoid android. === wvista (32 bit shlfileop) === Timeout === w2008s64 (32 bit shlfileop) === Timeout === w2008s64 (64 bit shlfileop) === Timeout

1 0

Re: wined3d: Use BOOL type where appropriate
by Henri Verbeet 06 Dec '13

06 Dec '13

On 5 December 2013 23:14, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > Note: in surface.c, used "?1:0" construct to avoid implicit BOOL arithmetic > --- > dlls/wined3d/arb_program_shader.c | 19 +++++++++---------- > dlls/wined3d/context.c | 20 ++++++++++---------- > dlls/wined3d/device.c | 2 +- > dlls/wined3d/gl_compat.c | 4 ++-- > dlls/wined3d/shader.c | 20 ++++++++++---------- > dlls/wined3d/stateblock.c | 22 +++++++++++----------- > dlls/wined3d/surface.c | 8 ++++---- > dlls/wined3d/utils.c | 8 ++++---- > 8 files changed, 51 insertions(+), 52 deletions(-) > I don't think so, most of these are bitfields, and the surface.c change is actually making the code worse.

1 0