December 2013 - Wine-devel - list.winehq.org

Re: wined3d: Ensure wined3d_ftoa() exponent is 2 digits on Windows.
by Henri Verbeet 14 Dec '13

14 Dec '13

On 14 December 2013 06:28, Jonathan Liu <net147(a)gmail.com> wrote: > > This fixes a regression introduced by commit > 12f16f2127ffce9a05eedf008c3aa3732751a7e3 where the returned exponent > is 3 digits on Windows instead of 2 digits which results in rendering > errors. The printf implementation in the Microsoft Visual C runtime > uses three digits for the exponent by default. > If the issue here is that the buffers the callers pass are too small, I think that's what should be fixed, perhaps with a comment added to wined3d_ftoa(). Ideally we wouldn't use fixed size buffers there to begin with though.

1 0

Re: winealsa.drv: midiSeq must be protected by a mutex
by Alexandre Julliard 13 Dec '13

13 Dec '13

Alexandre Bique <bique.alexandre(a)gmail.com> writes: > @@ -95,6 +95,7 @@ static int MODM_NumDevs = 0; > /* this is the total number of MIDI out devices found */ > static int MIDM_NumDevs = 0; > > +static CRITICAL_SECTION midiSeqLock = { NULL, -1, 0, 0, 0, 0 }; Please add debug information like it's done in other places. -- Alexandre Julliard julliard(a)winehq.org

1 0

Bugzilla attachment links arriving with &action=edit
by Bruno Jesus 13 Dec '13

13 Dec '13

Hi all, since the update yesterday all links in emails received from the bugzilla have the action=edit so it's not no longer possible to directly open the attachements. Examples: --- Comment #8 from The Source <xxx(a)mail.ru> --- Created attachment 46837 --> http://bugs.winehq.org/attachment.cgi?id=46837&action=edit Launcher log (local.log) --- Comment #1 from Bruno Jesus <xxx(a)gmail.com> --- Created attachment 46835 --> http://bugs.winehq.org/attachment.cgi?id=46835&action=edit standard output --- Comment #3 from Travis Greenman <xxx(a)cartman-2000.net > --- Created attachment 46833 --> http://bugs.winehq.org/attachment.cgi?id=46833&action=edit Console output, with gl error and nvidia-smi output. Regards, Bruno

8 11

Re: [PATCH 3/5] ddraw: Change surface pitch before width.
by Henri Verbeet 13 Dec '13

13 Dec '13

On 13 December 2013 12:30, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + switch(hr) > + { > + case WINED3DERR_INVALIDCALL: > + wined3d_mutex_unlock(); > + return DDERR_INVALIDPARAMS; > + default: > + break; /* Go on */ > + } That's called hr_ddraw_from_wined3d(). On its own this patch is perhaps innocent enough, but it looks like this is supposed to make 4/5 safe, in which case that patch ends up depending on a somewhat obscure implementation detail. I think it may be better to merge wined3d_surface_set_mem() into wined3d_surface_update_desc(), at least as far as the public interface is concerned. (And in the long term we really want that to be wined3d_texture_update_desc().)

2 3

Re: [PATCH] ddraw: add dsurface dimension tests, try 4
by Marvin 13 Dec '13

13 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3751 Your paranoid android. === build (build) === Patch failed to apply

1 0

Firefox says mirrors.ibiblio.org is a reported attack page
by Rosanne DiMesio 12 Dec '13

12 Dec '13

A forum user reported that they got a "Reported Attack Page!" warning when they tried to download the Wine source tarball from mirrors.ibiblio.org. I checked, and I got the warning from Firefox, too. Chrome and Opera don't have a problem going to the site from the link here, but googling ibiblio.org brings up a warning that "This site may harm your computer" in all three browsers. -- Rosanne DiMesio <dimesio(a)earthlink.net>

1 0

Re: kernel32/tests: Remove some expected values for test_DeleteFileA()
by Dmitry Timoshkov 12 Dec '13

12 Dec '13

Zhenbo Li <litimetal(a)gmail.com> wrote: > There're too many expected values from GetLastError(), and I think it > might be confusing. Usually there was a reason why there are so many different results in ok() statements, it would be a good idea to check git history and find out that reasons it out instead of simply declaring them as confusing and removing them altogether. -- Dmitry.

2 1

Re: [3/4] secur32/tests: Add a test for QueryCredentialsAttributes(SECPKG_CRED_ATTR_NAMES). Take 2.
by Nikolay Sivov 12 Dec '13

12 Dec '13

On 12/12/2013 09:13, Dmitry Timoshkov wrote: > + > + st = pQueryCredentialsAttributesA(&cred, SECPKG_CRED_ATTR_NAMES, &names); > + ok(st == SEC_E_NO_CREDENTIALS || st == SEC_E_UNSUPPORTED_FUNCTION /* before Vista */, "expected SEC_E_NO_CREDENTIALS, got %08x\n", st); > + Second possible return code should be broken(), otherwise your code change in next patch won't make any effect on tests.

2 5

Re: [PATCH 3/6] d3d9/tests: Test user memory and getdc interaction.
by Henri Verbeet 11 Dec '13

11 Dec '13

On 11 December 2013 12:22, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + data = HeapAlloc(GetProcessHeap(), 0, sizeof(data) * 16 * 16); > + memset(data, 0xaa, sizeof(data) * 16 * 16); I think you meant "sizeof(*data)" here.

2 1

Re: [2/2] programs/msiexec: MSI service should report SERVICE_STOPPED when appropriate.
by André Hentschel 11 Dec '13

11 Dec '13

Am 11.12.2013 09:16, schrieb Dmitry Timoshkov: > --- > programs/msiexec/service.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/programs/msiexec/service.c b/programs/msiexec/service.c > index 4b72fe0..fdd29bd 100644 > --- a/programs/msiexec/service.c > +++ b/programs/msiexec/service.c > @@ -81,6 +81,8 @@ static BOOL UpdateSCMStatus(DWORD dwCurrentState, DWORD dwWin32ExitCode, > > static void WINAPI ServiceCtrlHandler(DWORD code) > { > + DWORD state = SERVICE_RUNNING; > + > WINE_TRACE("%d\n", code); > > switch (code) > @@ -89,13 +91,14 @@ static void WINAPI ServiceCtrlHandler(DWORD code) > case SERVICE_CONTROL_STOP: > UpdateSCMStatus(SERVICE_STOP_PENDING, NO_ERROR, 0); > KillService(); > + state = SERVICE_STOPPED; > return; Hi, setting the variable here seems to have no effect i just have seen that from the patch without a look at the code, so i still might be wrong...

1 0