December 2013 - Wine-devel - list.winehq.org

Re: [PATCH 1/5] d3d9/tests: Test user memory with D3DPOOL_SCRATCH (try 3).
by Marvin 11 Dec '13

11 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3705 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3d9: shared_handle must be NULL in non-ex d3d9.
by Marvin 11 Dec '13

11 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3704 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d9: Implement user memory for offscreen plain surfaces (try 3).
by Marvin 11 Dec '13

11 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3703 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] d3d9: Buffers do not support user memory (try 3).
by Marvin 11 Dec '13

11 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3702 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/5] d3d9: Volume and cube textures do not support user memory (try 3).
by Marvin 10 Dec '13

10 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3701 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [1/2] gdi32: Return ANSI character code as glyph index for bitmap fonts.
by Alexandre Julliard 10 Dec '13

10 Dec '13

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > @@ -5975,7 +5975,7 @@ static FT_UInt get_GSUB_vert_glyph(const GdiFont *font, UINT glyph) > return GSUB_apply_feature(header, feature, glyph); > } > > -static FT_UInt get_glyph_index(const GdiFont *font, UINT glyph) > +static FT_UInt get_glyph_index(const GdiFont *font, UINT glyph, BOOL ret_char_code) > { > FT_UInt glyphId; > It would be better to have a separate function instead of having the same function return two different types of index. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include: Add taskschd.idl.
by Jacek Caban 10 Dec '13

10 Dec '13

Hi Dmitry, On 12/10/13 10:12, Dmitry Timoshkov wrote: > + HRESULT get_Connected([out, retval] VARIANT_BOOL *connected); > + HRESULT get_TargetServer([out, retval] BSTR *server); > + HRESULT get_ConnectedUser([out, retval] BSTR *user); > + HRESULT get_ConnectedDomain([out, retval] BSTR *domain); > + HRESULT get_HighestVersion([out, retval] DWORD *version); Those should use [propget] attribute instead of explicit get_* prefix. Same for other get_* and put_* methods (with [propput]). Cheers, Jacek

1 0

Re: [PATCH 1/5] d3d9/tests: Test user memory with D3DPOOL_SCRATCH (try 2).
by Henri Verbeet 10 Dec '13

10 Dec '13

On 10 December 2013 12:23, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @Henri: I'm not sure what kind of control flow you had in mind here. The > best understanding I could come up with was a nested if (first check for > D3DPOOL_DEFAULT, then handle the D3DPOOL_SYSTEMEM special case), which I > think is ugly. I removed the case check for D3DPOOL_SCRATCH, at the cost > of not writing a visible FIXME for pool 0x6. ... > if (shared_handle) > { > - if (pool == D3DPOOL_SYSTEMMEM) > + switch (pool) > { > - if (levels != 1) > + case D3DPOOL_DEFAULT: > + FIXME("Resource sharing not implemented, *shared_handle %p.\n", *shared_handle); > + break; > + > + case D3DPOOL_SYSTEMMEM: > + if (levels != 1) > + { > + WARN("Trying to create a mipmapped user memory texture.\n"); > + return D3DERR_INVALIDCALL; > + } > + set_mem = TRUE; > + break; > + > + default: > + WARN("Trying to create a texture with pool %#x and shared_handle %p.\n", > + pool, shared_handle); > return D3DERR_INVALIDCALL; > - set_mem = TRUE; > } > - else > - FIXME("Resource sharing not implemented, *shared_handle %p.\n", *shared_handle); > } > + { + if (pool != D3DPOOL_DEFAULT) + { + WARN("Trying to create a shared texture in pool %#x.\n", pool); + return D3DERR_INVALIDCALL; + } FIXME("Resource sharing not implemented, *shared_handle %p.\n", *shared_handle); + }

1 0

Re: [PATCH 1/5] d3d9/tests: Test user memory with D3DPOOL_SCRATCH (try 2).
by Marvin 10 Dec '13

10 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3700 Your paranoid android. === build (build) === Could not copy the patch to the VM: Unable to connect to testnet.winehq.org:22001:10.42.42.130:4242: No route to host

1 0

Implementing msvcrt.__CxxFrameHandler
by Alexandre Bique 09 Dec '13

09 Dec '13

Hi, I found that __CxxFrameHandler is not implemented for wine64, and I'd like to fix this because I think it is the reason why Ableton Live 9.1 is crashing at start up. If someone can implement it, then it is great! Otherwise if someone can give me guidelines, I can try to understand how it works and do it myself. Here is a previous email talking about this: http://www.winehq.org/pipermail/wine-devel/2011-April/089617.html Here is the bug about Ableton Live 9.1: http://bugs.winehq.org/show_bug.cgi?id=35092 Regards, -- Alexandre Bique

1 0