March 2013 - Wine-devel - list.winehq.org

Re: [website] Simplified Chinese translation for release 1.5.27
by Qian Hong 30 Mar '13

30 Mar '13

Hi Jactry, 2013/3/30 Jactry Zeng <jactry92(a)gmail.com>: > + <li>一些 C 运行时的改进。</li> I think it is better to translate "C runtime" to “C 运行时库“ rather than just ”C 运行时“。 + <li>为内建程序提供更高质量的图标。</li> Large icon means 大图标，not 高质量图标。You can verify this by the git commits。 Thanks for the work. -- Regards, Qian Hong - http://www.winehq.org

3 4

Re: [PATCH 1/3] jscript: Use helpers to access string buffers in jsregexp.c.
by Alexandre Julliard 29 Mar '13

29 Mar '13

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/jscript/jsregexp.c | 114 > +++++++++++++++++++++++++++++++----------------- > 1 file changed, 73 insertions(+), 41 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M jscript.dll -T ../../.. -p jscript_test.exe.so run.c && touch run.ok run.c:1804: Test failed: expected global_success_d run.c:1805: Test failed: expected global_success_i run.c:1807: Test failed: parse_script failed: 80004005 run.c:1804: Test failed: expected global_success_d run.c:1805: Test failed: expected global_success_i run.c:1807: Test failed: parse_script failed: 80004005 run.c:1804: Test failed: expected global_success_d run.c:1805: Test failed: expected global_success_i run.c:1807: Test failed: parse_script failed: 80004005 run.c:1804: Test failed: expected global_success_d run.c:1805: Test failed: expected global_success_i run.c:1807: Test failed: parse_script failed: 80004005 run.c:1804: Test failed: expected global_success_d run.c:1805: Test failed: expected global_success_i run.c:1807: Test failed: parse_script failed: 80004005 run.c:1804: Test failed: expected global_success_d run.c:1805: Test failed: expected global_success_i run.c:1807: Test failed: parse_script failed: 80004005 make: *** [run.ok] Error 18 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9 [patch 1/2, try 4]: Implement D3DXSHEvalSphericalLight
by Alexandre Julliard 29 Mar '13

29 Mar '13

Nozomi Kodama <nozomi.kodama(a)yahoo.com> writes: > From bb40ba80a24a954d21c44cbe55b4b9c79e2087c5 Mon Sep 17 00:00:00 2001 > From: "nozomi.kodama" <nozomi.kodama(a)yahoo.com> > Date: Wed, 27 Mar 2013 22:38:51 -1000 > Subject: d3dx9: Implement D3DXSHEvalSphericalLight It still fails the same way... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcp110: Add VS2012 C/C++ runtime
by Piotr Caban 29 Mar '13

29 Mar '13

On 03/28/13 23:22, Stefan Leichter wrote: > --- > configure.ac | 1 + > dlls/msvcp110/Makefile.in | 5 + > dlls/msvcp110/msvcp110.c | 37 + > dlls/msvcp110/msvcp110.spec | 3900 > +++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 3943 insertions(+), 0 deletions(-) > create mode 100644 dlls/msvcp110/Makefile.in > create mode 100644 dlls/msvcp110/msvcp110.c > create mode 100644 dlls/msvcp110/msvcp110.spec You can use tools/make_specfiles script to generate forwards to other msvcpXX dlls. The script will generate big parts of the spec file differently (because it prefers to forward to msvcp90, not to msvcp100).

1 0

Re: [PATCH 1/3] extrac32: Implement more strict command line processing.
by Sergey Guralnik 29 Mar '13

29 Mar '13

On 2013-03-26 10:17, Sergey Guralnik wrote: > Is some problem with this series? -- Sergey

1 0

Re: gdi32: Copy gamma ramp validation from winex11 to make it driver independent (try 2)
by Alexandre Julliard 28 Mar '13

28 Mar '13

André Hentschel <nerv(a)dawncrow.de> writes: > + /* the bias could be because the app wanted something like a "red shift" > + * like when you're hit in Quake, but XVidMode doesn't support it, > + * so we have to reject a significant bias */ Clearly gdi32 doesn't care about XVidMode. > @@ -1325,6 +1405,18 @@ BOOL WINAPI SetDeviceGammaRamp(HDC hDC, LPVOID ptr) > if (GetObjectType( hDC ) != OBJ_MEMDC) > { > PHYSDEV physdev = GET_DC_PHYSDEV( dc, pSetDeviceGammaRamp ); > + struct gamma_ramp > + { > + WORD red[256]; > + WORD green[256]; > + WORD blue[256]; > + } *ramp = ptr; > + > + if (!check_gamma_ramp(ramp->red) || > + !check_gamma_ramp(ramp->green) || > + !check_gamma_ramp(ramp->blue)) > + return FALSE; This can't work. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winemac: Track drawn surface rect to reduce black flicker for new or resized windows.
by Ken Thomases 28 Mar '13

28 Mar '13

On Mar 27, 2013, at 3:31 PM, Ken Thomases wrote: > dlls/winemac.drv/macdrv.h | 12 +++++++++++- > dlls/winemac.drv/surface.c | 16 ++++++++++++++-- > dlls/winemac.drv/window.c | 17 ++--------------- > 3 files changed, 27 insertions(+), 18 deletions(-) > > <0001-winemac-Track-drawn-surface-rect-to-reduce-black-fli.patch> Please don't commit this. I've thought of a different approach. -Ken

1 0

Re: user32: ImmProcessKey is only called on WM_KEYDOWN and if the message is being removed
by Dmitry Timoshkov 28 Mar '13

28 Mar '13

Aric Stewart <aric(a)codeweavers.com> wrote: > Worked out with testing on Japanese windows XP. Resolves issues with > keystrokes and accelerators in menus when the IME is active. You should really start adding the tests and base your patches on test results instead of some sort of speculation. -- Dmitry.

3 4

Re: winemac: Null-terminate an snprintf-ed key name buffer in case of short buffer.
by Per Johansson 28 Mar '13

28 Mar '13

On Wed, Mar 27, 2013 at 7:22 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > --- This has probably been discussed before, but shouldn't snprintfW be safe against this kind of thing, the way POSIX snprintf is? Regards, -- Per Johansson

2 1

Linker error when improving GetLargestConsoleWindowSize
by Hugh McMaster 27 Mar '13

27 Mar '13

Hi, I've written a function to determine the largest possible screen buffer that wineconsole is able to display. This function replaces the hard-coded constants listed in both instances of GetLargestConsoleWindowSize in dlls/kernel32/console.c. [snip] #include <windows.h> #include <winuser.h> [snip] COORD GetLargestConsoleWindowSize_helper(HANDLE hConsoleOutput) { RECT workarea; COORD console_fontsize; COORD max_console; SystemParametersInfoA(SPI_GETWORKAREA, 0, &workarea, 0); console_fontsize = GetConsoleFontSize(hConsoleOutput, 0); max_console.X = (workarea.right / console_fontsize.X) - 6; max_console.Y = (workarea.bottom / console_fontsize.Y) - 6; return max_console; } While dlls/kernel32/console.c compiles, I'm having trouble with the final compile-time linking. It seems that SystemParametersInfoA is an undefined reference, but windows.h and winuser.h are included in console.c. This is the terminal output: make[1]: Entering directory `/home/hugh/wine-1.5.26/dlls/kernel32' [snip] ../../tools/winegcc/winegcc -B../../tools/winebuild --sysroot=../.. -fasynchronous-unwind-tables -shared ./kernel32.spec actctx.o atom.o change.o comm.o computername.o console.o cpu.o debugger.o editline.o environ.o except.o fiber.o file.o format_msg.o heap.o kernel_main.o lcformat.o locale.o lzexpand.o module.o nameprep.o oldconfig.o path.o powermgnt.o process.o profile.o resource.o string.o sync.o tape.o term.o thread.o time.o toolhelp.o version.o virtual.o volume.o wer.o locale_rc.res version.res winerror.res -nodefaultlibs -Wb,-F,KERNEL32.dll -Wl,--image-base,0x7b800000 -o kernel32.dll.so -lwinecrt0 -lntdll ../../libs/port/libwine_port.a console.o: In function `GetLargestConsoleWindowSize_helper': /home/hugh/wine-1.5.26/dlls/kernel32/console.c:1377: undefined reference to `SystemParametersInfoA' /usr/bin/ld: kernel32.dll.so: hidden symbol `SystemParametersInfoA' isn't defined /usr/bin/ld: final link failed: Bad value collect2: error: ld returned 1 exit status winegcc: gcc failed make[1]: *** [kernel32.dll.so] Error 2 Unfortunately, my knowledge of C is terrible, so I'm not sure what to do from here. If someone could help me solve this, I'd appreciate it. If it helps, I'm able to use winegcc to build a simple Windows executable using SystemParametersInfo without any problems. Thank you in advance, Hugh

3 4