March 2013 - Wine-devel - list.winehq.org

Re: msvcr110: forward __crtSetUnhandledExceptionFilter to kernel32.SetUnhandledExceptionFilter
by Alexandre Julliard 26 Mar '13

26 Mar '13

Austin English <austinenglish(a)gmail.com> writes: > diff --git a/dlls/msvcr110/msvcr110.spec b/dlls/msvcr110/msvcr110.spec > index 4a94dbe..babfc67 100644 > --- a/dlls/msvcr110/msvcr110.spec > +++ b/dlls/msvcr110/msvcr110.spec > @@ -928,7 +928,7 @@ > @ stub -arch=i386,win64 __crtLCMapStringEx > @ cdecl __crtLCMapStringW(long long wstr long ptr long long long) msvcrt.__crtLCMapStringW > @ stub -arch=i386,win64 __crtSetThreadStackGuarantee > -@ stub __crtSetUnhandledExceptionFilter > +@ stdcall __crtSetUnhandledExceptionFilter(ptr) kernel32.SetUnhandledExceptionFilter A quick test shows that the crt functions are cdecl. -- Alexandre Julliard julliard(a)winehq.org

1 0

Mac driver status: ready for contributions
by Ken Thomases 26 Mar '13

26 Mar '13

Hi, With my latest set of patches, the Mac driver in Wine is up to speed with what's in CrossOver 12 (plus some extra goodies). Of course, that's not to say that the Mac driver is done, but if you were holding off getting involved because you figured big chunks of already-done work were pending, that's no longer the case. From here on out, all work on the Mac driver will be new coding, so it's ready for anybody to contribute. Testing is one excellent way of contributing. I encourage any Mac Wine users to enable the Mac driver, test your favorite programs, and file bugs for any new problems (and there _will_ be bugs to find). Please try to distinguish between general Wine bugs which also happen with the X11 driver vs. bugs which only happen with the Mac driver. Currently, you have to set a registry key to enable the Mac driver: [HKEY_CURRENT_USER\Software\Wine\Drivers] "Graphics"="mac,x11" Swap the order to "x11,mac" – or just remove the "Graphics" value altogether – to revert to using the X11 driver. Aside from bugs, the Mac driver is pretty close to complete. Here's a list of stuff that I know is incomplete. Not all of these things are hard. In fact, I expect some will be quite easy and the only reason I didn't get to them was to get broader coverage of general areas of functionality by CrossOver 12's release. * The Quit menu item should do a graceful shutdown of the Windows process rather than abruptly terminating it. Same for requests to quit from the system such as during logout, restart, or shutdown. * A registry setting to govern whether full-screen at full-resolution should capture the display (which will disable active screen corners but also application switching and UI overlays). Full-screen at other resolutions already captures the displays. * A registry setting to govern whether the Option/Alt key sends an Alt keystroke instead of accessing additional characters from the Mac keyboard layout. * Support for maximizing windows. * Reduce or eliminate flashes of black before windows (re)draw. * Support for Mac input methods (Asian languages, press-and-hold, keyboard and character viewers). * Rework the Graphics tab of winecfg. Most of it doesn't apply to the Mac driver. As Mac-driver-specific registry settings are implemented, they may need to be revealed in winecfg. * Maybe implement a Cocoa Preferences dialog for the Mac driver's settings as an alternative to putting them in winecfg. * Activating a Wine GUI process all of whose windows are minimized should maybe unminimize one. * Add some additional standard items to the Mac menus, such as Hide Wine, Hide Others, and Show All. * Support for metafile clipboard formats. * Support for mouse capture. * Improved system tray functionality like detecting mouse moves and right-clicks and presenting notification balloons. * Support localization of the few UI strings in the Mac driver (basically the menu item titles). (Charles Betts has already submitted work to support disabling and reenabling the screen saver. As I understand it, Alexandre has some unspecified ideas about how he wants to change the driver interface for the SystemParametersInfo entry point.) Cheers, Ken

3 3

Re: gdi32: Printer drivers don't use the character extra spacing if lpdx is supplied.
by Alexandre Julliard 26 Mar '13

26 Mar '13

Huw Davies <huw(a)codeweavers.com> writes: > Ideally this would be done in wineps.drv, but by that point the conversion to device units would cause rounding errors. What about GetTextExtent functions? Do they need this too? Some test cases would be nice. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: explorer: Create desktop window hidden and only show it if it wins the race.
by Dmitry Timoshkov 26 Mar '13

26 Mar '13

Ken Thomases <ken(a)codeweavers.com> wrote: > + ShowWindow( hwnd, SW_SHOW ); > SetWindowLongPtrW( hwnd, GWLP_WNDPROC, (LONG_PTR)desktop_wnd_proc ); > SendMessageW( hwnd, WM_SETICON, ICON_BIG, (LPARAM)LoadIconW( 0, MAKEINTRESOURCEW(OIC_WINLOGO))); > if (name) set_desktop_window_title( hwnd, name ); You can postpone calling ShowWindow() after setting window text and icon, since they are drawn as part of a non-client area, and changing them forces another set of redraws. -- Dmitry.

2 1

[1/3] Make mac driver the default on OS X
by Joerg-Cyril.Hoehle＠t-systems.com 26 Mar '13

26 Mar '13

Hi, Ken Thomases wrote: >I think that the Mac driver should not be made the default >until OpenGL and clipboard support are in. Exactly :-( Following Josh DuBois explanation about HKCU/Software/Wine/Drivers "Graphics"="mac,x11" I decided to give it a try over the week-end and was very disappointed to see that seemingly *not any* app would run. It took me some time to understand that they all want graphics. Please don't waste the user's time when such "basics" don't work. What you can do is post to wine-devel and the user forum, asking for people to test your work. That would be polite. Josh DuBois wrote: >I propose an environment variable, WINEDRIVERLOADORDER Too generic. Include "DISPLAY" into the name, if at all, e.g. WINEDISPLAYDRIVER, or "GRAPHICS" as in the registry. The winepulse driver might face similar issues. I have not looked how Maarten thinks that it may coexist nicely with winealsa. Bug report: Toying around with built-in notepad, clock, winhlp32, I noticed that notepad and winhlp32 are not resizable, whereas the system preferences "control" is. By comparison, with the x11 driver, notepad's window is resizable even though it has no triangle widget at the bottom left. Also, the virtual desktop seems gone or not yet implemented. This is a key requirement for enough apps that do not handle today's huge resolutions. Another annoyance was that there's no HIDE function or short cut and some dialogues do not provide the orange button (middle one) to iconify the window. As a result, those pesky windows clutter your screen. That alone is enough reason to me a reason not to use that driver. It is not acceptable that one cannot get rid of a set of windows! Example: wine control, then navigate to the root CA certificates. The menu bar sometimes was refreshed badly, causing some texts therein to be displayed twice, shifted by a few pixels, or with varying fonts. Regards, Jörg Höhle

4 10

Re: [4/5] hlink: Implement IHlinkBrowseContext_GetHlink()
by Marvin 25 Mar '13

25 Mar '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24822 Your paranoid android. === W2KPROSP4 (32 bit browse_ctx) === browse_ctx.c:61: Test failed: got 0x80004005 browse_ctx.c:64: Test failed: got 0x80004005 === W2K3R2SESP2 (32 bit browse_ctx) === browse_ctx.c:61: Test failed: got 0x80004005 browse_ctx.c:64: Test failed: got 0x80004005 === W2K8SE (32 bit browse_ctx) === browse_ctx.c:61: Test failed: got 0x80004005 browse_ctx.c:64: Test failed: got 0x80004005 === W7PROX64 (32 bit browse_ctx) === browse_ctx.c:61: Test failed: got 0x80004005 browse_ctx.c:64: Test failed: got 0x80004005 === TEST64_W7SP1 (32 bit browse_ctx) === browse_ctx.c:61: Test failed: got 0x80004005 browse_ctx.c:64: Test failed: got 0x80004005 === W7PROX64 (64 bit browse_ctx) === browse_ctx.c:61: Test failed: got 0x80004005 browse_ctx.c:64: Test failed: got 0x80004005 === TEST64_W7SP1 (64 bit browse_ctx) === browse_ctx.c:61: Test failed: got 0x80004005 browse_ctx.c:64: Test failed: got 0x80004005

1 0

Re: ntdll: Improve stub for FileFsAttributeInformation in NtQueryVolumeInformationFile
by Marvin 24 Mar '13

24 Mar '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24819 Your paranoid android. === W2KPROSP4 (32 bit file) === file.c:1675: Test failed: got 8 === W2K3R2SESP2 (32 bit file) === file.c:1675: Test failed: got 8 === W2K8SE (32 bit file) === file.c:1675: Test failed: got 8 === W7PROX64 (32 bit file) === file.c:1675: Test failed: got 8 === TEST64_W7SP1 (32 bit file) === file.c:1675: Test failed: got 8 === W7PROX64 (64 bit file) === file.c:1675: Test failed: got 8 === TEST64_W7SP1 (64 bit file) === file.c:1675: Test failed: got 8

1 0

Re: winemac: Calculate surface rect correctly in macdrv_UpdateLayeredWindow().
by Ken Thomases 22 Mar '13

22 Mar '13

On Mar 22, 2013, at 1:21 AM, Ken Thomases wrote: > --- > dlls/winemac.drv/window.c | 33 ++++++++++++++++----------------- > 1 files changed, 16 insertions(+), 17 deletions(-) > > <0001-winemac-Calculate-surface-rect-correctly-in-macdrv_U.patch> Hmm. On further consideration, I'm not sure this is right. I think the intent was for the window surface of a ULW window to have a full surface even if it's partially off-screen. So, perhaps macdrv_WindowPosChanging() needs to use the same calculation as macdrv_UpdateLayeredWindow() for that kind of window so the surface rect doesn't keep ping-ponging. Also, the same issue exists in the X11 driver. I'll have to discuss with Alexandre when he gets back. -Ken

1 0

Re: [PATCH 4/5] winemac: Implement rudimentary support for system tray icons as Mac status items.
by C.W. Betts 22 Mar '13

22 Mar '13

On Mar 17, 2013, at 9:40 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > > Doesn't support right-clicks, mouse moves, or notification balloons. Notification balloons can probably be done using either Notification Center or Growl, but either due to an out-of-date version of Growl in Twitter or a bug in Growl itself, clicking on the Growl notification doesn't bring Twitter to the front for me. > --- > dlls/winemac.drv/Makefile.in | 2 + > dlls/winemac.drv/cocoa_status_item.m | 175 +++++++++++++++++ > dlls/winemac.drv/event.c | 5 + > dlls/winemac.drv/image.c | 2 +- > dlls/winemac.drv/macdrv.h | 3 + > dlls/winemac.drv/macdrv_cocoa.h | 13 ++ > dlls/winemac.drv/systray.c | 358 ++++++++++++++++++++++++++++++++++ > dlls/winemac.drv/winemac.drv.spec | 3 + > 8 files changed, 560 insertions(+), 1 deletions(-) > create mode 100644 dlls/winemac.drv/cocoa_status_item.m > create mode 100644 dlls/winemac.drv/systray.c > > <0004-winemac-Implement-rudimentary-support-for-system-tra.patch>

4 8

Parameterizing the places Wine suggests people report bugs
by Josh DuBois 22 Mar '13

22 Mar '13

Hi all, There are a couple of places wine suggests that people report bugs to wine-devel. The crash reporting dialog in winedbg suggests this, and a couple of places in code refer to wine-devel(a)winehq.org in error messages. The configure script has a PACKAGE_BUGREPORT macro which could be used to allow someone building wine to redirect those errors somewhere else. At least for wine's crash dialog, an alternate approach for a repackager to redirect bug reports would be to read the url / email address for where to send bugs from the registry. Would Wine accept a patch for making winedbg read the 'destination' for bug reports from the registry or some other runtime variable? Or would the project prefer to have all the bug reports routed directly to winehq, so that a repackager who wants to re-route bugs would have to build that facility on its own?

2 1