March 2013 - Wine-devel - list.winehq.org

Re: [1/3] kernel32: Set GetLargestConsoleWindowSize based on screen resolution
by Ken Thomases 27 Mar '13

27 Mar '13

On Mar 27, 2013, at 6:41 AM, Hugh McMaster wrote: > This patch modifies the dlls/kernel32 Makefile.in to (1) compile a new source file (screensize.c) (patch 3/3) and (2) add -lX11 to the ExtraDllFlags line. This approach is untenable. Kernel32 can't be made to depend on X11. It has to still work when X11 isn't available. Also, X11 is just one possible graphics/windowing system that Wine can use, so it's not always the right authority to consult about screen size. Eric Pouech suggested in the other thread to calculate the console window size in wineconsole, at which point you can use user32 and SystemParametersInfo(). Finally, your patch series is broken in the sense that each patch in the series must still be able to compile. You introduce a dependency on screensize.c in the first patch but don't actually provide that source file until the third. -Ken

2 2

Re: d3dx9 [patch 1/2, try 3]: Implement D3DXSHEvalSphericalLight
by Alexandre Julliard 27 Mar '13

27 Mar '13

Nozomi Kodama <nozomi.kodama(a)yahoo.com> writes: > From 3d331ffa908f69ca58686b4601effbb16d89d1da Mon Sep 17 00:00:00 2001 > From: "nozomi.kodama" <nozomi.kodama(a)yahoo.com> > Date: Thu, 14 Mar 2013 18:34:48 -1000 > Subject: d3dx9: Implement D3DXSHEvalSphericalLight It fails on 64-bit: ../../../../wine/tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so ../../../../wine/dlls/d3dx9_36/tests/math.c && touch math.ok math.c:2930: Test failed: Red: case 1, order 5: expected[20] = 0.000529, received 0.000529 math.c:2939: Test failed: Green: case 1, order 5: expected[20] = 0.000809, received 0.000809 math.c:2949: Test failed: Blue: case 1, order 5: expected[20] = 0.001089, received 0.001089 math.c:2930: Test failed: Red: case 1, order 6: expected[20] = 0.000529, received 0.000529 math.c:2939: Test failed: Green: case 1, order 6: expected[20] = 0.000809, received 0.000809 math.c:2949: Test failed: Blue: case 1, order 6: expected[20] = 0.001089, received 0.001089 math.c:2930: Test failed: Red: case 2, order 5: expected[20] = -0.000715, received -0.000714 math.c:2939: Test failed: Green: case 2, order 5: expected[20] = -0.001093, received -0.001093 math.c:2949: Test failed: Blue: case 2, order 5: expected[20] = -0.001471, received -0.001471 math.c:2930: Test failed: Red: case 2, order 6: expected[20] = -0.000715, received -0.000714 math.c:2939: Test failed: Green: case 2, order 6: expected[20] = -0.001093, received -0.001093 math.c:2949: Test failed: Blue: case 2, order 6: expected[20] = -0.001471, received -0.001471 make: *** [math.ok] Error 12 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: tools/wine.inf: add HKLM\\System\\CurrentControlSet\\Services\\Eventlog\\Application registry key
by Alexandre Julliard 27 Mar '13

27 Mar '13

Austin English <austinenglish(a)gmail.com> writes: > Fixes http://bugs.winehq.org/show_bug.cgi?id=22026 It breaks the tests: ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so eventlog.c && touch eventlog.ok eventlog.c:524: Tests skipped: We don't have a backup eventlog to work with eventlog.c:457: Tests skipped: No records in the 'Application' log eventlog.c:835: Test failed: Expected 1 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 2 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 3 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 4 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 5 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 6 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 7 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 8 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 9 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 10 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:858: Test failed: Expected 10 records, got 0 eventlog.c:863: Tests skipped: No events were written to the eventlog eventlog.c:1086: Test failed: Expected an eventlog file eventlog.c:1113: Test succeeded inside todo block: Could not delete the registry tree : 0 eventlog.c:1120: Test succeeded inside todo block: Expected MoveFileEx to succeed: 1 make: *** [eventlog.ok] Error 24 -- Alexandre Julliard julliard(a)winehq.org

1 0

Wiki is down
by Rosanne DiMesio 27 Mar '13

27 Mar '13

I'm getting an "Internal Server Error" message when I try to access the wiki. -- Rosanne DiMesio <dimesio(a)earthlink.net>

3 5

Re: [PATCH 1/3] msvcr90: Forward some functions directly to ntdll
by Alexandre Julliard 27 Mar '13

27 Mar '13

Piotr Caban <piotr(a)codeweavers.com> writes: > These functions are currently forwarded from msvcr90 to msvcrt which > forwards to ntdll. Naver LINE is crashing while trying to call them. Does it work if you remove the forward in msvcrt instead? That would be a better fix. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: advapi32: Do not terminate a regular program if it calls StartServiceCtrlDispatcher.
by Alexandre Julliard 27 Mar '13

27 Mar '13

Alexander Morozov <amorozov(a)etersoft.ru> writes: > @@ -592,7 +586,26 @@ BOOL WINAPI StartServiceCtrlDispatcherA( const SERVICE_TABLE_ENTRYA *servent ) > services[i] = info; > } > > - service_run_main_thread(); > + disp = HeapAlloc( GetProcessHeap(), 0, sizeof(*disp) ); > + > + if (!(disp->manager = OpenSCManagerW( NULL, NULL, SC_MANAGER_CONNECT ))) > + { > + ERR("failed to open service manager error %u\n", GetLastError()); > + HeapFree( GetProcessHeap(), 0, disp ); > + return FALSE; > + } > + > + disp->pipe = service_open_pipe(); > + if (disp->pipe == INVALID_HANDLE_VALUE) > + { > + WARN("failed to create control pipe error %u\n", GetLastError()); > + CloseServiceHandle( disp->manager ); > + HeapFree( GetProcessHeap(), 0, disp ); > + SetLastError( ERROR_FAILED_SERVICE_CONTROLLER_CONNECT ); > + return FALSE; > + } > + > + service_run_main_thread( disp ); There's no reason to duplicate that code, just do it in service_run_main_thread instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: urlmon: Fix handling of mailto URIs in CoInternetCombineUrlEx.
by Jacek Caban 27 Mar '13

27 Mar '13

Hi Hans, On 03/27/13 10:43, Hans Leidekker wrote: > --- > dlls/urlmon/tests/uri.c | 63 +++++++++++++++++++++++++++++++++++++++++++---- > dlls/urlmon/uri.c | 15 ++++++++--- > 2 files changed, 69 insertions(+), 9 deletions(-) > > diff --git a/dlls/urlmon/tests/uri.c b/dlls/urlmon/tests/uri.c > index e5faa81..29bd859 100644 > --- a/dlls/urlmon/tests/uri.c > +++ b/dlls/urlmon/tests/uri.c > @@ -7005,8 +7005,61 @@ static const uri_combine_test uri_combine_tests[] = { > {URL_SCHEME_FILE,S_OK}, > {URLZONE_INVALID,E_NOTIMPL} > } > + }, > + { "http://winehq.org",0, > + "mailto://",0, > + 0,S_OK,FALSE, You are changing parts that are not combining-specific. Since the relative URI is absolute in this case, there is not much happening other than parsing the URI during combining. Those tests are fine, but please add also tests for CreateUri, see uri_tests array. This should be straightforward based on tests you already wrote. > diff --git a/dlls/urlmon/uri.c b/dlls/urlmon/uri.c > index 0f6ee31..c6b5166 100644 > --- a/dlls/urlmon/uri.c > +++ b/dlls/urlmon/uri.c > @@ -422,7 +422,7 @@ static inline BOOL is_hierarchical_uri(const WCHAR **ptr, const parse_data *data > else if(is_hierarchical_scheme(data->scheme_type) && (*ptr)[0] == '\\' && (*ptr)[1] == '\\') { > *ptr += 2; > return TRUE; > - } else if(check_hierarchical(ptr)) > + } else if(data->scheme_type != URL_SCHEME_MAILTO && check_hierarchical(ptr)) > return TRUE; > > *ptr = start; > @@ -2980,6 +2980,9 @@ static BOOL canonicalize_path_opaque(const parse_data *data, Uri *uri, DWORD fla > const BOOL known_scheme = data->scheme_type != URL_SCHEME_UNKNOWN; > const BOOL is_file = data->scheme_type == URL_SCHEME_FILE; > const BOOL is_mk = data->scheme_type == URL_SCHEME_MK; > + const BOOL is_javascript = data->scheme_type == URL_SCHEME_JAVASCRIPT; > + const BOOL is_mailto = data->scheme_type == URL_SCHEME_MAILTO; > + DWORD offset = 0; > > if(!data->path) { > uri->path_start = -1; > @@ -2996,7 +2999,7 @@ static BOOL canonicalize_path_opaque(const parse_data *data, Uri *uri, DWORD fla > } > > /* For javascript: URIs, simply copy path part without any canonicalization */ > - if(data->scheme_type == URL_SCHEME_JAVASCRIPT) { > + if(is_javascript) { > if(!computeOnly) > memcpy(uri->canon_uri+uri->canon_len, data->path, data->path_len*sizeof(WCHAR)); > uri->path_len = data->path_len; > @@ -3007,7 +3010,11 @@ static BOOL canonicalize_path_opaque(const parse_data *data, Uri *uri, DWORD fla > /* Windows doesn't allow a "//" to appear after the scheme > * of a URI, if it's an opaque URI. > */ > - if(data->scheme && *(data->path) == '/' && *(data->path+1) == '/') { > + if (is_mailto && *(data->path) == '/' && *(data->path+1) == '/') { > + if (!*(data->path+2)) uri->path_start = -1; > + offset += 2; I think this should be done in parsing phrase, not during canonicalization. Jacek

1 0

Re: comctl32: Make an attempt to update notification handle
by Dmitry Timoshkov 27 Mar '13

27 Mar '13

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + case WM_WINDOWPOSCHANGING: > + { > + HWND parent = GetParent(hwnd); > + if (parent) infoPtr->hwndNotify = parent; > + return DefWindowProcW(hwnd, uMsg, wParam, lParam); > + } What if an application subclasses tab and doesn't pass WM_WINDOWPOSCHANGING to the original proc? Why not just call GetParent() every time when a notification is being sent? -- Dmitry.

3 7

Re: iads.idl: Add missing interfaces
by Nikolay Sivov 27 Mar '13

27 Mar '13

On 3/27/2013 09:05, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > iads.idl: Add missing interfaces > > > Best Regards > Alistair Leslie-Hughes > +typedef enum > +{ > + ADS_SEARCHPREF_ASYNCHRONOUS = 0, > + ADS_SEARCHPREF_DEREF_ALIASES = 1, You don't need to do it manually, widl will generate values for each entry.

1 0

Re: d3dx9 [patch 1/2, try 3]: Implement D3DXSHEvalSphericalLight
by Matteo Bruni 26 Mar '13

26 Mar '13

2013/3/15 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: > Patch series is fine to me.

4 3