April 2013 - Wine-devel - list.winehq.org

Re: [0/4] Improve wineconsole and kernel32
by Frédéric Delanoy 25 Apr '13

25 Apr '13

On Wed, Apr 24, 2013 at 9:15 AM, Hugh McMaster < hugh.mcmaster(a)masterindexing.com> wrote: > This series of four patches will improve various three functions in > kernel32: > > * GetConsoleFontSize > * GetCurrentConsoleFont > * GetLargestConsoleWindowSize > > This is achieved by moving logical calculations to wineconsole itself. > kernel32.dll only receives the final values. > > The first and second patches should be applied to source before compiling > Wine. If this is not done, the compiler will exit with errors. (The first > is a patch for server/protocol.def and requires tools/make_requests to be > run). > After each patch, Wine should be able to compile correctly (e.g. for regression testing) If not, you should split your patches differently IMO. Frédéric

2 1

Wine Gecko 2.21-beta1
by Jacek Caban 25 Apr '13

25 Apr '13

Hi all, As some of you might have noticed, the final Wine Gecko 2.20 was never been released, although it was scheduled for about three weeks ago. This is mostly due to my lack of time, combined with the fact that part of that time I was busy with some Gecko work that would be nice to have in Wine. Being 3 weeks late means that we also have 3 weeks until the next Firefox release, so we may just wait a bit longer and do another release based on newer upstream code base. This way I may use the new beta to include some of the changes that I did lately, which would be too risky to go straight to release. Those new improvements contain, among others, a fix for Adobe CS4 products installers. In this beta, the testing is easier than ever. Our auto installer knows about the beta which, combined with the fact that we cache downloaded packages now, means that the attached Wine patch is all you need to comfortably test the new package. Just apply the patch you the Wine tree and everything should work. All tests are appreciated. Thanks, Jacek

1 0

Re: [PATCH 2/5] wined3d: Introduce a wined3d_vertex_pipe_ops structure.
by Rico Schüller 25 Apr '13

25 Apr '13

On 25.04.2013 09:59, Henri Verbeet wrote: > -static HRESULT shader_arb_alloc(struct wined3d_device *device, const struct fragment_pipeline *fragment_pipe) > +static HRESULT shader_arb_alloc(struct wined3d_device *device, const struct wined3d_vertex_pipe_ops *vertex_pipe, > + const struct fragment_pipeline *fragment_pipe) > { > struct shader_arb_priv *priv = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*priv)); > struct fragment_caps fragment_caps; > - void *fragment_priv; > + void *vertex_priv, *fragment_priv; > + > + if (!(vertex_priv = vertex_pipe->vp_alloc(&arb_program_shader_backend, priv))) > + { > + ERR("Failed to initialize vertex pipe.\n"); > + HeapFree(GetProcessHeap(), 0, priv); > + return E_FAIL; > + } > > if (!(fragment_priv = fragment_pipe->alloc_private(&arb_program_shader_backend, priv))) > { > ERR("Failed to initialize fragment pipe.\n"); > + fragment_pipe->free_private(device); Shouldn't that vertex_pipe->vp_free(device)? > HeapFree(GetProcessHeap(), 0, priv); > return E_FAIL; > }

2 1

Clang static analyzer results / wine-1.5.28-66-g6899279
by Austin English 25 Apr '13

25 Apr '13

With wine-1.5.20 and clang 3.2, the test suite is in the same state on my Fedora 18 machine as gcc-4.7.2 llvm version: git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk(a)17976891177308-0d34-0410-b5e… clang version: git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk(a)17977191177308-0d34-0410-b5e6… ./configure --disable-tests was used to reduce noise [austin(a)localhost ~]$ sha1sum scan-build-2013-04-18-2.tar.bz2 51e28c96a04ebe9ef937678149f9e7e3ed4cb20f scan-build-2013-04-18-2.tar.bz2 [austin(a)localhost ~]$ du -h scan-build-2013-04-18-2.tar.bz2 35M scan-build-2013-04-18-2.tar.bz2 http://www.mediafire.com/?xwb05d6er0aclfe -- -Austin

5 7

Re: [PATCH 1/2] gdi32: Clip font glyphs to fit within text metrics. (try 2)
by Sam Edwards 24 Apr '13

24 Apr '13

This series has been waiting in the queue for a few days now. Does this need further discussion, or can it be committed? Thanks, Sam On 04/20/2013 08:08 AM, Sam Edwards wrote: >

1 0

Re: [PATCH] kernel32: Actually return a PERFORMANCE_INFORMATION structure in K32GetPerformanceInfo (try 2)
by Christian Costa 24 Apr '13

24 Apr '13

2013/4/24 James Eder <jimportal(a)gmail.com> > This version should either pass or skip on W2KPROSP4. > --- > dlls/kernel32/cpu.c | 23 ++++++++++++++++++----- > dlls/psapi/tests/psapi_main.c | 36 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 54 insertions(+), 5 deletions(-) > > diff --git a/dlls/kernel32/cpu.c b/dlls/kernel32/cpu.c > index 0ebf8f3..124e5c0 100644 > --- a/dlls/kernel32/cpu.c > +++ b/dlls/kernel32/cpu.c > @@ -216,16 +216,29 @@ BOOL WINAPI IsProcessorFeaturePresent ( > */ > BOOL WINAPI K32GetPerformanceInfo(PPERFORMANCE_INFORMATION info, DWORD > size) > { > - NTSTATUS status; > + MEMORYSTATUSEX mem_status; > > TRACE( "(%p, %d)\n", info, size ); > > - status = NtQuerySystemInformation( SystemPerformanceInformation, > info, size, NULL ); > - > - if (status) > + if(size < sizeof(PERFORMANCE_INFORMATION)) > { > - SetLastError( RtlNtStatusToDosError( status ) ); > + SetLastError(ERROR_BAD_LENGTH); > return FALSE; > } > + > + mem_status.dwLength = sizeof(mem_status); > + if (!GlobalMemoryStatusEx( &mem_status )) > + return FALSE; > + > + memset(info, 0, sizeof(PERFORMANCE_INFORMATION)); > + > + info->cb = sizeof(PERFORMANCE_INFORMATION); > + info->CommitLimit = min((mem_status.ullTotalPageFile / > system_info.PageSize), MAXDWORD); > + info->PhysicalTotal = min((mem_status.ullTotalPhys / > system_info.PageSize), MAXDWORD); > + info->PhysicalAvailable = min((mem_status.ullAvailPhys / > system_info.PageSize), MAXDWORD); > + info->PageSize = system_info.PageSize; > + > + FIXME("stub\n"); > + > Hi James, That would be better to change the trace at the beginning by FIXME( "(%p, %d): semi-stub\n", info, size ); or FIXME( "(%p, %d): partial stub\n", info, size ); instead of adding another fixme (which is not really correct since it's not a stub). Christian

2 3

Re: msvcr110.dll: add a stub for crtGetShowWindowMode (try 2)
by Alexandre Julliard 24 Apr '13

24 Apr '13

Austin English <austinenglish(a)gmail.com> writes: > Fixes http://bugs.winehq.org/show_bug.cgi?id=33195 > > try 2: return SW_SHOWWINDOW instead of SW_HIDE It's not much harder to return the correct value. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] shell32: Add a semi-stub for SHGetStockIconInfo
by Nikolay Sivov 24 Apr '13

24 Apr '13

On Wed, Apr 24, 2013 at 6:38 PM, Detlef Riekenberg <wine.dev(a)web.de> wrote: > -- > By by ... Detlef > --- > dlls/shell32/iconcache.c | 42 > ++++++++++++++++++++++++++++++++++++++++++ > dlls/shell32/shell32.spec | 1 + > 2 files changed, 43 insertions(+), 0 deletions(-) > > diff --git a/dlls/shell32/iconcache.c b/dlls/shell32/iconcache.c > index 637dbca..df6675d 100644 > --- a/dlls/shell32/iconcache.c > +++ b/dlls/shell32/iconcache.c > @@ -46,6 +46,8 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(shell); > > +static const WCHAR shell32dll[] = > {'\\','s','h','e','l','l','3','2','.','d','l','l',0}; > + > Please put this in function that needs it.

1 0

Re: [PATCH 4/5] d3d9/tests: Don't test for equality in d3d9's depth_blit_test
by Henri Verbeet 24 Apr '13

24 Apr '13

On 24 April 2013 11:29, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This makes the test pass on nv40 GPUs on Linux. I'm not sure if testing > equality was intentional or an accident, if it was intentional please > ignore this patch. > I don't quite remember, but probably not. Arguably the nicer way to fix it is to change the z-value for quad1 to 0.33f though.

1 0

Re: oledb32: Implement DataConvert DBTYPE_BOOL->VARIANT
by Jacek Caban 24 Apr '13

24 Apr '13

On 04/24/13 10:41, Alistair Leslie-Hughes wrote: > + case DBTYPE_BOOL: > + V_VT(v) = VT_BOOL; > + V_BOOL(v) = *(BOOL*)src; You're mixing BOOL and VARIANT_BOOL here. This can't work, they even have a different size. From your test I guess that you meant to cast src to VARIANT_BOOL*. Cheers, Jacek

1 0