April 2013 - Wine-devel - list.winehq.org

Re: user32: add assembly wrapper for calling hook procedures.
by James Eder 22 Apr '13

22 Apr '13

Dan, the patch doesn't build for 64-bit Wine. On the #else side you have an unwanted semicolon. -- Jim

2 1

Wine History
by André Hentschel 22 Apr '13

22 Apr '13

Hi, meanwhile everyone should know that Wine turns 20 this year. AJ said in this years Keynote we'll need to find a way to celebrate this in June. So i did some research on this and found "Wine History" mails by Dan Kegel from 2002 and much earlier Bob Amstadt talking about late May or early June 1993. The date listed on Wikipedia is July the 4th, but i was still curious about that late May. I think i finally found this late May (30th) discussion and want to share it: https://groups.google.com/d/msg/comp.os.linux/7TFhxP6IUVQ/gVHAeP_ZBVUJ It's of course hard to tell when a project was really born, but as far as i understand, this discussion inspired Bob to write an initial loader. I was just 5 at this time, so maybe someone can tell some more about it? :) Some more Links: http://en.wikipedia.org/wiki/Wine_%28software%29 http://www.winehq.org/pipermail/wine-devel/2002-November/010567.html http://www.winehq.org/pipermail/wine-devel/2002-November/010603.html https://groups.google.com/d/msg/comp.os.linux/RKpNL1M8vSE/Z-rgUyrSFlYJ https://groups.google.com/d/msg/comp.os.linux/mb1BwP7LckY/IV44zjGkO98J http://www.linuxjournal.com/article/2757 and of course http://wiki.winehq.org/WineHistory Ok, i somehow lost the mentioning of "late may", but it's already quite late here, sry.

2 1

Re: [user32] Add DECLSPEC_NOINLINE, use it on call_hook_proc()
by Qian Hong 22 Apr '13

22 Apr '13

Hi Dan, Thanks for working on it! It is really an annoying bug, however, is adding DECLSPEC_NOINLINE a workaround or a real fix? If it is only a workaround, would that hide some real bug behind it? Or is that possible that there is a gcc bug here that we want to report to gcc? Thanks for your time!

4 7

Re: [PATCH 1/2] wined3d: Remove leftover texture accesses in GLSL shader generation
by Henri Verbeet 22 Apr '13

22 Apr '13

On 21 April 2013 16:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - if (texture && texture->target == GL_TEXTURE_RECTANGLE_ARB) > - sample_flags |= WINED3D_GLSL_SAMPLE_RECT; > + if (priv->cur_ps_args->np2_fixup & (1 << sampler_idx)) > + { > + sample_flags |= WINED3D_GLSL_SAMPLE_NPOT; > + } I don't think the added braces are an improvement, but otherwise this looks ok.

2 3

Re: [PATCH 1/3] d3dx9_36: Add support for DIB file in D3DXGetImageInfoFromFileInMemory.
by Alexandre Julliard 22 Apr '13

22 Apr '13

Christian Costa <titan.costa(a)gmail.com> writes: > + if (header_size == sizeof(BITMAPINFOHEADER)) > + { > + BITMAPINFOHEADER *header = (BITMAPINFOHEADER*)*data; > + ULONG count = header->biClrUsed; > + > + if (!count && header->biBitCount <= 8) > + count = 1 << header->biBitCount; > + > + offset = sizeof(BITMAPFILEHEADER) + header_size + sizeof(RGBQUAD) * count; This isn't correct for all DIB types. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/2] extrac32: Add /D switch support.
by Alexandre Julliard 22 Apr '13

22 Apr '13

Sergey Guralnik <serhio(a)etersoft.ru> writes: > @@ -202,6 +228,9 @@ int PASCAL wWinMain(HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline, int sho > WCHAR path[MAX_PATH]; > LPCWSTR cabfile = NULL; > > + extr_printf = (void*)GetProcAddress(LoadLibraryA("msvcrt"), "printf"); > + if(!extr_printf) > + return 1; Mixing C runtimes is not a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 2)
by Vincent Povirk 21 Apr '13

21 Apr '13

Dealing with the bits of a floating point number directly is a bit odd, and it makes it hard to review the code. Is there a reason you don't want to use things like modf, floor, and ceil?

2 3

re: Google Summer of Code 2013
by Dan Kegel 20 Apr '13

20 Apr '13

Hi Anulesh, improving wine's support of cygwin is a toughie. ( I gave http://bugs.winehq.org/show_bug.cgi?id=15679 the old college try, but failed. ) You should probably be more specific about what you have in mind. - Dan

1 0

re: Willing to work on CMD - implement more robust parser
by Dan Kegel 20 Apr '13

20 Apr '13

Hi Gaurab! Glad to hear you're interested in wine, and in cmd. You might start by reading previous discussion on the topic, e.g. the full thread following http://www.winehq.org/pipermail/wine-devel/2009-December/080643.html and http://kegel.com/wine/sweng/2010/ Two tips that might help smooth your way: There is a lot of bison in wine already, so using bison might be the path of least resistance. Switching just one command to bison, while leaving the rest using the existing code, would likely be much easier to get committed than a big patch that changed lots of things. Good luck! - Dan

1 0

Willing to work on CMD - implement more robust parser
by Gaurab Patra 20 Apr '13

20 Apr '13

Respected sir/madam, Through this mail I'd like to inform you that I am a Computer Science student at Bengal Engineering and Science University, Shibpur (India) in my 3rd year of undergraduate studies. I have gone through the project CMD - implement more robust parser and would like to work on this project this summer. As it is mentioned in the required skill set I am quite proficient in C, CMD commands, datastructure and algorithm etc. I'm attaching my resume with this mail. If you want to give me the opportunity to work on this please reply with some necessary resources and guide me with more information on this. Thank you GaurabPatraResume(1).pdf<https://docs.google.com/file/d/0B99XscJv40waenczeWh3ZVNkVlk/edit?usp=drive_…> Gaurab Patra 3rd yr Computer Science BESU, Shibpur

1 0