April 2013 - Wine-devel - list.winehq.org

Re: [PATCH 2/3]vbscript: Implemented builtin function CInt
by Dmitry Timoshkov 18 Apr '13

18 Apr '13

larmbr zhan <nasa4836(a)gmail.com> wrote: > + case VT_BOOL: > + *ret = V_BOOL(v) ? -1 : 0; > + break; Shouldn't this be VARIANT_TRUE/VARIANT_FALSE instead of -1/0? -- Dmitry.

1 0

Re: [PATCH 3/3]vbscript: Implemented builtin function CBool
by Marvin 17 Apr '13

17 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25139 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/3]vbscript: Implemented builtin function CInt
by Marvin 17 Apr '13

17 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25138 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/5] wined3d: Enable GL_ARB_texture_rectangle in GLSL ffp fragment shaders
by Henri Verbeet 16 Apr '13

16 Apr '13

On 16 April 2013 14:48, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (gl_info->supported[ARB_TEXTURE_RECTANGLE]) > + shader_addline(buffer, "#extension GL_ARB_texture_rectangle : enable\n"); > + This may be a good idea anyway, but is this strictly required? IIRC ARB_texture_rectangle is the one special extension that's always implicitly enabled in GLSL if it's supported.

2 2

Re: [PATCH 2/5] d3d9/tests: Test NPOT texture creation
by Henri Verbeet 16 Apr '13

16 Apr '13

On 16 April 2013 14:48, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - * Copyright (C) 2006 Chris Robinson > + * Copyright (C) 2006 Chris Robinsontes This looks unintentional. > + UINT refcount; Technically refcounts are ULONGs, although I suppose it doesn't matter a whole lot.

1 0

Re: winex11.drv: Transmit WM_DEADCHAR messages to applications
by Dmitry Timoshkov 16 Apr '13

16 Apr '13

Simon Lipp <sloonz(a)gmail.com> wrote: > + * Moreover, let dead chars be processed or we will never have > + * WM_DEADCHAR events That's how it's supposed to work. Wine should never generate WM_DEADCHAR message, it relies in the driver to handle dead keys and generate final events. X11 even has an ability to support user defined key sequences which are handled by XFilterEvent and which will be broken by your patch. -- Dmitry.

3 4

Re: kernel32: Add a test to check event and mutex states during process termination.
by Alexandre Julliard 16 Apr '13

16 Apr '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/kernel32/tests/loader.c | 40 +++++++++++++++++++++++++++++++++------- > 1 file changed, 33 insertions(+), 7 deletions(-) That's not a very meaningful test if nobody holds the mutex. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ieframe: Added DISPID_WINDOWCLOSING tests.
by Marvin 16 Apr '13

16 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25096 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2631: Test failed: expected GetOverridesKeyPath webbrowser.c:2636: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2637: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3076: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

1 0

Re: [PATCH 6/6] ieframe: Added DISPID_WINDOWCLOSING tests.
by Marvin 16 Apr '13

16 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25086 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2631: Test failed: expected GetOverridesKeyPath webbrowser.c:2636: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2637: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3076: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21 === WVISTAX64 (64 bit webbrowser) === webbrowser.c:978: Test failed: unexpected dispIdMember 271 webbrowser.c:1604: Test failed: unexpected call TranslateUrl webbrowser.c:454: Test failed: unexpected nCmdID 14 Timeout

2 1

Re: [PATCH 5/6] ieframe: Return document as IHTMLDocument2 iface from get_document.
by Marvin 15 Apr '13

15 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25085 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2615: Test failed: expected GetOverridesKeyPath webbrowser.c:2620: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2621: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3060: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

1 0