September 2013 - Wine-devel

Re: [PATCH 2/8] wined3d: Introduce a format flag for volume texture support.
by Henri Verbeet 18 Sep '13

18 Sep '13

On 17 September 2013 11:39, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index 4928f92..eabf890 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -2927,6 +2927,7 @@ extern enum wined3d_format_id pixelformat_for_depth(DWORD depth) DECLSPEC_HIDDEN > #define WINED3DFMT_FLAG_HEIGHT_SCALE 0x00040000 > #define WINED3DFMT_FLAG_TEXTURE 0x00080000 > #define WINED3DFMT_FLAG_BLOCKS_NO_VERIFY 0x00100000 > +#define WINED3DFMT_FLAG_VOLUME 0x00200000 > I don't like this approach much. I think we should either do the right thing right away and have separate flags for each GL resource type (i.e., vertex/index buffers, renderbuffers, 1D/2D/3D/CUBE/RECT textures), or just keep assuming they're the always the same and handle the exceptions for volumes like a quirk flag like WINED3DFMT_FLAG_BROKEN_PITCH. In either case this should probably have corresponding support for ARB_internalformat_query2 as well, and I'd prefer "TEXTURE3D" over "VOLUME".

2 4

Re: patch:add ualapi directory
by Marvin 18 Sep '13

18 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2209 Your paranoid android. === build (build) === Unable to regenerate dlls/ualapi/Makefile Recreation of tests/Makefile failed

1 0

Re: [8/9] gdi32: Return GDI_ERROR when requested empty glyph bitmaps.
by Marvin 18 Sep '13

18 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2207 Your paranoid android. === wvista (32 bit font) === The test timed out

1 0

Re: [1/4] ntdll/tests: Add 0-length read tests for a disk file.
by Nikolay Sivov 18 Sep '13

18 Sep '13

On 09/18/2013 10:53 AM, Dmitry Timoshkov wrote: > --- > dlls/ntdll/tests/file.c | 41 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c > index 120fdac..5ae605b 100644 > --- a/dlls/ntdll/tests/file.c > +++ b/dlls/ntdll/tests/file.c > @@ -1985,6 +1985,22 @@ static void test_read_write(void) > > bytes = 0xdeadbeef; > SetLastError(0xdeadbeef); > + ret = ReadFile(INVALID_HANDLE_VALUE, buf, 0,&bytes, NULL); > +todo_wine > + ok(!ret, "ReadFile should fail\n"); > +todo_wine > + ok(GetLastError() == ERROR_INVALID_HANDLE, "expected ERROR_INVALID_HANDLE, got %d\n", GetLastError()); > + ok(bytes == 0, "bytes %u\n", bytes); > That's again a test for kernel32 calls, placed in a wrong file.

2 1

Re: oledb32: Implement IErrorRecord GetBasicErrorInfo
by Nikolay Sivov 18 Sep '13

18 Sep '13

On 09/18/2013 09:47 AM, Alistair Leslie-Hughes wrote: > + LIST_FOR_EACH_ENTRY(cursor,&This->errors, struct ErrorEntry, entry) > + { > + if(nCnt == ulRecordNum) > + { > + *pErrorInfo = cursor->info; > + break; > + } > + } > + This looks wrong, cause you never update nCnt. Also it doesn't look appropriate to use list to store these records - methods provide index-based access, so array fits better. > entry->lookupID = dwDynamicErrorID; Any idea how this field could be used later? I don't where it could be returned. And 'dwLookupID' parameter of 'AddErrorRecord' is never used, that looks suspicious.

1 0

Re: [PATCH] oleaut32: Implement VarDecRound
by Bruno Jesus 17 Sep '13

17 Sep '13

On Tue, Sep 17, 2013 at 3:01 PM, Andrew Eikum <aeikum(a)codeweavers.com> wrote: > This fixes a crash in PowerPoint when a shape is made > semi-transparent. May also fix bug http://bugs.winehq.org/show_bug.cgi?id=34463 and http://bugs.winehq.org/show_bug.cgi?id=30485

1 0

Re: [5/9] gdiplus: Fix empty glyph handling.
by Vincent Povirk 17 Sep '13

17 Sep '13

This seems suspicious to me. Why can't we use those values in glyphmetrics if GetGlyphOutlineW returns 0? Does Windows provide bad values in this case, or is our GetGlyphOutlineW broken? When does the call to GetGlyphOutlineW in the second loop fail, and why ignore those failures?

2 5

Re: [PATCH 5/8] wined3d: Implement locking of block-based volume textures.
by Henri Verbeet 17 Sep '13

17 Sep '13

On 17 September 2013 11:39, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > --- > dlls/wined3d/volume.c | 95 +++++++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 88 insertions(+), 7 deletions(-) > Can't most of this be done on the resource level instead?

2 3

Re: [1/4] ws2_32: Use the struct information when the parameters are zero in WSASocket
by Alexandre Julliard 17 Sep '13

17 Sep '13

Bruno Jesus <00cpxxx(a)gmail.com> writes: > @@ -5884,20 +5884,20 @@ SOCKET WINAPI WSASocketW(int af, int type, int protocol, > return ret; > } > > - /* convert the socket family and type */ > - af = convert_af_w2u(af); > - type = convert_socktype_w2u(type); > - > if (lpProtocolInfo) > { > - if (af == FROM_PROTOCOL_INFO) > + if (af <= 0) > af = lpProtocolInfo->iAddressFamily; > - if (type == FROM_PROTOCOL_INFO) > + if (type <= 0) > type = lpProtocolInfo->iSocketType; > - if (protocol == FROM_PROTOCOL_INFO) > + if (protocol <= 0) > protocol = lpProtocolInfo->iProtocol; I don't see anything in the tests that would justify checking for negative values here. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 2/5] ddraw: Don't set render target / depth stencil usage on sysmem surfaces.
by Stefan Dösinger 17 Sep '13

17 Sep '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-09-17 09:22, schrieb Henri Verbeet: > Setting render target usage on a P8 surface for example would fail > surface creation, while such surfaces can't be used for actual > rendering anyway. Tests confirm that surface creation is supposed > to succeed for P8 surfaces with both DDSCAPS_SYSTEMMEMORY and > DDSCAPS_3DDEVICE set. What happens when a DDSCAPS_SYSTEMMEMORY surface (P8 or otherwise) is passed to CreateDevice or SetRenderTarget? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSOCViAAoJEN0/YqbEcdMwj6wP/AhSGoeqw0JU261iEled6W4C vIk1NEn7VB2MSDKE1i32fHiE9SnPW/kC/AimNl8PU51OzHym1gs+CIh4ZfvUvOnZ 0GNSO/HLf0aKssbxSx8z+OW0PaHXFST/6OsanKHwhq3CFJy4JPBVasFTSBnjDjv+ yQXp1ZRQOT3mI6Dy9EHVZkwdMQzC+NbFYfv3xd3a1h884ys359E97rcg/1pC/qrA oay/Oq3aAZVdWBbMjx4KbLcEDbwzVc9naQ4riKFGUY97AF+d4d8t1/kdYnSKwdtn PlpFA8SyS4/HpHVPN8+4/SoMKJetMMz9nzDPOiVjW+yWMHqLvtR08sPawDQza06g sIis0QZ0lC78eK0ibcIqvdv7u43vVtE2MJgQWnujv2L2S3pXDFr8AnK4tjPjaoUr BtuEdAyBBvo30i05f+u3+lNI4d2jsLBhFBXrWVUBqz/cb26epfz98H3Jrs09JEZ4 zypVmPE5MA5dEAgd5D5DD6AO4pymP7gpX5lrX7ynkz+kfe6xO7RtcuYKyfuwQnAu rikTZDZgv7+Dxnx1hlvP1P1o2nmFT2LhETTCev7JmzNhoS1/L0pjmNbP+JkeMYn5 mwrrCMEpK7kWL7OmRlkoWfu6q98+iR1O67+ptqf6yCRX1L4C+zYG0WKLivIX/XbF Aj4w0H043EWv3VYLPAVB =lgos -----END PGP SIGNATURE-----

2 2