September 2013 - Wine-devel

Re: [1/9] Fix expected values in various messages.
by Marvin 16 Sep '13

16 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2185 Your paranoid android. === wxppro (32 bit d3d) === d3d.c:1260: Test failed: Homogeneous output was generated despite UNCLIPPED flag === wvista (32 bit d3d) === d3d.c:1260: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w7pro64 (32 bit d3d) === d3d.c:1260: Test failed: Homogeneous output was generated despite UNCLIPPED flag

1 0

Re: [2/2] kernel32: implement callback and cancellation in CopyFileEx
by Nikolay Sivov 15 Sep '13

15 Sep '13

On 09/14/2013 03:25 AM, Daniel Jeliński wrote: > > Could you implement necessary part of CopyFile2 instead, and use it in CopyFileEx? I think CopyFile2 has everything to do that.

2 3

Re: [1/9] Fix expected values in various messages.
by Nikolay Sivov 15 Sep '13

15 Sep '13

On 09/15/2013 04:25 PM, Akihiro Sagawa wrote: > hr = IUnknown_QueryInterface(reader_input,&IID_IStream, (void**)&stream2); > - ok(hr == E_NOINTERFACE, "Expected S_OK, got %08x\n", hr); > + ok(hr == E_NOINTERFACE, "Expected E_NOINTERFACE, got %08x\n", hr); > As Henri said, it's not that useful to see expected value, this one is a copy-paste typo of course and should be fixed. Printing actual value is enough, so something like "got 0x%08x\n" is ok.

1 0

Re: patch:add ualapi directory
by Henri Verbeet 15 Sep '13

15 Sep '13

On 15 September 2013 17:50, matyapiro31 <matyapiro31(a)gmail.com> wrote: > + * wine is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * wine is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public License > + * along with wine. If not, see <http://www.gnu.org/licenses/>. > + */ That's not the standard copyright header. I'm not going to argue about whether it's still valid when you modify it like that, but at the very least we'd like the copyright headers to be consistent across Wine. > +static void test_ual( PUAL_DATA_BLOB Data ) > +{ > + > +} > + > +func_ualapi_test (ualapi) > +{ > + PUAL_DATA_BLOB ualdata; > + test_ual(ualdata); > + ok(0,"テストに失敗しました。\n");//第一引数:条件、第二引数:メッセージ > +} This looks very incomplete, did you intend to submit this?

1 0

Re: [1/9] Fix expected values in various messages.
by Henri Verbeet 15 Sep '13

15 Sep '13

On 15 September 2013 14:25, Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > > diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c > index 83cdaf9..9f9e12a 100644 > --- a/dlls/d3d8/tests/device.c > +++ b/dlls/d3d8/tests/device.c > @@ -1308,7 +1308,7 @@ static void test_reset(void) > D3DFMT_R5G6B5, D3DPOOL_DEFAULT, &volume_texture); > ok(SUCCEEDED(hr), "CreateVolumeTexture failed, hr %#x.\n", hr); > hr = IDirect3DDevice8_Reset(device1, &d3dpp); > - ok(hr == D3DERR_DEVICELOST, "Reset returned %#x, expected %#x.\n", hr, D3DERR_INVALIDCALL); > + ok(hr == D3DERR_DEVICELOST, "Reset returned %#x, expected %#x.\n", hr, D3DERR_DEVICELOST); I think Alexandre has an opinion on when this kind of patch is appropriate and when it isn't. Regardless, purely for the parts that touch Direct3D, I'd say that if you're changing these messages anyway, you may as well change them to something along the lines of "Got unexpected hr %#x.\n", since the expected value isn't that useful anyway.

1 0

Re: kernel32/tests: Add initial CreateFile2 tests based on the CreateFileW tests (try 2)
by Nikolay Sivov 13 Sep '13

13 Sep '13

On 9/13/2013 22:26, André Hentschel wrote: Sorry, ignore my comment. I missed that we actually have this call already in wine.

1 0

Re: kernel32/tests: Add initial CreateFile2 tests based on the CreateFileW tests (try 2)
by Nikolay Sivov 13 Sep '13

13 Sep '13

On 9/13/2013 22:26, André Hentschel wrote: > + if (!pCreateFile2) > + { > + win_skip("CreateFile2 is missing\n"); > + return; > + } Should be skip() so it'll show up when running with wine. Not sure how important it is though.

1 0

Re: [PATCH 1/3] iphlpapi/tests: Increase buffer size to prevent overflow.
by Marvin 13 Sep '13

13 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2158 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/3] riched20/tests: Add UTF8 BOM tests for EM_SETTEXTEX. (try 5)
by Marvin 13 Sep '13

13 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2155 Your paranoid android. === w7pro64 (64 bit editor) === editor.c:5757: Test failed: wrong event mask (0x0) during WM_COMMAND

1 0

Re: [PATCH 3/3] riched20: Add UTF8 support for EM_SETTEXTEX. (try 6)
by Nikolay Sivov 13 Sep '13

13 Sep '13

On 9/13/2013 15:05, Jactry Zeng wrote: > bUnicode = !bRtf && pStruct->codepage == CP_UNICODE; > + bUTF8 = (lParam && (!strncmp((char *)lParam, utf8_bom, 3))); What will happen if both of these are true? This needs a test with BOM and 'codepage' set to 1200.

2 1