September 2013 - Wine-devel

Re: [2/2] kernel32: Remove a 0-length read optimization from ReadFile.
by Alexandre Julliard 12 Sep '13

12 Sep '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This matches WriteFile behaviour and ensures that invalid parameters are > properly handled and fields in the OVERLAPPED structure are initialized. This is again causing test failures. Please do a full test run before sending patches. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/2] ntdll: Properly handle 0-length reads.
by Marvin 12 Sep '13

12 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2127 Your paranoid android. === wxppro (32 bit comm) === comm.c:863: Test failed: WaitCommEvent failed with a timeout comm.c:875: recovering after WAIT_TIMEOUT... comm.c:886: Test failed: WaitCommEvent error 0 comm.c:888: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:892: WaitCommEvent for EV_TXEMPTY took 1000 ms (timeout 1000) comm.c:894: Test failed: WaitCommEvent used 1000 ms for waiting === w7pro64 (32 bit comm) === comm.c:863: Test failed: WaitCommEvent failed with a timeout comm.c:875: recovering after WAIT_TIMEOUT... comm.c:886: Test failed: WaitCommEvent error 0 comm.c:888: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:892: WaitCommEvent for EV_TXEMPTY took 1014 ms (timeout 1000) comm.c:894: Test failed: WaitCommEvent used 1014 ms for waiting comm.c:1561: test_AbortWaitCts timeout 500 handle 000000F8 comm.c:1528: Changing CommMask on the fly for handle 000000F8 after timeout 500

2 1

Re: ws2_32/tests: Add more WSASocket tests
by Marvin 12 Sep '13

12 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2126 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (7e4): unexpectedly at the OOB mark: 0

1 0

Re: [try3] gdi32: abc values remain the same despite any changes in layout direction or Viewport
by Aric Stewart 12 Sep '13

12 Sep '13

Alexandre, Do you want me to rewrite this patch with your new width_to_LP helper function or are you going to do that rewrite yourself? (assuming it is acceptable in other ways) thanks! -aric

1 0

Re: kernel32/tests: Add tests for ResolveDelayLoadedAPI (try3)
by Marvin 11 Sep '13

11 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2121 Your paranoid android. === wvista (32 bit loader) === loader.c:2056: Test failed: WaitForSingleObject failed: 102 loader.c:2058: Test failed: expected exit code 199, got 259 loader.c:2077: Test failed: expected 198, got 199

1 0

Re: [PATCH 4/5] ddraw: Avoid LPVOID.
by Marvin 11 Sep '13

11 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2112 Your paranoid android. === wxppro (32 bit d3d) === d3d.c:1260: Test failed: Homogeneous output was generated despite UNCLIPPED flag === wvista (32 bit d3d) === d3d.c:1260: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w7pro64 (32 bit d3d) === d3d.c:1260: Test failed: Homogeneous output was generated despite UNCLIPPED flag

2 1

Re: wininet: Don't assume that end of chunk means end of stream.
by Jacek Caban 11 Sep '13

11 Sep '13

Hi Hans, On 09/11/13 13:50, Hans Leidekker wrote: > static DWORD chunked_get_avail_data(data_stream_t *stream, http_request_t *req) > { > - /* Allow reading only from read buffer */ > + chunked_stream_t *chunked_stream = (chunked_stream_t*)stream; > + DWORD res; > + > + if(!chunked_stream->chunk_size || chunked_stream->chunk_size == ~0u) { > + res = start_next_chunk(chunked_stream, req); > + if(res != ERROR_SUCCESS) > + return 0; > + } start_next_chunk may block and we don't want chunked_get_avail_data to block. Jacek

2 4

Re: ws2_32: Fix WSADuplicateSocket implementation
by Marvin 11 Sep '13

11 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2119 Your paranoid android. === w7pro64 (32 bit sock) === sock.c:528: Test failed: oob_server (a8c): not at the OOB mark: 1

1 0

RFC: HKCR merge implementation
by George Stephanos 11 Sep '13

11 Sep '13

I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. Feel free to comment. So far, I've written code for all functions except for the RegEnum family. General description: HKCR handles are special. All wine handles have the two lowest bits zero'd. HKCR handles are masked. 10b specifically. They have their own table separate from the generic handle table. An HKCR handle has an HKCU handle and an HKLM handle below it. Access mask and a string representing the path are also needed since the handle has to attempt to reopen previously failed openings at certain stages. First patch: specially handles HKCR handles WITHOUT affecting the general behavior. The end result is still the exact same. Patch provides a foundation for the rest. Second patch: added path management Third patch: added HKCU Here's a quick description of each function: create_hkcr_struct: allocates the memory needed for the struct, adds it to the table and gives back a pointer to it get_hkcr_path: given an HKCR handle and a subkey string, prepares a subkey string representing the same subkey rooted at HKLM/HKCU. create_hkcr: RegCreateKeyEx open_hkcr: RegOpenKeyEx resolve_hkcr: checks the HKCR handle, tries to reopen previously failed internal handles, gives back HKCU first if available then HKLM close_hkcr: deallocates path and struct, removes struct from table. http://pastie.org/8314658 http://pastie.org/8314662 http://pastie.org/8314663

3 3

Re: [PATCH 2/2] d3d11.idl: Added some missing declarations.
by Henri Verbeet 11 Sep '13

11 Sep '13

On 11 September 2013 12:09, Jacek Caban <jacek(a)codeweavers.com> wrote: > +typedef enum D3D11_RESOURCE_MISC_FLAG > +{ > + D3D11_RESOURCE_MISC_GENERATE_MIPS = 0x00000001, > + D3D11_RESOURCE_MISC_SHARED = 0x00000002, > + D3D11_RESOURCE_MISC_TEXTURECUBE = 0x00000004, > + D3D11_RESOURCE_MISC_DRAWINDIRECT_ARGS = 0x00000010, > + D3D11_RESOURCE_MISC_BUFFER_ALLOW_RAW_VIEWS = 0x00000020, > + D3D11_RESOURCE_MISC_BUFFER_STRUCTURED = 0x00000040, > + D3D11_RESOURCE_MISC_RESOURCE_CLAMP = 0x00000080, > + D3D11_RESOURCE_MISC_SHARED_KEYEDMUTEX = 0x00000100, > + D3D11_RESOURCE_MISC_GDI_COMPATIBLE = 0x00000200, > + D3D11_RESOURCE_MISC_SHARED_NTHANDLE = 0x00000800, > + D3D11_RESOURCE_MISC_RESTRICTED_CONTENT = 0x00001000, > + D3D11_RESOURCE_MISC_RESTRICT_SHARED_RESOURCE = 0x00002000, > + D3D11_RESOURCE_MISC_RESTRICT_SHARED_RESOURCE_DRIVER = 0x00004000, > + D3D11_RESOURCE_MISC_GUARDED = 0x00008000 > +} D3D11_RESOURCE_MISC_FLAG; Arguably those should be __MSABI_LONG, although we may not care enough. We certainly aren't very consistent about it in a lot of other places either.

3 2