September 2013 - Wine-devel

riched20/tests: Add tests for ITextDocument_Save. (try 2)
by Jactry Zeng 11 Sep '13

11 Sep '13

Update: Add todo_wine

1 0

Re: [PATCH 4/5] wined3d: Move the decoded stream info into the context.
by Henri Verbeet 11 Sep '13

11 Sep '13

On 11 September 2013 11:31, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -1880,9 +1888,8 @@ struct wined3d_device > WORD d3d_initialized : 1; > WORD inScene : 1; /* A flag to check for proper BeginScene / EndScene call pairs */ > WORD softwareVertexProcessing : 1; /* process vertex shaders using software or hardware */ > - WORD useDrawStridedSlow : 1; > WORD filter_messages : 1; > - WORD padding : 8; > + WORD padding : 1; I don't think that's quite right.

2 2

Re: [PATCH 5/5] wined3d: Explicitly pass the state information to buffer_internal_preload
by Henri Verbeet 11 Sep '13

11 Sep '13

On 11 September 2013 11:31, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - /* Reading the declaration makes only sense if the stateblock is finalized and the buffer bound to a stream */ > - if (device->isInDraw && buffer->resource.bind_count > 0) > + /* Reading the declaration makes only sense if we have valid state information > + * (i.e., if this function is called during draws). */ > + if (state) Technically what needs to be valid is the stream info, although we probably don't care that much about the distinction.

1 0

Re: [PATCH 3/5] wined3d: Pass stream info and needed fixups to buffer_find_decl.
by Henri Verbeet 11 Sep '13

11 Sep '13

On 11 September 2013 11:31, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -330,7 +331,7 @@ static BOOL buffer_find_decl(struct wined3d_buffer *This) > if(This->resource.usage & WINED3DUSAGE_STATICDECL) return FALSE; > } > > - if (use_vs(state)) > + if (fixup_flags & WINED3D_BUFFER_FIXUP_USE_SHADER) It can actually be a bit simpler than that. Note that all the texcoord checks are redundant when "support_d3dcolor" is true, because declaration_element_valid_ffp() already prevents D3DCOLOR elements from being used with texcoords. That then implies you can mostly just pass the fixup mask to buffer_check_attribute(), and check for an empty fixup mask instead of vertex shader usage here. (Although that means inverting the flags as you have them right now.)

1 0

Re: (resend) gdi32: abc values remain the same despite any changes in layout direction or Viewport
by Marvin 11 Sep '13

11 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2103 Your paranoid android. === wxppro (32 bit font) === font.c:1323: Test failed: abcB should be unchanged font.c:1323: Test failed: abcC should be unchanged font.c:1323: Test failed: abcfB should be unchanged font.c:1323: Test failed: abcfC should be unchanged font.c:1345: Test failed: abcB should be unchanged font.c:1345: Test failed: abcC should be unchanged font.c:1345: Test failed: abcfB should be unchanged font.c:1345: Test failed: abcfC should be unchanged

1 0

Re: po: Add English (Philippines) resource (resend)
by Alexandre Julliard 11 Sep '13

11 Sep '13

Ken Sharp <kennybobs(a)o2.co.uk> writes: > @@ -111,6 +111,9 @@ filter: dummy > .svg.bmp: > CONVERT="$(CONVERT)" ICOTOOL="$(ICOTOOL)" RSVG="$(RSVG)" $(BUILDIMAGE) $< $@ > > +$(top_srcdir)/po/en_PH.po: $(top_srcdir)/po/en_US.po > + $(LN_S) -f en_US.po $@ > + You can't create links in the source tree, and in any case this should be done directly in wrc, with some sort of alias mechanism. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (resend) [PATCH] serial: wait_for_event() must set Information in PIO_STATUS_BLOCK
by Dmitry Timoshkov 11 Sep '13

11 Sep '13

Wolfgang Walter <wine(a)stwm.de> wrote: > - if (commio->iosb) commio->iosb->u.Status = *commio->events ? STATUS_SUCCESS : STATUS_CANCELLED; > + if (commio->iosb) { > + commio->iosb->u.Status = *commio->events ? STATUS_SUCCESS : STATUS_CANCELLED; > + if (*commio->events) > + commio->iosb->Information = sizeof(DWORD); > + } Did you run 'make test' with this change? Probably some todo_wine statements need to be removed. Also why 'Information' is set only in the case if events != 0? I'd guess that it should be set in any case since 'events' is always initialized. -- Dmitry.

1 0

Embedding a HWND window into an X11 window
by Alexandre Bique 10 Sep '13

10 Sep '13

Hi, How could I embed a HWND window created with CreateWindow() into an X11 window? Thanks! :-) -- Alexandre Bique

5 8

RFC: HKCR merge implementation
by George Stephanos 10 Sep '13

10 Sep '13

I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. Feel free to comment. So far, I've written code for all functions except for the RegEnum family. General description: HKCR handles are special. All wine handles have the two lowest bits zero'd. HKCR handles are masked. 10b specifically. They have their own table separate from the generic handle table. An HKCR handle has an HKCU handle and an HKLM handle below it. Access mask and a string representing the path are also needed since the handle has to attempt to reopen previously failed openings at certain stages. First patch: specially handles HKCR handles WITHOUT affecting the general behavior. The end result is still the exact same. Patch provides a foundation for the rest. Second patch: added path management Third patch: added HKCU Here's a quick description of each function: create_hkcr_struct: allocates the memory needed for the struct, adds it to the table and gives back a pointer to it get_hkcr_path: given an HKCR handle and a subkey string, prepares a subkey string representing the same subkey rooted at HKLM/HKCU. create_hkcr: RegCreateKeyEx open_hkcr: RegOpenKeyEx resolve_hkcr: checks the HKCR handle, tries to reopen previously failed internal handles, gives back HKCU first if available then HKLM close_hkcr: deallocates path and struct, removes struct from table.

1 0

Re: winemac: Don't return characters for Ctrl-(non-letter symbol) keypresses from ToUnicodeEx() as X11 driver already does (try 2)
by Ken Thomases 10 Sep '13

10 Sep '13

Hi, On Sep 9, 2013, at 7:38 PM, Phil Krylov wrote: > Sorry, my first try had wrong patch attached > > -- Ph. > <0001-winemac-Don-t-return-characters-for-Ctrl-non-letter-try2.patch.txt> Is there a specific problem that you're trying to fix? The Mac driver's ToUnicodeEx() implementation started out very similar to the X11 driver's. It was basically a copy that I hacked on. It originally had this same restriction. However, some testing revealed that this is not an absolute restriction on Windows. For example, in the Khmer keyboard layout, Control-<digit> produces characters for some digits. Given that some Windows keyboard layouts produce characters for Control-<digit>, I figured it was best left up to the Mac keyboard layout. Similarly for Control-<punctuation>. For example, the Windows Chinese keyboard layouts produce characters for some of those keystrokes. So does the Czech layout. It might still be possible to re-introduce this restriction if it can be justified based on broad breakage of apps. Although even then, I'd want to make it possible to override the restriction with a registry setting or something. You never know if the ability to enter characters using these key combinations might be crucial for certain Mac users because of the nature of their native keyboard layout. If a modification like this were justified, it should go earlier in macdrv_ToUnicodeEx(). There's a section at the top where I moved the checks for combinations that don't produce characters. Also, the check should test that Alt is _not_ pressed, since Control-Alt-<digit or punct> and Control-Alt-Shfit-<digit or punct> very commonly produce characters. Control-Alt is a synonym for the AltGr key on some keyboards (e.g. Swiss). Finally, if we're going to pursue this, there are some minor style issues I'd prefer be changed. So, check with me before resubmitting. Thanks and cheers, Ken

2 2