December 2014 - Wine-devel - list.winehq.org

Any last UTF-7 comments?
by Alex Henrie 29 Dec '14

29 Dec '14

Now that Alexandre has merged a complete set of UTF-7 tests, are there any more comments on the two implementation patches before I submit those as well? https://github.com/alexhenrie/wine/commits/master -Alex

1 0

Re: [PATCH] dsound: allow LOCHARDWARE flag
by Alexandre Julliard 29 Dec '14

29 Dec '14

Mark Harmstone <hellas(a)burntcomma.com> writes: > @@ -975,12 +975,6 @@ HRESULT DirectSoundDevice_CreateSoundBuffer( > TRACE("(lpwfxFormat=%p)\n",dsbd->lpwfxFormat); > } > > - if (dsbd->dwFlags & DSBCAPS_LOCHARDWARE && > - !(dsbd->dwFlags & DSBCAPS_PRIMARYBUFFER)) { > - TRACE("LOCHARDWARE is not supported, returning E_NOTIMPL\n"); > - return E_NOTIMPL; > - } > - It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M dsound.dll -p dsound_test.exe.so dsound && touch dsound.ok dsound.c:1705: Test failed: CreateSoundBuffer(1) gave wrong error: 00000000 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll: fix read_directory_getdirentries() under FreeBSD.
by André Hentschel 29 Dec '14

29 Dec '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 28.12.2014 um 21:09 schrieb David Naylor: > > Change the handling of getdirentries(2) by: - tracking the data pointer instead of subtracting 'res' - simplify rewind by skipping re-appending entries onto the list - try make the logic easier to follow --- dlls/ntdll/directory.c | 73 +++++++++++++++++++------------------------------- 1 file changed, 28 insertions(+), 45 deletions(-) Hi and welcome to Wine development, maybe it's just me, but the patch is not easy to review. Is it possible to split the patch into multiple atomic patches (maybe three, as in the change list you provided)? Also, how does the patch fix Wine on FreeBSD? A quick look at the patch itself: You missed a whitespace at the last lseek call. You're adding a FIXME comment, but you should rather clarify your question, use wine-devel and/or IRC and/or "git blame" for that. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQGcBAEBAgAGBQJUoVfbAAoJEGm5GZTakYssGkoMAIfOM3ulOIh28PKA3RS0IByC sEk8AerEkKyN2nS4d2hNRU/kHIFlW+wHfi8Ah7FhBGepZ0HIHrWqZhuMmZsYx1W/ MeYyW+bROa+uCGWYvz7w9aaXW+xOIKDaJ7mIQrJKnkMgOQ3FFI8yKa6tRSSAm6iA Xg2porB96Ov+lLcl6zq0UATuVgqENhzSRrMxHh/YhVwK3xO7hSQ4ysgMJj2cBg7A XX7cEdxys1X5kSAO10I/gucmtKe3GrQi++DWx6VUd1O4WIEtm86c1gO2UtbUxYNf p9q5feajTJLscWOKpaC032fLrfFcnkhSS1ZwyIl7TfICaWW6u+8zfrcrVG8xfPkR MfbCRrJpkCFXsa5bYJLTPdD+0LETPlJ48zkyRyny56XYwgkBlgPirVlCeYnSZs9t CCOaHYYrMePAyB1DLZeJIdCCmyy8gLlY9cu28SgbN/oaHuYtwfrPbXKt30fwhZyM cOcTZnZZuYSeb5oVt72O+j0GbkSW2x+juFuVhyBvlw== =RACU -----END PGP SIGNATURE-----

2 3

Re: secur32: Always tell the user that libgnutls could not be loaded
by Henri Verbeet 29 Dec '14

29 Dec '14

On 28 December 2014 at 13:00, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Ensures a message is printed in the standard output to make the > problem obvious. Will solve problems like the one in > https://bugs.winehq.org/show_bug.cgi?id=35180#c4: > You'd probably want that to go to the winediag channel then.

1 0

Re: [PATCH] dsound: allow LOCHARDWARE flag
by Andrew Eikum 29 Dec '14

29 Dec '14

Mark's dsound and alsa patches look OK to me. Andrew On Sun, Dec 28, 2014 at 01:54:27PM +0000, Mark Harmstone wrote: > Patch to allow DSound buffers to be created with the DSBCAPS_LOCHARDWARE > flag. There's been no audio hardware acceleration on Windows since XP, so > this flag is meaningless nowadays anyway - but X3DAudio will refuse to > create a buffer of more than two channels if it's not accepted. > > --- > dlls/dsound/dsound.c | 6 ------ > 1 file changed, 6 deletions(-) > > > diff --git a/dlls/dsound/dsound.c b/dlls/dsound/dsound.c > index 8df778a..eaa4247 100644 > --- a/dlls/dsound/dsound.c > +++ b/dlls/dsound/dsound.c > @@ -975,12 +975,6 @@ HRESULT DirectSoundDevice_CreateSoundBuffer( > TRACE("(lpwfxFormat=%p)\n",dsbd->lpwfxFormat); > } > > - if (dsbd->dwFlags & DSBCAPS_LOCHARDWARE && > - !(dsbd->dwFlags & DSBCAPS_PRIMARYBUFFER)) { > - TRACE("LOCHARDWARE is not supported, returning E_NOTIMPL\n"); > - return E_NOTIMPL; > - } > - > if (dsbd->dwFlags & DSBCAPS_PRIMARYBUFFER) { > if (dsbd->lpwfxFormat != NULL) { > WARN("invalid parameter: dsbd->lpwfxFormat must be NULL for " > >

1 0

Re: [PATCH] dsound: convert freqAdjust and freqAcc to integers
by Andrew Eikum 29 Dec '14

29 Dec '14

On Sat, Dec 27, 2014 at 11:41:07PM +0100, Marton Balint wrote: > Fixes resamping errors caused by truncating floating point numbers. These > errors were responsible for clicking noises when resampling from 44100 to 48000 > Hz, as mentioned in bug 35971. > I was able to reproduce this, and this patch fixes it. Looks good to me. Andrew

1 0

Re: [PATCH] msvcr120: Implemented Concurrency::details::_Condition_variable. (try 2)
by Piotr Caban 29 Dec '14

29 Dec '14

On 12/26/14 20:20, Yifu Wang wrote: > --- > dlls/msvcp90/msvcp90.h | 23 ++++ > dlls/msvcr120/msvcr120.spec | 36 +++--- > dlls/msvcr120/tests/msvcr120.c | 267 ++++++++++++++++++++++++++++++++++++++-- > dlls/msvcrt/lock.c | 172 ++++++++++++++++++++++++++ > 4 files changed, 471 insertions(+), 27 deletions(-) The tests are sometimes failing for me (on windows): msvcr120: 74522 tests executed (0 marked as todo, 0 failures), 0 skipped. msvcr120.c:381: Test failed: produced != consumed msvcr120: 108919 tests executed (0 marked as todo, 1 failure), 0 skipped. Thanks, Piotr

1 0

Re: iphlpapi: add FreeMibTable implementation (try 2)
by Nikolay Sivov 28 Dec '14

28 Dec '14

On 27.12.2014 7:04, Austin English wrote: > > +/****************************************************************** > + * FreeMibTable (IPHLPAPI.@) > + * > + * Free buffer allocated by network functions > + * > + * PARAMS > + * ptr [In] pointer to the buffer to free > + * > + * RETURNS > + * Success: TRUE > + * Failure: FALSE As Thomas pointed out, this is wrong. > + */ > +void WINAPI FreeMibTable (PVOID *ptr) > +{ > + TRACE("(ptr %p): stub\n", ptr); > + HeapFree(GetProcessHeap(), 0, ptr); > +} Argument type should be 'void *'. Trace message could be just '(%p)\n'.

1 0

Re: iphlpapi: add FreeMibTable implementation (try 2)
by Thomas Faber 28 Dec '14

28 Dec '14

> Try 2: fixed specfile, comment Actually the fixed comment still seems wrong since the function returns void ;)

1 0

CSMT patch
by Emanuele Oriani 28 Dec '14

28 Dec '14

Hi Wine Devs/Stefan, Can you please give us an update in regards to the CSMT patch? Do you plan to integrate it in mainline? If not "officially", would be possible to have it in as an experimental code-path (default off)? What are the obstacles of making this happen? What is your view? Again, I believe this patch is superior to just NVIDIA Threaded Optimizations; on applications such as Starcraft II I get +150% FPS and performance is comparable to windows (if not better). I believe many other games would benefit from this great improvement. Cheers, Emanuele

5 6