December 2014 - Wine-devel - list.winehq.org

Re: iphlpapi: add FreeMibTable implementation
by Dmitry Timoshkov 27 Dec '14

27 Dec '14

Austin English <austinenglish(a)gmail.com> wrote: > -#@ stub FreeMibTable > +@ stub FreeMibTable( ptr ) This won't work as expected. -- Dmitry.

2 1

Re: gdi32: add FreeMibtable implementation
by Bruno Jesus 27 Dec '14

27 Dec '14

On Sat, Dec 27, 2014 at 12:51 AM, Austin English <austinenglish(a)gmail.com> wrote: > https://bugs.winehq.org/show_bug.cgi?id=36092 Wrong patch subject? Shouldn't it be: iphlpapi: Add FreeMibTable implementation > -- > -Austin > > >

2 1

Re: [PATCH (resend)] kernel32/tests: Add tabular UTF-7 encoding tests.
by Alex Henrie 24 Dec '14

24 Dec '14

Alexandre, I need to know why you are ignoring this patch so that I can improve it to meet your standards. -Alex

1 1

Holidays
by Alexandre Julliard 24 Dec '14

24 Dec '14

Folks, Like probably most of you, I will be out for a few days for the holidays, so I'm going to skip this week's release. I expect things to be fairly slow next week too. I'll still commit patches when I'm around, but the next release will be on January 9. Enjoy your holidays! -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] dsound: do not allow adding a NULL ptr as buffer in DirectSoundDevice_AddBuffer()
by Nikolay Sivov 24 Dec '14

24 Dec '14

On 12/24/2014 04:55 PM, Pierre Schweitzer wrote: > Dear all, > > Please find attach a patch which prevents DirectSoundDevice_AddBuffer() > from accepting NULL pointers. > It results from a bugfix & testing here. While trying to start Steam > Lego Star Wars, I was experiencing an invalid address dereference in > DSOUND_ChangeListener() (line 312). > > Adding this check makes the game work properly (with sound). I tested it. > > Cheers, > Please add a test for that.

2 2

Re: mshtml: Allow '#' to be the first char of resource name in res protocol.
by Marvin 24 Dec '14

24 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10902 Your paranoid android. === w2000pro (32 bit protocol) === protocol.c:259: Test failed: expected ReportProgress protocol.c:259: Test failed: expected ReportProgress

1 0

Re: [PATCH 4/4] mshtml: Added script element readyState and onreadystatechange tests.
by Marvin 24 Dec '14

24 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10901 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH] msvcp120: Implemented xtime functions.
by Piotr Caban 23 Dec '14

23 Dec '14

Hi, the tests are failing on windows (and sometimes on wine). Please also test return value of xtime_get and check if values returned by it are similar to what native does. Thanks, Piotr

1 0

Re: [PATCH] msvcr120: Implemented Concurrency::details::_Condition_variable.
by Piotr Caban 23 Dec '14

23 Dec '14

Hi, I was not really looking on this patches yet but I've seen few issues: - you forgot to call init_thiscall_thunk function - there are some compilation warnings - the tests are not passing on windows Thanks, Piotr

1 0

Re: [PATCH 2/3] gdiplus: fix get_clip_hrgn when window origin point changed
by Dmitry Timoshkov 23 Dec '14

23 Dec '14

"Changhui Liu" <liuchanghui(a)linuxdeepin.com> wrote: > --- a/dlls/gdiplus/graphics.c > +++ b/dlls/gdiplus/graphics.c > @@ -350,7 +350,18 @@ static void gdi_alpha_blend(GpGraphics *graphics, INT dst_x, INT dst_y, INT dst_ > static GpStatus get_clip_hrgn(GpGraphics *graphics, HRGN *hrgn) > { > /* clipping region is in device coords */ > - return GdipGetRegionHRgn(graphics->clip, NULL, hrgn); > + GpStatus state = GdipGetRegionHRgn(graphics->clip, NULL, hrgn); Please use 'status' instead of 'state'. > + if (graphics->hdc) > + { This should be if (status == Ok && graphics->hdc) > --- a/dlls/gdiplus/tests/graphics.c > +++ b/dlls/gdiplus/tests/graphics.c > @@ -5603,6 +5603,95 @@ static void test_GdipGetVisibleClipBounds_memoryDC(void) > ReleaseDC(hwnd, dc); > } > > +#define BLUE_COLOR (0xff0000ff) > +#define IsBlue(color) ( ((color) & 0x00ffffff) == 0xff ) > +#define GetBitmapPixel(x,y) pixel[(y)*(width) + (x)] Inline helpers without Win32 API resembling names would be better. Something like is_blue_color, get_bitmap_pixel. Same applies for remaining code. -- Dmitry.

1 0