March 2014 - Wine-devel - list.winehq.org

Re: [PATCH 4/5] d3d9/tests: Use a separate device for sincos_test().
by Marvin 25 Mar '14

25 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5940 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 3/5] d3d9/tests: Use a separate device for sgn_test().
by Marvin 25 Mar '14

25 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5939 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 2/5] d3d9/tests: Use a separate device for clip_planes_test().
by Marvin 25 Mar '14

25 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5938 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: riched20/tests: Add tests for ITextDocument::Open about dealing with rtf. (try 2)
by Nikolay Sivov 25 Mar '14

25 Mar '14

On 3/19/2014 17:02, Jactry Zeng wrote: > Update: > - Add a todo_wine. > > + ITextDocument_Open(txtDoc, &testfile, tomReadOnly|tomRTF, CP_ACP); It's a common practice to check a return value. > + /* open a rtf without } in the end */ > + result = ITextDocument_Open(txtDoc, &testfile, tomReadOnly, CP_ACP); > + /* 0x80070026 is HRESUILT_FROM_WIN32(ERROR_HANDLE_EOF) */ > + todo_wine ok(result == 0x80070026, "ITextDocument_Open: Should return an ERROR_HANDLE_EOF error.\n"); No need to put a magic number, use HRESULT_FROM_WIN32(), and don't forget to use proper type for return value. Also a typo in a comment, but that it go anyway.

2 1

Re: wintab: Incorrectly classifying cursor as stylus instead of eraser
by Alexandre Julliard 25 Mar '14

25 Mar '14

Eriks Dobelis <eriks.dobelis(a)biti.lv> writes: > Did not attach the patch in my last email :( > > For Wacom Pen & Touch Intuos tablet eraser cursor is incorrectly > detected as stylus. > The tablet returns its eraser cursor name as: > Wacom Intuos PT S Pen eraser > and type as: > ERASER > > Current code classifies this as STYLUS, because name of the cursor > contains the word 'Pen'. It is very unlikely that a cursor with type > ERASER is STYLUS. There is already a check for eraser type, you should be able to use that instead. -- Alexandre Julliard julliard(a)winehq.org

4 6

Re: user32: Fix side effect in SubtractRect()
by Nikolay Sivov 24 Mar '14

24 Mar '14

Hi, Jose. Please add a test case for this change to user32/tests/uitools.c

2 3

Re: user32: Workaround SetForegroundWindow failure due to foreground lock timeout
by Marvin 24 Mar '14

24 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5923 Your paranoid android. === w8 (32 bit win) === win.c:6403: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6425: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6403: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6403: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6403: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6403: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6403: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6425: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6403: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6425: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:6186: Test failed: wrong error 31

1 0

Re: [PATCH 2/2] wininet: Fixed tests on some old Windows versions.
by Marvin 24 Mar '14

24 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5909 Your paranoid android. === w8 (32 bit http) === http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:318: Test failed: unexpected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) http.c:318: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:4292: Test failed: INTERNET_OPTION_SECURITY_FLAGS flags = 1800000, expected 800000 http.c:4292: Test failed: INTERNET_OPTION_SECURITY_FLAGS(98) flags = 1800000, expected 800000 http.c:4295: Test failed: INTERNET_OPTION_SECURITY_FLAGS flags = 1800080, expected 800080 http.c:4295: Test failed: INTERNET_OPTION_SECURITY_FLAGS(98) flags = 1800080, expected 800080 http.c:318: Test failed: unexpected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) http.c:318: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:957: Test failed: expected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) 2 times, received 1 times http.c:958: Test failed: expected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) 2 times, received 1 times http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:4620: Test failed: expected ERROR_HTTP_HEADER_NOT_FOUND, got 0

2 1

Re: [PATCH 1/2] wininet: Merge GetLastError() test into other request tests.
by Marvin 24 Mar '14

24 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5908 Your paranoid android. === w2000pro (32 bit http) === http.c:3058: Test failed: expected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) 1 times, received 0 times http.c:3059: Test failed: expected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) 1 times, received 0 times === w8 (32 bit http) === http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:318: Test failed: unexpected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) http.c:318: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:4284: Test failed: INTERNET_OPTION_SECURITY_FLAGS flags = 1800000, expected 800000 http.c:4284: Test failed: INTERNET_OPTION_SECURITY_FLAGS(98) flags = 1800000, expected 800000 http.c:4287: Test failed: INTERNET_OPTION_SECURITY_FLAGS flags = 1800080, expected 800080 http.c:4287: Test failed: INTERNET_OPTION_SECURITY_FLAGS(98) flags = 1800080, expected 800080 http.c:318: Test failed: unexpected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) http.c:318: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:957: Test failed: expected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) 2 times, received 1 times http.c:958: Test failed: expected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) 2 times, received 1 times http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:4612: Test failed: expected ERROR_HTTP_HEADER_NOT_FOUND, got 0

1 0

Re: dxdiagn: Added properties for hardware acceleration capabilities
by Stefan Dösinger 24 Mar '14

24 Mar '14

Am 23.03.2014 um 04:18 schrieb Markus Weiland <mw(a)graph-ix.net>: > This patch addresses bug http://bugs.winehq.org/show_bug.cgi?id=11114 I filed four years ago. It hardcodes the b3DAccelerationExists, b3DAccelerationEnabled, and bDDAccelerationEnabled properties to TRUE. IDirect3D9::GetDeviceCaps with D3DDEVTYPE_HAL should do. If the call suceeds you have hardware acceleration.

3 3