March 2014 - Wine-devel - list.winehq.org

Add a program to Wine Programs menu
by Robson 21 Mar '14

21 Mar '14

Hello, I saw the post below with a way to add a program to Wine Programs menu: https://answers.launchpad.net/ubuntu/+source/wine/+question/148594 Suggestion: add a tab in the configuration interface of wine to add remove or edit program shortcuts. With that the User can easily and quickly organize your shortcuts to favorite programs. Thanks.

1 0

GSoC 2014 proposal - Implement VBScript built-in functions
by 孟帅 21 Mar '14

21 Mar '14

Hi all! I'm Shuai Meng, a student from software school of Beihang University, China, GMT+08:00. I'm pursuing a master degree and now in grade one. You can call me shuaimeng, that's my nickname used in irc. Now I'm here to apply for GSoC to work for Wine. I'm familiar with C, and I can code with python as well. Besides, I know a little about html and vbscript. From May to August, I have plenty of free time. About one year ago I started my way to linux, it's not smooth for a person who had got used to windows then embrace linux. Soon I got a problem: QQ(the most popular IM software in China) doesn't support linux, but I really need it. Fortunately I knew wine through searching google, it helped me solve this problem.Since then I have become a wine user. In the past three months, I had focused on dlls/vbscript/global.c, searching MSDN for related documents[1]~[4]. Accordding those documents, I added more tests in dlls/vbscript/tests/api.vbs, then got some similar bugs and only reported one[5]. In order to fix them, I read wine source code in dlls/vbscript/global.c, again and again. Finally I finished a few draft patches[6] and I will send them to wine-patches later. As I have made so much effort in this module and gain a little experience, during GSoC this part will go on to occupy most of my attention. On the basis of difficulty to be implemented, I divide all the functions in dlls/vbscript/global.c into four groups as following: 1: Abs ScriptEngine ScriptEngineBuildVersion ScriptEngineMajorVersion IsArray IsDate IsNumeric IsObject Sgn TypeName VarType These are the easiest to implement, I will take about one week to finish the unimplemented. 2: FormatCurrency FormatDateTime FormatPercent Hour FormatNumber Join Minute Month Oct Rnd Second Space TimeValue Year The second group will occupy two weeks of the whole GSoC time. They are not as easy as the first group and there are more to be accomplished. Most of them are involved in time functions while a few is about strings. 3: Asc Ant Cos DateAdd DateDiff DatePart DateSerial Day Exp LBound Log Replace Sin Sqr String Tan TimeSerial UBound Weekday CBool CByte CCur CDate CDbl CInt CLng CSng CStr InStrRev Int Fix StrComp Timer These are more difficult. However a large part is conversion functions and they have been implemented or improved by me. You can find the details in attchment. Optimistically speaking, I need at least three weeks to complete all of them. When I finish that, this bug[7] will be fixed. 4: Array Date DateValue Escape Eval Filter GetLocale GetRef InputBox LoadPicture Now RGB SetLocale Split Time Unescape Here come the most difficult ones. I am not so sure whether I can fix or even understand them, but I will try my best. Maybe after I have finish the above three groups, I can gain a little confidence to face them. This group would cost me four weeks or even longer. If I have a good luck, maybe I can fix this bug[8]. To be prudent, I'll spare at least one week to do a review on all my codes. Write a summary as a guidence for my work to be continued after GSoC. Though I have a rough plan now, as a greenhand to wine, I hava too much to learn and I badly need advice from all of you. I hope I can make a proper schedule after communicating with my mentor. Any comment or advice is greatly appreciated. Thank you! [1]http://msdn.microsoft.com/en-us/library/9e7a57cf(v=vs.84).aspx [2]http://msdn.microsoft.com/en-us/library/t7zd6etz(v=vs.84).aspx [3]http://msdn.microsoft.com/en-us/library/3ca8tfek(v=vs.84).aspx [4]http://msdn.microsoft.com/en-us/library/10wcf65z(v=vs.84).aspx [5]http://bugs.winehq.org/show_bug.cgi?id=35441 [6]In the attachment [7]http://bugs.winehq.org/show_bug.cgi?id=34913 [8]http://bugs.winehq.org/show_bug.cgi?id=35472

4 4

Re: netcfgx: Add INetCfg interface support
by Marvin 21 Mar '14

21 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5820 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

3 2

Re: [1/3] widl: Pass type attributes from write_array_tfs to write_pointer_description. Take 2.
by Nikolay Sivov 21 Mar '14

21 Mar '14

On 3/21/2014 11:09, Dmitry Timoshkov wrote: > This allows to differentiate strings and write appropriate rpc type > (FC_C_C[W]STRING instead of FC_[W]CHAR). > > This version of the patch limits write_array_tfs() to pass attributes > to write_pointer_description() only for strings and avoids unwanted > changes to other pointer types. > --- > tools/widl/typegen.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c > index 37d18f5..889d8c5 100644 > --- a/tools/widl/typegen.c > +++ b/tools/widl/typegen.c > @@ -2728,7 +2728,7 @@ static int write_varying_array_pointer_descriptions( > return pointer_count; > } > > -static void write_pointer_description(FILE *file, type_t *type, > +static void write_pointer_description(FILE *file, const attr_list_t *attrs, type_t *type, > unsigned int *typestring_offset) > { > unsigned int offset_in_buffer; > @@ -2757,7 +2757,7 @@ static void write_pointer_description(FILE *file, type_t *type, > if (is_conformant_array(type) && > (type_array_is_decl_as_ptr(type) || !current_structure)) > write_conformant_array_pointer_descriptions( > - file, NULL, type, 0, typestring_offset); > + file, attrs, type, 0, typestring_offset); > else if (type_get_type(type) == TYPE_STRUCT && > get_struct_fc(type) == RPC_FC_CPSTRUCT) > { > @@ -2962,7 +2962,7 @@ static unsigned int write_array_tfs(FILE *file, const attr_list_t *attrs, type_t > print_file(file, 2, "0x%x,\t/* FC_PP */\n", RPC_FC_PP); > print_file(file, 2, "0x%x,\t/* FC_PAD */\n", RPC_FC_PAD); > *typestring_offset += 2; > - write_pointer_description(file, type, typestring_offset); > + write_pointer_description(file, is_string_type(attrs, type) ? attrs : NULL, type, typestring_offset); I think it'd be cleaner to let write_pointer_description() handle that, as now you pass all needed info in anyway.

2 1

Re: [3/3] rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Resend.
by Marvin 21 Mar '14

21 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5825 Your paranoid android. === build (build) === Make failed

1 0

GSoC 2014: Student application period is almost over!
by Austin English 20 Mar '14

20 Mar '14

Howdy everyone, If you're a student that wants to apply for GSoC 2014, you have until tomorrow*, **March 21 at 19:00 UTC*, to submit your proposals. See https://www.google-melange.com/gsoc/events/google/gsoc2014 for the timeline, and https://www.google-melange.com/gsoc/org2/google/gsoc2014/wine I'd like to also remind students that a patch or testcase must have been submitted to wine before to be considered. It is not required to have been accepted, but you must show that you are able to build/tinker on wine's source code. See http://wiki.winehq.org/SummerOfCode and http://wiki.winehq.org/SubmittingPatches for more info. Good luck! -- -Austin

1 0

Re: [PATCH 3/6] d3d8: Use the private store api for buffers.
by Henri Verbeet 20 Mar '14

20 Mar '14

On 20 March 2014 12:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (stored_data->flags & WINED3DSPD_IUNKNOWN) > + { > + *(IUnknown **)data = stored_data->content.object; > + IUnknown_AddRef(*(IUnknown **)data); > + } > + else > + memcpy(data, stored_data->content.data, stored_data->size); + if (stored_data->flags & WINED3DSPD_IUNKNOWN) + IUnknown_AddRef(stored_data->content.object); + memcpy(data, stored_data->content.data, stored_data->size);

1 0

Re: [PATCH 1/6] wined3d: Remove the version parameter (try 2).
by Henri Verbeet 20 Mar '14

20 Mar '14

On 20 March 2014 12:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (!(caps.ddraw_caps.caps & WINEDDCAPS_3D)) > + { > + WARN("Created a wined3d object without 3D support.\n"); > + wined3d_decref(d3d8->wined3d); > + goto done; > + } I don't think that really matches Windows. Going by the testbot results, I think creating a D3D object should succeed, and creating a (hardware) device should fail.

2 5

Re: [PATCH] scrrun/tests: Update idl file in tests
by Marvin 20 Mar '14

20 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5791 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

2 1

Re: regsvr32: Replace printf calls with WriteConsole function (try 2)
by Akihiro Sagawa 20 Mar '14

20 Mar '14

On Tue, 18 Mar 2014 21:26:30 -0400, Hugh McMaster wrote: > This patch adds the function output_write to regsvr32.c. The function > calls LoadString, FormatMessage and WriteConsole to output string text > to the console. This patch sequence looks nice. It will resolve bug 28189. Thanks, Akihiro Sagawa

1 0